[PATCH 3/4] sdk: Control isar-apt list removing

[PATCH 3/4] sdk: Control isar-apt list removing

[Anton Mikanovich]

07/12/2023 02:55, Jan Kiszka wrote:
> This says what it does, not why.
>
> Does that isar-apt list really make any sense outside of the build
> environment?
>
> Jan

I assume saying SDK_INCLUDE_ISAR_APT should actually include isar-apt 
into SDK
is not really needed.

You can look into 'Create an ISAR SDK root filesystem' section of 
user_manual.md
for outside of the build env example.

[PATCH 0/4] Fixing isar-apt usage inside SDK

[Anton Mikanovich]

This patchset fixes SDK prepare code to provide isar-apt based on
SDK_INCLUDE_ISAR_APT value. It also improves Isar documentation for SDK usage.

Anton Mikanovich (4):
  rootfs: Split isar-apt and base-apt cleanup
  sdk: Remove duplicated isar-apt cleanup
  sdk: Control isar-apt list removing
  doc/user_manual.md: Improve SDK usage howto

 doc/user_manual.md          | 31 ++++++++++++++++++++++++++++---
 meta/classes/rootfs.bbclass |  8 ++++++++
 meta/classes/sdk.bbclass    |  7 ++-----
 3 files changed, 38 insertions(+), 8 deletions(-)

-- 
2.34.1

[PATCH 3/4] sdk: Control isar-apt list removing

[Anton Mikanovich]

Do not remove isar-apt.list in case SDK_INCLUDE_ISAR_APT enabled.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 meta/classes/sdk.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
index e76f7930..52c3bec5 100644
--- a/meta/classes/sdk.bbclass
+++ b/meta/classes/sdk.bbclass
@@ -68,6 +68,8 @@ SDKROOTFSVARDEPS = ""
 SDKROOTFSVARDEPS:class-sdk = "SDK_INCLUDE_ISAR_APT"
 do_rootfs_install[vardeps] += "${SDKROOTFSVARDEPS}"
 
+ROOTFS_POSTPROCESS_COMMAND:remove = "${@'rootfs_cleanup_isar_apt' if d.getVar('SDK_INCLUDE_ISAR_APT') == '1' else ''}"
+
 # additional SDK steps
 ROOTFS_CONFIGURE_COMMAND:append:class-sdk = " ${@'rootfs_configure_isar_apt_dir' if d.getVar('SDK_INCLUDE_ISAR_APT') == '1' else ''}"
 rootfs_configure_isar_apt_dir() {
-- 
2.34.1

Re: [PATCH 3/4] sdk: Control isar-apt list removing

[Jan Kiszka]

On 06.12.23 20:12, Anton Mikanovich wrote:
> Do not remove isar-apt.list in case SDK_INCLUDE_ISAR_APT enabled.
> 

This says what it does, not why.

Does that isar-apt list really make any sense outside of the build
environment?

Jan

> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/sdk.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> index e76f7930..52c3bec5 100644
> --- a/meta/classes/sdk.bbclass
> +++ b/meta/classes/sdk.bbclass
> @@ -68,6 +68,8 @@ SDKROOTFSVARDEPS = ""
>  SDKROOTFSVARDEPS:class-sdk = "SDK_INCLUDE_ISAR_APT"
>  do_rootfs_install[vardeps] += "${SDKROOTFSVARDEPS}"
>  
> +ROOTFS_POSTPROCESS_COMMAND:remove = "${@'rootfs_cleanup_isar_apt' if d.getVar('SDK_INCLUDE_ISAR_APT') == '1' else ''}"
> +
>  # additional SDK steps
>  ROOTFS_CONFIGURE_COMMAND:append:class-sdk = " ${@'rootfs_configure_isar_apt_dir' if d.getVar('SDK_INCLUDE_ISAR_APT') == '1' else ''}"
>  rootfs_configure_isar_apt_dir() {

-- 
Siemens AG, Technology
Linux Expert Center

Re: [PATCH 3/4] sdk: Control isar-apt list removing

[Baurzhan Ismagulov]

On 2023-12-07 09:55, 'Jan Kiszka' via isar-users wrote:
> > Do not remove isar-apt.list in case SDK_INCLUDE_ISAR_APT enabled.
> 
> This says what it does, not why.
> 
> Does that isar-apt list really make any sense outside of the build
> environment?

isar-apt is essential for sdk users who have big or complex application
dependencies. It enables hello developer to do apt-get build-dep hello and get
all dependencies installed in the sdk.

This series fixes a regression of an existing feature. The motivation is
described in
https://github.com/ilbers/isar/blob/next/doc/user_manual.md#create-an-isar-sdk-root-filesystem
but the use case could be defined in more specific terms; we'll send a separate
patch for that.

With kind regards,
Baurzhan