From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6827348902787678208 X-Received: by 2002:a05:6402:17ba:: with SMTP id j26mr3119319edy.324.1590423189579; Mon, 25 May 2020 09:13:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:d2d2:: with SMTP id k18ls9313038edr.3.gmail; Mon, 25 May 2020 09:13:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTxlLzyMJ6tKzsSMP1bC+ohmhqC6oU0la0jW+reXv5mm5fgdthx0N7FnbMi2UB86ZbOPTW X-Received: by 2002:a05:6402:1d06:: with SMTP id dg6mr16286023edb.314.1590423188897; Mon, 25 May 2020 09:13:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590423188; cv=none; d=google.com; s=arc-20160816; b=oJLj0g0rcqHYSxXwmp/4efFy+FmJoAx78INw+FSKJ+hc6yzywH4RKEHkG8kK/WE8ig XgRwSKylpxTg0vYOdXJT9k1Ey3Vj0IoZ6AIfC1ndgHqCY6L1AuMc8D9B5dKerCUJETG4 doKsPp4En93uZxu/KcH6xaT6nAIs9QJswKtVXa6gxtZ0jo8pusJvQAoPDAzXvhs8P6TB FZZXgGcxx6tfJYDOSqB68FNg5BGDRRd+YECl99/B2tTrPXLooSjXCaGxSnGUSZt1x+1H 0cyb7dCuGe1PhlUQd2vPN6vDNTGwwC+KxLvlNVilsxuzAXskgjx8kYtMffv3dxp60+wy K4Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=IAMhB361gxesnqqjn2AnWAXIo91xc+lmPSfO+5sABUE=; b=QIRedYWD10GkhGvvJd6o0kAGvfYcwUK5u7lH+GtgN295eWpvhaUI3goWKA1MKuSetC 0t0kZ8YQTcLg+ZYfsEHpI2hJId3tHoNbpEO0AaFjOIJsHzNDvX4lN+Evf4iIv6aC/PPE 58SVjlNBTv+OU4Zajpvos75765KSQEfqqhyY+nj0S7H++5Oqri4nfBNF5eKtzSRfwH1x M1I+p/wHSv3S4umQywa+X+4oSx8Mpt2mlwC5NgRGNiljn7peqRy68byhVHmUtALMeZ8t 1UvpcCwYqbyU+GMeO4tUFy8iXen5ohjrM1NTehAk2ruRU3ZDLPpoZA7miNY3FGZGaZwB 7fbQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id a2si645930edq.3.2020.05.25.09.13.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 May 2020 09:13:08 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 04PGD8Gf025397 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 25 May 2020 18:13:08 +0200 Received: from [167.87.134.68] ([167.87.134.68]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 04PGD4YO014318 for ; Mon, 25 May 2020 18:13:07 +0200 Subject: Re: [PATCH] devshell: Use different termination test to avoid warnings To: isar-users References: <3b659fd0-15bb-d74c-8460-ffd67651401f@web.de> <20200525161124.h2qsivjotymjcdpv@yssyq.m.ilbers.de> From: Jan Kiszka Message-ID: Date: Mon, 25 May 2020 18:13:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200525161124.h2qsivjotymjcdpv@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: uhaueVRSmqmJ On 25.05.20 18:11, Baurzhan Ismagulov wrote: > On Sat, May 16, 2020 at 10:00:37AM +0200, Jan Kiszka wrote: >> As we run the terminal via a sudo chroot, OE's way of testing for the >> existence of the target PID does not work. It will rather fail early due >> to missing permissions (user tries to send signal to root process), and >> we will wait in the unmount loop, generating warnings like >> >> WARNING: mc:qemuamd64-buster:example-raw-0.3-r0 do_devshell: /work/build/tmp/deploy/buildchroot-target/debian-buster-amd64//home/builder/example-raw: Couldn't unmount, retrying... >> >> This replaces the kill(pid, 0) with a test for the existence of the >> corresponding /proc/ directory. > > Applied to next, thanks. > > Is there anything against submitting this upstream, too? > We need a reason, and that is - to my understanding - not in sight for upstream OE. Jan