[PATCH] dpkg-source: lock isar-apt while do_fetch_common_source

[PATCH] dpkg-source: lock isar-apt while do_fetch_common_source

[Uladzimir Bely]

Task do_fetch_common_source requires isar-apt repo unchanged while
running "apt-get ... source ..." inside. Otherwise, it may fail on repo
"Sources" or "Packages" file:

```
Err:4 file:/isar-apt isar/main Sources
  Hash Sum mismatch
```
This is quite often reproduced in CI since commit 2ca3a7e.

Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
---
 meta/classes/dpkg-source.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/dpkg-source.bbclass b/meta/classes/dpkg-source.bbclass
index d6ab5aad..a70a392d 100644
--- a/meta/classes/dpkg-source.bbclass
+++ b/meta/classes/dpkg-source.bbclass
@@ -41,6 +41,7 @@ do_dpkg_build[depends] += "${BPN}:do_deploy_source"
 SCHROOT_MOUNTS = "${WORKDIR}:/work ${REPO_ISAR_DIR}/${DISTRO}:/isar-apt"
 
 do_fetch_common_source[depends] += "${SCHROOT_DEP} ${BPN}:do_deploy_source"
+do_fetch_common_source[lockfiles] = "${REPO_ISAR_DIR}/isar.lock"
 do_fetch_common_source[network] = "${TASK_USE_SUDO}"
 do_fetch_common_source() {
     schroot_create_configs
-- 
2.44.2

Re: [PATCH] dpkg-source: lock isar-apt while do_fetch_common_source

[Jan Kiszka]

On 01.07.24 07:28, Uladzimir Bely wrote:
> Task do_fetch_common_source requires isar-apt repo unchanged while
> running "apt-get ... source ..." inside. Otherwise, it may fail on repo
> "Sources" or "Packages" file:
> 
> ```
> Err:4 file:/isar-apt isar/main Sources
>   Hash Sum mismatch
> ```
> This is quite often reproduced in CI since commit 2ca3a7e.
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  meta/classes/dpkg-source.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/dpkg-source.bbclass b/meta/classes/dpkg-source.bbclass
> index d6ab5aad..a70a392d 100644
> --- a/meta/classes/dpkg-source.bbclass
> +++ b/meta/classes/dpkg-source.bbclass
> @@ -41,6 +41,7 @@ do_dpkg_build[depends] += "${BPN}:do_deploy_source"
>  SCHROOT_MOUNTS = "${WORKDIR}:/work ${REPO_ISAR_DIR}/${DISTRO}:/isar-apt"
>  
>  do_fetch_common_source[depends] += "${SCHROOT_DEP} ${BPN}:do_deploy_source"
> +do_fetch_common_source[lockfiles] = "${REPO_ISAR_DIR}/isar.lock"
>  do_fetch_common_source[network] = "${TASK_USE_SUDO}"
>  do_fetch_common_source() {
>      schroot_create_configs

Too bad that reprepro does not support atomic updates - agreed, needed.

Jan

-- 
Siemens AG, Technology
Linux Expert Center

Re: [PATCH] dpkg-source: lock isar-apt while do_fetch_common_source

[Uladzimir Bely]

On Mon, 2024-07-01 at 08:28 +0300, Uladzimir Bely wrote:
> Task do_fetch_common_source requires isar-apt repo unchanged while
> running "apt-get ... source ..." inside. Otherwise, it may fail on
> repo
> "Sources" or "Packages" file:
> 
> ```
> Err:4 file:/isar-apt isar/main Sources
>   Hash Sum mismatch
> ```
> This is quite often reproduced in CI since commit 2ca3a7e.
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  meta/classes/dpkg-source.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/dpkg-source.bbclass b/meta/classes/dpkg-
> source.bbclass
> index d6ab5aad..a70a392d 100644
> --- a/meta/classes/dpkg-source.bbclass
> +++ b/meta/classes/dpkg-source.bbclass
> @@ -41,6 +41,7 @@ do_dpkg_build[depends] += "${BPN}:do_deploy_source"
>  SCHROOT_MOUNTS = "${WORKDIR}:/work ${REPO_ISAR_DIR}/${DISTRO}:/isar-
> apt"
>  
>  do_fetch_common_source[depends] += "${SCHROOT_DEP}
> ${BPN}:do_deploy_source"
> +do_fetch_common_source[lockfiles] = "${REPO_ISAR_DIR}/isar.lock"
>  do_fetch_common_source[network] = "${TASK_USE_SUDO}"
>  do_fetch_common_source() {
>      schroot_create_configs
> -- 
> 2.44.2
> 

Applied to next.

-- 
Best regards,
Uladzimir.

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/be27f8c1459b989685ad36a73d2aaa2801eed3c0.camel%40ilbers.de.