Re: [PATCH v2 15/17] multiconfig: Switch qemui386-stretch to using wic by default

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi,

On 2018-04-16 12:51, [ext] Henning Schild wrote:
> Am Mon, 16 Apr 2018 12:43:41 +0200
> schrieb "[ext] Henning Schild" <henning.schild@siemens.com>:
> 
>> Am Mon, 16 Apr 2018 12:35:54 +0200
>> schrieb Andreas Reichel <andreas.reichel.ext@siemens.com>:
>>
>>> On Fri, Apr 13, 2018 at 04:19:04PM +0200, Henning Schild wrote:
>>>> This time the non-EFI variant.
>>>>
>>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>>>> ---
>>>>   meta-isar/conf/multiconfig/qemui386-stretch.conf | 5 ++++-
>>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta-isar/conf/multiconfig/qemui386-stretch.conf
>>>> b/meta-isar/conf/multiconfig/qemui386-stretch.conf index
>>>> 0ba7c5b..8966c2b 100644 ---
>>>> a/meta-isar/conf/multiconfig/qemui386-stretch.conf +++
>>>> b/meta-isar/conf/multiconfig/qemui386-stretch.conf @@ -10,7 +10,10
>>>> @@ KERNEL_NAME ?= "686-pae"
>>>>   IMAGE_PREINSTALL += "init"
>>>>   
>>>> -ROOTFS_DEV ?= "sda"
>>>> +IMAGE_TYPE ?= "wic-img"
>>>> +WKS_FILE ?= "directdisk-isar"
>>>> +
>>>> +ROOTFS_DEV ?= "sda2"
>>>
>>> Note:
>>> Generally, I suggest we don't hardcode device names but use UUIDs
>>> and PARTUUIDs. We already have that problem on multiple platforms.
> 
> I wanted to not grow this series even more. But i think it would be a
> good idea to introduce a patch to not touch fstab in the configscripts.

Yes I agree. As I said in the other discussion about the IMAGE_FEATURES 
to Baurzhan, in my opinion the fstab should be rather done in a setup 
package. Inclusion of this package is then controlled over the image recipe.

Claudius


-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de