From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6543937367387930624 X-Received: by 10.46.135.129 with SMTP id n1mr417608lji.22.1523876194068; Mon, 16 Apr 2018 03:56:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.158.196 with SMTP id h4ls1345295ljk.7.gmail; Mon, 16 Apr 2018 03:56:33 -0700 (PDT) X-Google-Smtp-Source: AIpwx48TNAadCaLQm/yf0bW7MF7gGPAjpyPUi2yTdk3EhdCowTd4kHtvWjI9SPVQJHkq9ObuS3/L X-Received: by 10.46.80.11 with SMTP id e11mr400514ljb.3.1523876193591; Mon, 16 Apr 2018 03:56:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523876193; cv=none; d=google.com; s=arc-20160816; b=AlpUDHqM8Aoyxj61RlYvh8SZcpIQUu4L62QPlRk4oVsMR9aarJgkPzBw7x0JAZskgp 0V0LJH6ne1PykipKeoQh6mqdDrVnByOVHyWX1bY9lEus8uoEHPFL/QXwFp7Gt/RyaS5/ PHcAFUXqWOypBP0n4xyR/k7DaJb4Wf1oXh/2r107hksq56q3kzPVkBhs5V8C2wCTR+yG ASRPuxUKvl0SpSaXweuWIL4jfp+tGf7SNIrd0ScnDI/HN/dO4NoQcFsAmRtPVXizenvO JRKYTscLYJcLuLKjeGtUgos1xAwpzEWqxgh2h/4cEALRO3BpK5HWbDsIpLcf5/tb0XE1 5vYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=MSTR1mcXd2+AaZlgBH89Hd2JFfesh+eQ409ID4nWSgA=; b=gxUYrPWwjIEL9iMldPcjSO5TZWQEeaUUtsiLq8ypuy329mK/RxTRPIfaUpO5baI410 kONjtj74dPw5CuKKjaOMqr76vDCsSEwEmLvgrwb2ibdY8ANc+czR/1cVTC5+nFiQ9Pc6 l3bRpC/aitSa6W7NwJCTGetbpuxdN+OW6rJnVCfkaz9ybRvSCDHS4J3bxW1do6kvqePH vT83qpTqziN5rZ2rjOEc65oQD2ifYiWfwQQjsEuf1DfgTinuMkFRpUf0V+VrltqIgb5i G0o/eLmp9sOn8ZcFbgvrwL37nnnSd6RZU0wFokCZoU+qyxn/YrE9eP62b5LyO+NydQJH waUw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id t83-v6si385261lff.5.2018.04.16.03.56.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 03:56:33 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w3GAuWeo029520 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Apr 2018 12:56:32 +0200 Received: from [139.25.69.226] (linux-ses-ext02.ppmd.siemens.net [139.25.69.226]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w3GAuWqt012529; Mon, 16 Apr 2018 12:56:32 +0200 Subject: Re: [PATCH v2 15/17] multiconfig: Switch qemui386-stretch to using wic by default To: "[ext] Henning Schild" , Andreas Reichel Cc: isar-users@googlegroups.com, Cedric Hombourger References: <0ce33f720215e8838de9e0027f5394483cb68133.1523628814.git.henning.schild@siemens.com> <20180416103554.GC8866@iiotirae> <20180416124341.7fea5925@mmd1pvb1c.ad001.siemens.net> <20180416125140.0898289e@mmd1pvb1c.ad001.siemens.net> From: Claudius Heine Message-ID: Date: Mon, 16 Apr 2018 12:56:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180416125140.0898289e@mmd1pvb1c.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Lh3V2hyeHXlD Hi, On 2018-04-16 12:51, [ext] Henning Schild wrote: > Am Mon, 16 Apr 2018 12:43:41 +0200 > schrieb "[ext] Henning Schild" : > >> Am Mon, 16 Apr 2018 12:35:54 +0200 >> schrieb Andreas Reichel : >> >>> On Fri, Apr 13, 2018 at 04:19:04PM +0200, Henning Schild wrote: >>>> This time the non-EFI variant. >>>> >>>> Signed-off-by: Henning Schild >>>> --- >>>> meta-isar/conf/multiconfig/qemui386-stretch.conf | 5 ++++- >>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/meta-isar/conf/multiconfig/qemui386-stretch.conf >>>> b/meta-isar/conf/multiconfig/qemui386-stretch.conf index >>>> 0ba7c5b..8966c2b 100644 --- >>>> a/meta-isar/conf/multiconfig/qemui386-stretch.conf +++ >>>> b/meta-isar/conf/multiconfig/qemui386-stretch.conf @@ -10,7 +10,10 >>>> @@ KERNEL_NAME ?= "686-pae" >>>> IMAGE_PREINSTALL += "init" >>>> >>>> -ROOTFS_DEV ?= "sda" >>>> +IMAGE_TYPE ?= "wic-img" >>>> +WKS_FILE ?= "directdisk-isar" >>>> + >>>> +ROOTFS_DEV ?= "sda2" >>> >>> Note: >>> Generally, I suggest we don't hardcode device names but use UUIDs >>> and PARTUUIDs. We already have that problem on multiple platforms. > > I wanted to not grow this series even more. But i think it would be a > good idea to introduce a patch to not touch fstab in the configscripts. Yes I agree. As I said in the other discussion about the IMAGE_FEATURES to Baurzhan, in my opinion the fstab should be rather done in a setup package. Inclusion of this package is then controlled over the image recipe. Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de