From: Alexander Smirnov <asmirnov@ilbers.de>
To: isar-users@googlegroups.com
Subject: Re: [PATCH] meta: image: detect broken symlinks
Date: Sun, 4 Mar 2018 22:28:36 +0300 [thread overview]
Message-ID: <f617c0e2-d313-dd75-e527-adb210f9bb3a@ilbers.de> (raw)
In-Reply-To: <976515bd-b435-879f-9a57-84078d9c6149@ilbers.de>
On 03/02/2018 07:30 PM, Alexander Smirnov wrote:
> On 02/27/2018 08:23 PM, Henning Schild wrote:
>> Switch get_image_name from os.path.lexists to os.path.exists because the
>> latter detects broken symlinks correctly.
>>
>> Issue:
>> If you build a kernel without CONFIG_BLK_DEV_INITRD the postinst hook
>> will
>> still call "linux-update-symlinks" and create a broken symlink. After
>> that os.path.lexists will return True and "sudo cp" in do_copy_boot_files
>> will fail.
>>
>
> Applied, thanks.
>
> P.S.: fixed to upper case after semicolon in patch topic.
Dropped from the next branch. The patch breaks 'start_vm' script,
$INITRD_IMAGE variable is no more valid with it.
Alex
next prev parent reply other threads:[~2018-03-04 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 17:23 Henning Schild
2018-03-02 12:20 ` Jan Kiszka
2018-03-02 16:30 ` Alexander Smirnov
2018-03-04 19:28 ` Alexander Smirnov [this message]
2018-03-04 19:49 ` Jan Kiszka
2018-03-05 18:49 ` Henning Schild
2018-03-09 15:26 ` [PATCH v3] " Henning Schild
2018-03-20 13:42 ` Henning Schild
2018-03-27 13:50 ` Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f617c0e2-d313-dd75-e527-adb210f9bb3a@ilbers.de \
--to=asmirnov@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox