From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6527286083495919616 X-Received: by 10.223.129.200 with SMTP id 66mr1058176wra.17.1520191725529; Sun, 04 Mar 2018 11:28:45 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.47.77 with SMTP id v74ls1136287wmv.7.canary-gmail; Sun, 04 Mar 2018 11:28:44 -0800 (PST) X-Google-Smtp-Source: AG47ELtNA+6pNc0Lx7Yel5xZEU7KxmfYQUJhZoqwGoelONX9F9u2+j1q6GPt0K/tHi9xw/C/jFom X-Received: by 10.28.7.73 with SMTP id 70mr848415wmh.7.1520191724912; Sun, 04 Mar 2018 11:28:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520191724; cv=none; d=google.com; s=arc-20160816; b=RINVht5byhJjcAbyDUjLq0zle6TwTK27GQGnoULR/sHNRVm+rqKUsrp8N8exdgeLN9 lhy8uPfmsM1S6scoenpHW1p04xBkYPZCBhBXFC6TivuAvE0aiDC1ef25wQBTjrym0rjN mHuzZetSI9pwLSaYIaxegKp0lg69lrQGnz7AjWDwUDmDqG8YHd82GvQdeNVIzgwQY4/x uemEOhH+jaece7yGlJK+X9tB3AjLckbcD1P322Wz1e55KrFeeQZ/ela8+it2NKJWcNG7 5TH/EnDc2BGPap583Zm9QY2MlNPElsmCsH7raY69shs8iYxI5/G5GznNDZwbx3Azm5qB /UnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=VoZjMQNvpIDhAV3wXQreilzuP316enoxCV4JhS9WivU=; b=sT916XgJbwTCpXVxqXfNmoHhsN9siAch/ur7Gxkxvo1PhnBIBuiXc5yq4HjjHJasnt zkqWZIaQ432UCep5CUct1duEx7KGkOU/WGGEKvKTtsKoXZGeFXuuFAlLCjoD5tgSAD9Y jmXERM7JVhXOoCaLrFj2/v7cWU5YjAVI1JsxNXbbvPApQP7NpM+c6guC51lYXYgWDMHC 3ps5KEs5CmsVVjbwhzJwJPou2dqXOHqoeEksbLLLJbh/CxWJXK2xFuxSHr6XrP6jiyfs H6o7TamDqZlc/U2iviSuoDptfXx6uF9Y7iYzoVxBLkTZ0r/SsoO02DNpTGPV2tx5S8nB esew== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id a138si193252wmd.0.2018.03.04.11.28.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Mar 2018 11:28:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w24JSfHR031559 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sun, 4 Mar 2018 20:28:43 +0100 Subject: Re: [PATCH] meta: image: detect broken symlinks To: isar-users@googlegroups.com References: <20180227172336.19786-1-henning.schild@siemens.com> <976515bd-b435-879f-9a57-84078d9c6149@ilbers.de> From: Alexander Smirnov Message-ID: Date: Sun, 4 Mar 2018 22:28:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <976515bd-b435-879f-9a57-84078d9c6149@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: W/LLdF+YiI07 On 03/02/2018 07:30 PM, Alexander Smirnov wrote: > On 02/27/2018 08:23 PM, Henning Schild wrote: >> Switch get_image_name from os.path.lexists to os.path.exists because the >> latter detects broken symlinks correctly. >> >> Issue: >> If you build a kernel without CONFIG_BLK_DEV_INITRD the postinst hook >> will >> still call "linux-update-symlinks" and create a broken symlink. After >> that os.path.lexists will return True and "sudo cp" in do_copy_boot_files >> will fail. >> > > Applied, thanks. > > P.S.: fixed to upper case after semicolon in patch topic. Dropped from the next branch. The patch breaks 'start_vm' script, $INITRD_IMAGE variable is no more valid with it. Alex