Re: [PATCH v6 1/9] isar-bootstrap-host: disable DISTRO_BOOTSTRAP_KEYS usage

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

On 5/22/19 8:37 AM, Claudius Heine wrote:
> Hi Jan,
> 
> On 21/05/2019 18.56, Jan Kiszka wrote:
>> On 15.05.19 12:11, [ext] claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> isar-bootstrap-host only supports bootstrapping Debian root file
>>> systems. Therefore deactivate any DISTRO_BOOTSTRAP_KEYS from other
>>> distributions.
>>
>> Actually not totally true, as I just realized: What about 
>> bootstrapping the buildchroot from a custom debian repo that was 
>> differently signed (e.g. because it is a condensed version of 
>> upstream)? Seems we do need HOST_DISTRO_BOOTSTRAP_KEYS, right?
> 
> You are right, I haven't considered that case. Well, the next task on 
> the todo list should probably be to refactor and streamline the 
> isar-bootstrap, and especially the host bootstrap process and fix those 
> kind of issues while doing that.
> 
> There are a lot of possible customization options gained if the current 
> giant bootstrap function would be split up, similar to how the rootfs 
> system works in the pre-processing patchset.
> 
> Maybe it makes sense to also start renaming "host" and "target" to be 
> compatible with the gcc nomenclature [1] in that patchset. I am a bit 
> reluctant to do so, because of the breakage involved. But the further we 
> wait, to more stuff will break downstream.
> 
> The plan would be to rename all occurrences of "host" to "build" and 
> "target" to "host". That would lead to the following recipe changes:


> "buildchroot-host" -> "buildchroot-build"
> "buildchroot-target" -> "buildchroot-host"
> "isar-bootstrap-host" -> "isar-bootstrap-build"
> "isar-bootstrap-target" -> "isar-bootstrap-host"


> I am on the fence of that change. Correctness vs. no-breakage
> 
> Any comments about that?

I would prefer to avoid such a renaming taking into account needed 
efforts and possible confusion for current Isar users.

Regards,
Maixm.

> Cheers,
> Claudius
> 
> [1] https://gcc.gnu.org/onlinedocs/gccint/Configure-Terms.html
> 
>>
>> Jan
>>
>>>
>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>> [Maxim: rebased]
>>> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
>>> ---
>>>   meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb 
>>> b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> index 7ee4c61..5501e35 100644
>>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
>>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = 
>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
>>>   ISAR_BOOTSTRAP_LOCK = 
>>> "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
>>>   require isar-bootstrap.inc
>>> +# We only build debian host buildchroot environments
>>> +DISTRO_BOOTSTRAP_KEYS = ""
>>>   inherit isar-bootstrap-helper
>>>   do_generate_keyrings[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
>>>
>>
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov