From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7352162563113615360 X-Received: by 2002:a05:600c:154b:b0:414:cd1:e46d with SMTP id f11-20020a05600c154b00b004140cd1e46dmr6796820wmg.23.1711977429101; Mon, 01 Apr 2024 06:17:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:1c8a:b0:415:644f:d95e with SMTP id k10-20020a05600c1c8a00b00415644fd95els420634wms.1.-pod-prod-03-eu; Mon, 01 Apr 2024 06:17:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEg7hSUQEz78Fy1fdpXEGLfQIsUmfkBINzvDKsRdBzDNyA3YhO2UVofGoq2t9aKxaTRzsbs X-Received: by 2002:a05:600c:3b02:b0:414:860:bdc9 with SMTP id m2-20020a05600c3b0200b004140860bdc9mr6116665wms.33.1711977426660; Mon, 01 Apr 2024 06:17:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711977426; cv=none; d=google.com; s=arc-20160816; b=nvbTUv1yL9iktgA/FUL4ywxT9tfeIjmQCqRi/ZC+nI287Qhg83bZlGLPFdHJkw4uJL nA0Gtixnbv/r6lxYLf/jbiGS0AOXvpXzu2QjxQSNvbnvd391vx/+s0x/R4ygMems0ub8 M5m2CFw8nY2IbwVObO7ZF4QH52mNXrzEsmTdyrUe+8mX8ikh2E7O3yD+UKj1SQRtqJ12 Ko70cEU1kp3RCaBx7F/jG+JxFwCVRMyP39pWNiDY718CA5BeppIsXsCkE026PBoDV6kP R2ZoJNZkc6dD57SwGl2zWsFI6YxqtcT0jMXTgWAHbutX1SU7W6wSeHjlzEixZkdOvA78 iCWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:autocrypt:cc :content-language:subject:to:from:user-agent:mime-version:date :message-id:dkim-signature; bh=j05NArWMhUyGvGw9M0PC5qXIijX9PGxMa2pKE1k64yQ=; fh=tuUs/EekgcJ78itlzYw1SUa7Ysgio1Tae7tVJ0Mwzu4=; b=0AideKRdMWfIhkM/gkLfTOi5K473yQph+9ewESVqVSaslxCrMwvSUVIYjgFmTWX89Q jX7w+KKc2xah121P9UutRU82dMof2WT3eGv0cqsna3BYeajUBGPno5AlcBMNZCzQvYAp tGMUI1p8h5W+BOshNoRFQf93DbOG6qCvdHtzQrge10P4rJc28o0iXw/9qbmCSsHxZC3B JHGPnwqqw2YsZi00yJp3hkRUDv5hUfB7SJ8zj9Iws4x/EalspchaQv6Em7MXu3siAFxv C1Iswf+WpVnz9YAwF8JmHIMQWhOx5j2JoOo90o8aKVvCPOC6KshK0GHdj2Lvrvb0u2FQ A0TA==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=nez0UptB; spf=pass (google.com: domain of jan.kiszka@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=jan.kiszka@web.de; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from mout.web.de (mout.web.de. [217.72.192.78]) by gmr-mx.google.com with ESMTPS id fm26-20020a05600c0c1a00b004156a6790c7si102460wmb.1.2024.04.01.06.17.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 06:17:06 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 217.72.192.78 as permitted sender) client-ip=217.72.192.78; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=nez0UptB; spf=pass (google.com: domain of jan.kiszka@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=jan.kiszka@web.de; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1711977426; x=1712582226; i=jan.kiszka@web.de; bh=j05NArWMhUyGvGw9M0PC5qXIijX9PGxMa2pKE1k64yQ=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc; b=nez0UptBDXJ8qX5lal+neiPsoBigZfh3t4zplHXmqeZHQGQNIv5Z2xxO2BLbGiVA P+umsWvuMQ2eleaXXZXcysuoQvDRB2B4xvmt4GyIyMU4bB3uRuwRMp6ZaIyaYh7td cAXSOqvpekJCnMp0DAuEwZdJbJEkFdSiWvEPUi7q7xF3qY3eatXRhYXcKdu+Jw587 cX0yOpZbcl0WDpi7K06yEMkEDNwI6tfygIlvUocjG+rMGHtcWggjRXPQOA8Ol9i9G hsh2RoAyrkBDtyDhpeuGPwqzRGdoEfmEtu00iJUGyfj7+NuONN1MUdifCjFeQnlQS G75bmbQMhEXsEKxwrg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.31] ([88.70.124.107]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N9cHX-1swXDD0acn-015Iye; Mon, 01 Apr 2024 15:17:06 +0200 Message-ID: Date: Mon, 1 Apr 2024 15:17:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jan Kiszka To: isar-users Subject: [PATCH v2] multiarch: Fix PN-to-BPN massaging Content-Language: en-US Cc: Uladzimir Bely , "Schmidt, Adriaan" Autocrypt: addr=jan.kiszka@web.de; keydata= xsDhBEq0i8QRBAD2wOxlC9m/8t/vqjm1U9yQCT6OJ2Wbv/qys9DYM0CvcOTDMWQwmV1/VsZj KR5YgB5NPt+To7X6x5cjz15AGnx5Fb8Wnrq8EF9ZfHMwb7YMx1LdPYPDnXr37wE3XupFmkHB Mes4htyX7Dz8LvKDLnli4IsAmWG+kV1JI6LWKXLpSwCg8JRq4SWoB4VCQxbH3GjntgvwNc8D /2q5Dj0urJ7s7sdXhrH0hcFkpSFRmU5Yd6MCwcbFHm2paL5gqVjNNUUwDBKAL9eZaQVIHKwC 44BvNGO2gcQ26R3AuCHUQ+pZHg34tok1JCNZ6IEZccb+33Qq0qbcDMJJiDYp7ppp6ozifvc4 YaqJECX48IydxfE9+41oV7T5vNAzA/QL/UMJyTnu5jiOXcyn5iFQw535lXkwKsqeXzCowLho HICZ2jITJPdTT/+9pGWwMQqST/SS35Tx4EnS3z2BWsNMCLuXCPkxF1elaMJqMfMJxFD8rAgS 9GK6zP6fJlsA1wq/UvKSL8v4QPOnTNCVOsyqJVasGV0ZPcDfcj+ClNO4zR5KYW4gS2lzemth IDxqYW4ua2lzemthQHdlYi5kZT7CYAQTEQIAIAUCSrSLxAIbIwYLCQgHAwIEFQIIAwQWAgMB Ah4BAheAAAoJEIrUrG965ecUhIMAnR6DDCW5cx+cVdYhydbhQXqeief6AJ4p+z4+nrmZLdfU 7V6nKqKeHeTtj87BTQRKtIvEEAgA2/PlX6oyi7dToH0CJCHq0eKmZaa7CmGaVnxyeepKvIfi M8n8Td76AbG64fjREMwgSpb4F/UytF3z/03tj4e49W/zKjbBRB2/wmFRlZBC9crg22Q+bgvM OsxnC6uHXaWN8fL+jVei/5OoHOoFqaMsX8EvploitlI/BPj+VgW26jksf3YZyk1hnclsZ/IY hXzgRmVJo4RiTW/YLQAkwndwc+fKPa/IYLEDW1Jc4kNLoK0P90b45zju0hpl0C00pVORTOtz FK9G5Ha7qOAWJfAVJORHKAkkvwftf3hkpPdLyvZUWRHXvUexmA61fLvDBAFhRxYGD8t5gz88 SF5Tzq+0ywADBQf/YSkaYrEslPWiCA2wU6EW0yaqBQAobFsOMvsufJ6o2ntq5Ncq37VI3KCT 67eHPE9x+zPcENoZWsRrC9S9PCf1LOsi7ybZsR13AJqDFlRzJZ4klh9QwgwFZxUBzOdIvttw zG1QkzHx06RKZluFYpPF3DRduSMukdIJ2wmWCU+ohB+mYefe65JGjYQfHVs8mgYVFOPxbRea 9VJACCMuspoZWpj43UdR1lLLyIUFYz+jqcPW7Hd/GTIw4N67pYl0dwPDmFd4ohJ5g4Zpq61t oNysBGEuEm5GCcn0VmGtQpSYnR5cVm5b2yPz4bIuFOSuZUo/l7vitdY0iy0/wvKbBC+NK8JJ BBgRAgAJBQJKtIvEAhsMAAoJEIrUrG965ecULvAAoKGvxs5T3IhyQT8I8sMsyAvCE4wHAJ46 S16yab+OxNkvOeoOEX0EnHVHaA== Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ihEv5cKp40gHeRLeox/ygv5tBAKJKCQmYyC2O48oCYRmmdfUh+t co8V7JKhKePEXn+qfxmSayKm72nf0WBFSN33UuWkGeNoKGdsdVjQOd4WmbqhEWMi0macPzU 2CAlOmBoquBJty5YJiq7mJyoBcmow/N7b9T9sc3gRX9Uczq1/SXCcxActnq3Dc6DadSiCaT caa7MfJ2g4yuhDEyxBgYw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:VWbj7mVHBW8=;jgZpGwqT0UElX1lqNY+c0rwVZXl JzPZi1ODWceaDhjikktKvNmneDOlOqoOI7fkMoaWDfWtLpTuOXRYg7poHhQfk5wU67YblOa0T pN4DKwfLllo7alMtTVb44EGWyNiQTRsL9RnXL1y27PaOZr+FiZdkk82FTLBc7f5g6VN4tky1J QTTWs1iBJdjaZ5yvtUPppbS5mSQlxZqyvuZoDqrb8WgeVgceWDzALotB08bssj1SA8mixJ8CH nHWPfLPIXbuk5k/bga0VotJGVQSf6deJvfBK7/ygi2ZqDsUFsPQnEHFETqBb9xytDrPg1EH+j 2yLw07ukDErZvzGygWi8N7MK90526a35yjNn3dsPXw2PboXsgLr03IRkaPO3rlALFXjvOppm+ tue6E3Kqq6U/neJpVks/B2auksdOy8DSdiXXpJxOyOl2k+54GsfTeiBOu3X6KW6/7LS/QfgMB sRrwwbmJdyjl1LwwVQm6dRGs2XCWNsLpHmFBpCW1LMVxRixYsnbDjoSdHRjdj3cV5zxqpIa6a xEm+BQYGvzd9FOw3fhcNZA8NJk7W7wekhQJmIQgHIh0P+nZ9dp8Qpw5zJJtYNNUB+Rzz/p+eu 3isZo5uNUknL0bs4Dwi3aWxk2okv9HdI8Ri/r2HrxaMYuBnejCr4CUTm8npRvQlcQJiHRkDnc f8d1lKJzDw1kLRn61SFKb/lZCxr9rv4AgtEgEq1Xe/sEbiq9KtqSHkV/prvY8EHRpOZkISYKb sVwpsjUegF7VggkhxlloAv2/YN0XCj+Y1iBnVlrlDy/oqD7JRW8RHdZIg5bgBRZDAE4okudl+ uYetLK6czSmbBJkocGJ6rc7MHAS0Yud9saVQXnFZHtoxM= X-TUID: 9cy6x0qOBqjH From: Jan Kiszka SRC_URI and FILESPATH are differently built, thus can't be handled the same way when trying to translate PN to BPN. While entries in the former are space-separated, they are colon-separated in the latter. Furthermore, the existing logic didn't properly split the entries, rather processed the complete string. That was surely not desired as well. Account for all by handling the variables separately and by splitting them first. This fixes warnings like WARNING: /build/../repo/meta-isar/recipes-core/images/isar-image-installer= .bb: Unable to get checksum for isar-image-installer-native SRC_URI entry = debian-configscript.sh: file could not be found Signed-off-by: Jan Kiszka =2D-- Changes since v2: - picked final patch from local queue, fixing SRC_URI regression meta/classes/multiarch.bbclass | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/meta/classes/multiarch.bbclass b/meta/classes/multiarch.bbcla= ss index 5783b0bf..5c97453b 100644 =2D-- a/meta/classes/multiarch.bbclass +++ b/meta/classes/multiarch.bbclass @@ -46,12 +46,16 @@ python multiarch_virtclass_handler() { # parse time, and parsing always happens for all build variants. So i= n those # few variables, we automatically replace ${PN} with ${BPN}. def fixup_pn_in_vars(d): - vars =3D 'SRC_URI FILESPATH'.split() - for var in vars: - v =3D d.getVar(var, expand=3DFalse) - if v is not None and '${PN}' in v: - d.setVar(var + ':remove', v) - d.appendVar(var, ' ' + v.replace('${PN}', '${BPN}')) + v =3D d.getVar('SRC_URI', expand=3DFalse) or '' + for uri in v.split(): + if '${PN}' in uri: + d.setVar('SRC_URI' + ':remove', uri) + d.appendVar('SRC_URI', ' ' + uri.replace('${PN}', '${BPN}= ')) + + v =3D d.getVar('FILESPATH', expand=3DFalse) or '' + for path in v.split(':'): + if '${PN}' in path: + d.appendVar('FILESPATH', ':' + path.replace('${PN}', '${B= PN}')) # When building compat/native, the corresponding suffix needs to be # propagated to all bitbake dependency definitions. =2D- 2.35.3