Re: [PATCH v2 1/5] testsuite: Dockerfile for docker-isar image

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

On Wed, 2023-03-22 at 13:29 +0100, Uladzimir Bely wrote:
> Add dockerfile for generating docker-isar image supposed to be used
> in docker-based CI systems.
> 
> This image better fits testing when compared with 'kas-isar' one:
>  - Avocado test framework preinstalled.
>  - Qemu-system packages for running execution testcases preinstalled.
>  - Direct avocado execution (without ci_build.sh) when necessary
> (e.g.,
> for manual testing).
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  testsuite/dockerdata/.dockerignore |  2 ++
>  testsuite/dockerdata/Dockerfile    | 18 ++++++++++++++++++
>  2 files changed, 20 insertions(+)
>  create mode 100644 testsuite/dockerdata/.dockerignore
>  create mode 100644 testsuite/dockerdata/Dockerfile
> 
> diff --git a/testsuite/dockerdata/.dockerignore
> b/testsuite/dockerdata/.dockerignore
> new file mode 100644
> index 00000000..6e19512a
> --- /dev/null
> +++ b/testsuite/dockerdata/.dockerignore
> @@ -0,0 +1,2 @@
> +.dockerignore
> +Dockerfile
> diff --git a/testsuite/dockerdata/Dockerfile
> b/testsuite/dockerdata/Dockerfile
> new file mode 100644
> index 00000000..87ae2f20
> --- /dev/null
> +++ b/testsuite/dockerdata/Dockerfile
> @@ -0,0 +1,18 @@
> +FROM ghcr.io/siemens/kas/kas-isar:latest

I would recommend to use a fixed version / tag here.
Floating references are problematic as local rebuilds of the image
might use different versions of the base image.

Felix

> +
> +ARG TARGETPLATFORM
> +ARG DEBIAN_FRONTEND=noninteractive
> +
> +USER root
> +
> +# Isar testsuite dependencies
> +RUN pip3 --proxy=$https_proxy install avocado-framework==100.1 && \
> +    rm -rf $(pip3 cache dir) && \
> +    apt-get update && \
> +    apt-get install -y -f --no-install-recommends \
> +        qemu-system ovmf
> +
> +RUN apt-get clean && \
> +    rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* 

Please do this in the previous RUN invocation as otherwise the data is
added to the first layer. By that, no space is saved.

Felix

> +
> +USER builder
> -- 
> 2.20.1
>