From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6521574339082452992 X-Received: by 10.223.198.82 with SMTP id u18mr47950wrg.17.1518630217794; Wed, 14 Feb 2018 09:43:37 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.223.139 with SMTP id w133ls2268412wmg.2.canary-gmail; Wed, 14 Feb 2018 09:43:37 -0800 (PST) X-Google-Smtp-Source: AH8x225+yTRZZIlc7RY9LIe3g8p70gk4bX4GgZcsp8hRMoPWbMirmQgEg4DDapPvFNiHdAJuUBpw X-Received: by 10.28.160.20 with SMTP id j20mr672420wme.29.1518630217224; Wed, 14 Feb 2018 09:43:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518630217; cv=none; d=google.com; s=arc-20160816; b=AB2Etxbe2iY5G2eWoxbUqaL0lH/ARvojWe377lGoPH3h25FGbhcvcZROlRAviykbOI uIM5SsRUu3PbNdBBjZc+AU4+C7HMTcDEXpYrpjBpypjtwlhWCLp9eSVBItgwmh3YNIK+ oaN9QU9TlfcXyJ8pZjwqYy8nF0xknSIjLLlErp7e+fMJbo23kbPqsTBPlD94O51cxRB4 zafqT+RyMb/1SuVaJ57IjYvl8NjW9j5am//RVViyXWlcqymJ81Bye0Kg6WOxT3pL2M0H xTU2UT4+NT3VakDeLS9XCjCI+5+n/GcQvLEMTLwndizGeNjv6qh5VjnpWyN5y1uFF0O7 75uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=ULmXs8lxYllrAsV7Bqu/mIil4tnFUnAvmD4jMgNkRV8=; b=RO+Ml6trOzOeX8CiXFkQLVJzlSQZxUEC6hkAZjcUZPZ76xQ3V71G29AE2zEsPd7U60 v0Yoq/r98RW/SycO6BbRnpfA5FCY6Qm5JhTVFRvrgQnkt8fgr0y927AIaHSHiRclRQnX NRWuQNEyZu7oI1RyvJng5BuBR1KzpyBNXP7D+wPS/1DhO8wVpPovzN3yVMf03qDc6WZF 25P4+QlfGQzLc4NY1p4s1hSeRZzslab/VjxJF4ZXqafeh0p6v1btMBvYbSMulJF5TBXv KNHwAc+JnaRmAqF6HqZR3MsmJAYIzuwrSundU12Yy81dU5Ngtj0s5eowvD5w1E4ohkjH PMeg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id s81si681577wmd.2.2018.02.14.09.43.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2018 09:43:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w1EHhYmn010923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 14 Feb 2018 18:43:35 +0100 Subject: Re: [PATCH v2 9/9] buildchroot: Clean up rootfs prior to populating it To: Jan Kiszka , isar-users References: <39652c875fcdedaecd165b271483aa68c452c2e9.1518552327.git.jan.kiszka@siemens.com> From: Alexander Smirnov Message-ID: Date: Wed, 14 Feb 2018 20:43:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <39652c875fcdedaecd165b271483aa68c452c2e9.1518552327.git.jan.kiszka@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: OS2tZkRqfLgw On 02/13/2018 11:05 PM, Jan Kiszka wrote: > From: Jan Kiszka > > This ensures we are always re-building a clean image. > > Signed-off-by: Jan Kiszka > --- > meta/recipes-devtools/buildchroot/buildchroot.bb | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb > index cd91228..62979f5 100644 > --- a/meta/recipes-devtools/buildchroot/buildchroot.bb > +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb > @@ -31,15 +31,17 @@ BUILDCHROOT_PREINSTALL ?= "gcc \ > WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" > > do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > -do_build[dirs] = "${BUILDCHROOT_DIR}/isar-apt \ > - ${BUILDCHROOT_DIR}/dev \ > - ${BUILDCHROOT_DIR}/proc \ > - ${BUILDCHROOT_DIR}/sys" > do_build[depends] = "isar-apt:do_cache_config" > > do_build() { > E="${@ bb.utils.export_proxies(d)}" > Do you have any concerns if I duplicate commit comment here? Otherwise I expect in near future patch which moves this to [dirs]. Already had several cycles of doing this in `git log` :-) > + sudo rm -rf ${BUILDCHROOT_DIR} > + mkdir -p ${BUILDCHROOT_DIR}/isar-apt > + mkdir -p ${BUILDCHROOT_DIR}/dev > + mkdir -p ${BUILDCHROOT_DIR}/proc > + mkdir -p ${BUILDCHROOT_DIR}/sys > + > chmod +x "${WORKDIR}/setup.sh" > chmod +x "${WORKDIR}/configscript.sh" > > Alex