From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6517147827419742208 X-Received: by 10.46.71.206 with SMTP id u197mr761142lja.16.1518457724465; Mon, 12 Feb 2018 09:48:44 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.47.9 with SMTP id v9ls324924ljv.1.gmail; Mon, 12 Feb 2018 09:48:43 -0800 (PST) X-Google-Smtp-Source: AH8x225phKRz6EzN5fI9I+CUH5tzpeKWTQX4sFeB4FI8vvG1orkmlPAi5GSDCuneZbt2RArvV/UP X-Received: by 10.46.89.91 with SMTP id n88mr296900ljb.35.1518457723704; Mon, 12 Feb 2018 09:48:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518457723; cv=none; d=google.com; s=arc-20160816; b=TUeXLFN1raxyYdrzgzM4ON1lZYLGL4i0ZV4sG0w43lGIFutuObSbke1jGg7fsiQZzL G5c/VC6REi1bustIr9AmZaLTJgM9Wzu0+APq7FJSgUZr+PvCmNTjQfk0Lbjmyub/xT1K VF1qsjpzxkGOyAbFe76KL3fE1ODD/v1DrrxkQpUgwAd8KSwI+R94zPuWiEHipPA3dxV4 vj94FU3q55v+FSEr3XCaPO189dnyQC+vd+eiPOjralIY/WwL40lln2hGMTGFBnsJB+eI fX4rdtPBF+0DrmMhj0zKdaL7U5vb6aQjk9QgwILyyU8qym+U6UCMwIAJhZkMXB4UxLyH SWzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=CaLOsHxZxPWUBtkUH3d4+UhtSBMUV0+v9x7h1//shg0=; b=tDEUfUnQ0sKVh0QVNcGI/Zat5S1E1X1Y2YTaiprOOr94NoiZ4hJImVL7+6ekNfdNJT jVTSgUt3QtGb9Rhw1vqvNCkLOdQmBowIsK/RsJ47GUswRp6/SUNfersjwGeJzSvu/5lu wDwW81LJHdeV/T4BgmE3Ofo4sTPT/yPIGpYCGc2k3j0cK1zcN7hR7QN0Gg5Pd4i0kt6G LFgRx4jfJRAvA1Nnr8LdqdsSLVsOsTt7dtS3xXSd1rKXtwvne78snHEw2jZMqJAoQFNd OIJOsCG7eRO2gxyXYEBl4OtGiYQBwtWBJ8GkELKCn98zolSV5k8vFnB5u/Qg+gPqt2jK KgMQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id z11si527017lff.1.2018.02.12.09.48.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 09:48:43 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w1CHmgaP008390 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 12 Feb 2018 18:48:42 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w1CHmgZ1000693; Mon, 12 Feb 2018 18:48:42 +0100 Subject: Re: [PATCH 3/9] wic: add a bootimg-efi-isar plugin outside the wic tree To: "[ext] Henning Schild" , isar-users@googlegroups.com References: <5813b0e31a65669b6e27294b70050e3e70626b57.1517390790.git.henning.schild@siemens.com> From: Jan Kiszka Message-ID: Date: Mon, 12 Feb 2018 18:48:41 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <5813b0e31a65669b6e27294b70050e3e70626b57.1517390790.git.henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Jv+GaCI56aR3 On 2018-01-31 10:41, [ext] Henning Schild wrote: > The added plugin is a copy of the modified version in our wic. Move it > out and rename it so we can get back to a clean wic. > > Issues: > - wic in Isar has been messed with > > Impact: > This patch prepares for the Issue beeing solved, because now the plugin > is outside the wic-tree. Nothing changes for users. > > Signed-off-by: Henning Schild > --- > .../scripts/lib/wic/canned-wks/sdimage-efi.wks | 2 +- > .../lib/wic/plugins/source/bootimg-efi-isar.py | 307 +++++++++++++++++++++ > 2 files changed, 308 insertions(+), 1 deletion(-) > create mode 100644 meta-isar/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > > diff --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks > index 1171a26..580ad21 100644 > --- a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks > +++ b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks > @@ -2,7 +2,7 @@ > # long-description: Creates a partitioned EFI disk image without any swap that > # the user can directly dd to boot media. > > -part /boot --source bootimg-efi --sourceparams="loader=grub-efi" --ondisk sda --label msdos --active --align 1024 > +part /boot --source bootimg-efi-isar --sourceparams="loader=grub-efi" --ondisk sda --label msdos --active --align 1024 > > part / --source rootfs --ondisk sda --fstype=ext4 --label platform --align 1024 --use-uuid > A downside of this renaming is that we need to adjust wks files that might be shared with OE setups. An alternative way of overloading the original plugin does not exist, does it? Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux