From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Mon, 13 Oct 2025 06:39:04 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-qk1-f188.google.com (mail-qk1-f188.google.com [209.85.222.188]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 59D4d3Zr031879 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 13 Oct 2025 06:39:03 +0200 Received: by mail-qk1-f188.google.com with SMTP id af79cd13be357-887c8b564ffsf669749885a.0 for ; Sun, 12 Oct 2025 21:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1760330337; x=1760935137; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:reply-to:x-original-sender :mime-version:subject:references:in-reply-to:message-id:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=2Rd/qaaj0lb4Xq1bWRNSk2f45yDdjGEXh/IIDST+G68=; b=AmiIah8cWFLoFjS7w6nWyUJcbxOfhOgGU8njEdlTZ1sMeMWeCesDmlyMlhOc6UZPga XRzSQIbWauBmsVepRt+pd/g4JOn2OFmc5wxPOy6C8xFkE6+5Wr5k51RAUAq9xOhtJP1Z sh+Zpmq3mxwoWLGG0J6sIlBFq5GnxsUC7GI1FRBQQu7TrTh85VRXnqtvaz34ncM0VTT/ gEzLKVVcbYvk6jHwpl8O9sr3h0b/GP3V51J4N8lP3xxVKw8bVy2L8cANBubuV1gnauiO c8qZDfjK+2MndYZUJvlttjSXYp43NI5fUpyXzJI+JMCras1NSBig1c4nm81YbqYUDsX3 Ov3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760330337; x=1760935137; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence:reply-to :x-original-sender:mime-version:subject:references:in-reply-to :message-id:to:from:date:x-beenthere:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Rd/qaaj0lb4Xq1bWRNSk2f45yDdjGEXh/IIDST+G68=; b=szzyhDdAdKx8Fdul1yaaRuW7TdgJJx6yNyhbp2A4helswK2wDRI4M1bbqQK4reeoFe lskFtjNuNdB1+3ExPM9pwDsbwp7cTDwsNnzfxU4NQPh8fszZO+33egY6qRRI+Wr94snh qARaMyibOt7GSAyQu19vhTkwxbQ7hsz9LXHEzLbNYU/bTkudsJ417gtO3WJfJjolPZPO qaFIoMRw492hiSeiam0dh08c82nlnQTKeJ0NOSBgQFuKJUq+xxdWPCzbO0JWxvDxk0b8 3dyuhBZvu//MPB5KPvWcJI6XkTZ0VM/Tm5X+74wcOjSE53z+RLRgnysNE9OA8Hd2dXoD er2w== X-Forwarded-Encrypted: i=1; AJvYcCUqFdRQvDWF1opW0zXoDNuTjHDcS0JlrPcD9q3bLuS07r91W0mgC0/hIxZuObNG/N/R5K4x@ilbers.de X-Gm-Message-State: AOJu0YwdMEoKRsQSk8MNIGzPoB0sFeZnSPbxDl+bC9QPXeXiNgCXofxb jDT0BSMTkXAMsHSpSTa3AJ0TWjBfkfWVxAKos5rdVkSIuuS/cEzbL6Y1 X-Google-Smtp-Source: AGHT+IFebRsb5nvxju0zV8aWcxKZ5hd2e7bmJoazljyjcLzLHYPm0Xk9mWo4HZE5tUm+miSJ9w8ZBg== X-Received: by 2002:ac8:4602:0:b0:4e6:e995:853e with SMTP id d75a77b69052e-4e6eafdb7d7mr179438501cf.16.1760330337112; Sun, 12 Oct 2025 21:38:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="ARHlJd4eFoF1nO3rqrYL5+0uc0yPTpMgifDovWNF9V7W29DKJg==" Received: by 2002:a05:622a:a6d5:b0:4cf:5206:ee51 with SMTP id d75a77b69052e-4e6f8966d5bls62362781cf.0.-pod-prod-07-us; Sun, 12 Oct 2025 21:38:55 -0700 (PDT) X-Received: by 2002:a05:620a:bc4:b0:815:87ab:37e0 with SMTP id af79cd13be357-883521db930mr2685036785a.53.1760330335778; Sun, 12 Oct 2025 21:38:55 -0700 (PDT) Date: Sun, 12 Oct 2025 21:38:54 -0700 (PDT) From: "'Badrikesh Prusty' via isar-users" To: isar-users Message-Id: In-Reply-To: <1c93851a-7b56-4088-bd19-83ed1b1d8ecc@ilbers.de> References: <20250403170701.807745-1-badrikesh.prusty@siemens.com> <3d694944eb24183d241bf652c43a60d7b73aec69.camel@ilbers.de> <95421431-bec5-4297-8aba-2bd9207f1785n@googlegroups.com> <3629bc6c-800e-4d4f-9ca6-ddd5bdcfa4d0@siemens.com> <1a2a38b0-49aa-4167-a95e-16f4c5ba385dn@googlegroups.com> <1c93851a-7b56-4088-bd19-83ed1b1d8ecc@ilbers.de> Subject: Re: [PATCH] image: copy DTB_FILES to DEPLOYDIR/IMAGE_FULLNAME/KERNEL_NAME/ MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_232730_670435788.1760330334397" X-Original-Sender: badrikesh.prusty%siemens.com@gtempaccount.com X-Original-From: Badrikesh Prusty Reply-To: Badrikesh Prusty Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_RP_CERTIFIED, RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: /tcWkPQFlPXq ------=_Part_232730_670435788.1760330334397 Content-Type: multipart/alternative; boundary="----=_Part_232731_985508011.1760330334397" ------=_Part_232731_985508011.1760330334397 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Anton, Thanks for the fixes. The patch looks good, provides a complete solution,= =20 and addresses all issues without requiring any additional changes=20 downstream layers. I tested the patch with various images that use=20 DTB_FILES, and it worked fine with all builds. Regards, Badrikesh On Wednesday, October 8, 2025 at 3:15:56=E2=80=AFPM UTC+5:30 Anton Mikanovi= ch wrote: > 08/10/2025 09:20, 'Badrikesh Prusty' via isar-users wrote: > > Hello all, > > > > Apologies for the delayed response. I somehow missed the message. > > > > > This sounds familiar, and I think we discussed that multiple times > > > already. Did you study previous threads/patches, e.g. > > > https://patchwork.isar-build.org/project/isar/list/?series=3D1241? > > > > > > Yes, there were few patches that tried to solve the issue. > > > > > > Using subdirectory (variant similar to TS's) > > > - https://patchwork.isar-build.org/project/isar/list/?series=3D1149 > > > Allows to overlap files > > > - https://patchwork.isar-build.org/project/isar/list/?series=3D1235 > > > Make kernel deploy the files, instead of image recipes > > > - https://patchwork.isar-build.org/project/isar/list/?series=3D1241 > > > > > > > I reviewed the previously shared patch, but not in full =E2=80=94 thank= s for=20 > > sharing it here. > > > > The patch I sent is very similar to @nicusor=20 > > patch: https://patchwork.isar-build.org/project/isar/list/?series=3D114= 9 > > > > I just reviewed the other patches and believe that many may encounter= =20 > > the same issue. For instance, when attempting to build multiple=20 > > kernels for a single image=E2=80=94such as `linux-image-amd64` and=20 > > `linux-image-amd64-rt` kernels=E2=80=94this overwrite problem is likely= to occur. > > > > This patch also resolves the issue with image builds that include=20 > > multiple kernels by storing the DTB files in the directory=20 > > DEPLOYDIR/IMAGE_FULLNAME/KERNEL_NAME. This will also fix issues when=20 > > building with different DISTROs as IMAGE_FULLNAME includes target=20 > > DISTRO. Additionally, it fixes problems that arise when building with= =20 > > different DISTROs, since IMAGE_FULLNAME includes the target DISTRO. > > > > > This would affect downstream as well. You are missing a > > > RECIPE-API-CHANGELOG.md entry. > > > > > > > Yes, it will affect downstream layers. E.g. I checked with the=20 > > isar-cip-core repo, changes will be required in `efibootguard-boot`=20 > > wic plugin. I will work on fixing it, once this is approved. > > > > Thanks and Regards, > > Badrikesh > Hello Badrikesh, > > Files like scripts/lib/wic/plugins/source/bootimg-efi.py are borrowed=20 > from the > upstream and supposed to have as minimal changes as possible. Even having > changes in custom WIC plugins can results in additional side-effects. > > Also, in general, DTBs should be part of a kernel, but not an image. > I've just released the new version of DTB deployment fix proposal which= =20 > I hope > will cover all the cases. Please have a look: > > > https://patchwork.isar-build.org/project/isar/cover/20251008085507....@il= bers.de/=20 > > > > There are also some observations regarding other implementations of the= =20 > same > fix were shared on the list previously: > > > https://patchwork.isar-build.org/project/isar/patch/20240416100746.568...= @mentor.com/=20 > > > - We don't want to modify WIC plugins if solving outside of them is=20 > possible. > > > https://patchwork.isar-build.org/project/isar/patch/20240705071856.904-..= .@siemens.com/=20 > > > - Manipulating of sstate sounds tricky and errors might be costly. > - Allowing overlapping will cause deploy file loosing on multiple target= =20 > setup. > > --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= f80e75b1-28aa-47ec-a0f6-1f41f3cc3d51n%40googlegroups.com. ------=_Part_232731_985508011.1760330334397 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Anton,

Thanks for the fixes. The patch looks goo= d, provides a complete solution, and addresses all issues without requiring= any additional changes downstream layers. I tested the patch with various = images that use DTB_FILES, and it worked fine with all builds.
Regards,
Badrikesh
On Wednesday, October 8, 2025 at 3:= 15:56=E2=80=AFPM UTC+5:30 Anton Mikanovich wrote:
08/10/2025 09:20, 'Badrikesh Prust= y' via isar-users wrote:
> Hello all,
>
> Apologies for the delayed response. I somehow missed the message.
>
> > This sounds familiar, and I think we discussed that multiple = times
> > already. Did you study previous threads/patches, e.g.
> > https://patchwork.isar-build.= org/project/isar/list/?series=3D1241?
> >
> > Yes, there were few patches that tried to solve the issue.
> >
> > Using subdirectory (variant similar to TS's)
> > - https://patchwork.isar-bui= ld.org/project/isar/list/?series=3D1149
> > Allows to overlap files
> > - https://patchwork.isar-bui= ld.org/project/isar/list/?series=3D1235
> > Make kernel deploy the files, instead of image recipes
> > - https://patchwork.isar-bui= ld.org/project/isar/list/?series=3D1241
> >
>
> I reviewed the previously shared patch, but not in full =E2=80=94 = thanks for=20
> sharing it here.
>
> The patch I sent is very similar to @nicusor=20
> patch:=C2=A0https://patchwork.isar= -build.org/project/isar/list/?series=3D1149
>
> I just reviewed the other patches and believe that many may encoun= ter=20
> the same issue. For instance, when attempting to build multiple=20
> kernels for a single image=E2=80=94such as `linux-image-amd64` and= =20
> `linux-image-amd64-rt` kernels=E2=80=94this overwrite problem is l= ikely to occur.
>
> This patch also resolves the issue with image builds that include= =20
> multiple kernels by storing the DTB files in the directory=20
> DEPLOYDIR/IMAGE_FULLNAME/KERNEL_NAME. This will also fix issues wh= en=20
> building with different DISTROs as IMAGE_FULLNAME includes target= =20
> DISTRO. Additionally, it fixes problems that arise when building w= ith=20
> different DISTROs, since IMAGE_FULLNAME includes the target DISTRO= .
>
> > This would affect downstream as well. You are missing a
> > RECIPE-API-CHANGELOG.md entry.
> >
>
> Yes, it will affect downstream layers. E.g. I checked with the=20
> isar-cip-core repo, changes will be required in `efibootguard-boot= `=20
> wic plugin. I will work on fixing it, once this is approved.
>
> Thanks and Regards,
> Badrikesh
Hello Badrikesh,

Files like scripts/lib/wic/plugins/source/bootimg-efi.py are borrowed= =20
from the
upstream and supposed to have as minimal changes as possible. Even havi= ng
changes in custom WIC plugins can results in additional side-effects.

Also, in general, DTBs should be part of a kernel, but not an image.
I've just released the new version of DTB deployment fix proposal w= hich=20
I hope
will cover all the cases. Please have a look:

https://patchwork.isar-build.org/project/isar/cover/2025= 1008085507....@ilbers.de/


There are also some observations regarding other implementations of the= same
fix were shared on the list previously:

https://patchwork.isar-build.org/project/i= sar/patch/20240416100746.568...@mentor.com/

- We don't want to modify WIC plugins if solving outside of them is= =20
possible.

https://patchwork.isar-build.org/proje= ct/isar/patch/20240705071856.904-...@siemens.com/

- Manipulating of sstate sounds tricky and errors might be costly.
- Allowing overlapping will cause deploy file loosing on multiple targe= t=20
setup.

--
You received this message because you are subscribed to the Google Groups &= quot;isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-use= rs+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-use= rs/f80e75b1-28aa-47ec-a0f6-1f41f3cc3d51n%40googlegroups.com.
------=_Part_232731_985508011.1760330334397-- ------=_Part_232730_670435788.1760330334397--