From: Alexander Smirnov <asmirnov@ilbers.de>
To: Claudius Heine <claudius.heine.ext@siemens.com>,
isar-users@googlegroups.com
Subject: Re: [PATCH 1/2] isar: Change build folders tree
Date: Mon, 11 Sep 2017 11:41:46 +0300 [thread overview]
Message-ID: <f83bf74a-8b00-756c-3e48-a766aacffa23@ilbers.de> (raw)
In-Reply-To: <fdf48e81-1bdd-df90-8ec5-ad5b7d549651@siemens.com>
On 09/11/2017 11:27 AM, Claudius Heine wrote:
> Hi,
>
> On 09/08/2017 11:48 AM, Alexander Smirnov wrote:
>> @@ -40,9 +39,9 @@ do_build() {
>> sed -i 's|##DISTRO_APT_SOURCE##|${DISTRO_APT_SOURCE}|'
>> ${WORKDIR}/multistrap.conf
>> sed -i 's|##DISTRO_SUITE##|${DISTRO_SUITE}|'
>> ${WORKDIR}/multistrap.conf
>> sed -i 's|##DISTRO_COMPONENTS##|${DISTRO_COMPONENTS}|'
>> ${WORKDIR}/multistrap.conf
>> - sed -i
>> 's|##CONFIG_SCRIPT##|./tmp/work/${PF}/${DISTRO}/configscript.sh|'
>> ${WORKDIR}/multistrap.conf
>> - sed -i 's|##SETUP_SCRIPT##|./tmp/work/${PF}/${DISTRO}/setup.sh|'
>> ${WORKDIR}/multistrap.conf
>> - sed -i
>> 's|##DIR_HOOKS##|./tmp/work/${PF}/${DISTRO}/hooks_multistrap|'
>> ${WORKDIR}/multistrap.conf
>> + sed -i
>> 's|##CONFIG_SCRIPT##|./tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/configscript.sh|'
>> ${WORKDIR}/multistrap.conf
>> + sed -i
>> 's|##SETUP_SCRIPT##|./tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/setup.sh|'
>> ${WORKDIR}/multistrap.conf
>> + sed -i
>> 's|##DIR_HOOKS##|./tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/hooks_multistrap|'
>> ${WORKDIR}/multistrap.conf
>
> Since you are touching this part in this patch series. Can you clean
> this up a bit in a seperate patch?
>
> Something like this just looks so much nicer, don't you agree?
>
> sed -e 's|##IMAGE_PREINSTALL##|${IMAGE_PREINSTALL}|g' \
> -e 's|##DISTRO##|${DISTRO}|g' \
> -e 's|##DISTRO_APT_SOURCE##|${DISTRO_APT_SOURCE}|g' \
> -e 's|##DISTRO_SUITE##|${DISTRO_SUITE}|g' \
> -e 's|##DISTRO_COMPONENTS##|${DISTRO_COMPONENTS}|g' \
> -e
> 's|##CONFIG_SCRIPT##|./tmp/work/${PN}/${MACHINE}/configscript.sh|g' \
> -e 's|##SETUP_SCRIPT##|${WORKDIR}/setup.sh|g' \
> -e
> 's|##DIR_HOOKS##|./tmp/work/${PN}/${MACHINE}/hooks_multistrap|g' \
> ${WORKDIR}/multistrap.conf.in > ${WORKDIR}/multistrap.conf
>
> Of course you have to fit that to your code here.
This series is outdated. Please comment on v2.
Alex
next prev parent reply other threads:[~2017-09-11 8:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 9:48 [PATCH 0/2] Unify work space for packages Alexander Smirnov
2017-09-08 9:48 ` [PATCH 1/2] isar: Change build folders tree Alexander Smirnov
2017-09-08 11:47 ` Henning Schild
2017-09-08 12:36 ` Alexander Smirnov
2017-09-08 12:59 ` Henning Schild
2017-09-08 13:07 ` Henning Schild
2017-09-08 13:20 ` Alexander Smirnov
2017-09-08 13:36 ` Henning Schild
2017-09-09 9:39 ` Claudius Heine
2017-09-11 7:28 ` Alexander Smirnov
2017-09-11 8:27 ` Claudius Heine
2017-09-11 8:41 ` Alexander Smirnov [this message]
2017-09-08 9:48 ` [PATCH 2/2] class/dpkg: Unify workplace for packages Alexander Smirnov
2017-09-08 11:29 ` Henning Schild
2017-09-08 10:01 ` [PATCH 0/2] Unify work space " Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f83bf74a-8b00-756c-3e48-a766aacffa23@ilbers.de \
--to=asmirnov@ilbers.de \
--cc=claudius.heine.ext@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox