From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6463342265335021568 X-Received: by 10.46.33.202 with SMTP id h71mr748448lji.3.1505119314915; Mon, 11 Sep 2017 01:41:54 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.146.131 with SMTP id u125ls266941wmd.0.gmail; Mon, 11 Sep 2017 01:41:54 -0700 (PDT) X-Google-Smtp-Source: AOwi7QB1CaCtseF9xNIknPai/2cAHs+MxgqwI3CXwSRS1rdT1XNDoCayJmWMO49tkIygpprd7cqm X-Received: by 10.28.138.195 with SMTP id m186mr549112wmd.9.1505119314526; Mon, 11 Sep 2017 01:41:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505119314; cv=none; d=google.com; s=arc-20160816; b=E4GwqJil7vE8gC6fU80bGYKLQyWzmNyxL0LbFtAmTY76nKJM79tv3ojZ1Z2eXTgDcB HP1qBA9jMUZmB7b6cX3z2MKKLHM0324HNXFzmLbtSYeKkbF918jpeMyMEESocVvJBkhu YpOkui6ptgyTsGfcBwWwzXq6MaEBZOAn04oQvaAIOa5cxCGTtih0zJiWHNjInyltc+Tp KLnCRKPRro7RhzGAgSqd0+FTtSvJXDSHpZEAgd2gNeLYGqeM3eq3H6dFj6XJqKxlvn9N ee0hRPHCwEUVnHVPfWZEQk+bokayFyDejWpuWd2LyKtsEVZ1WGJk7Pxro9O5FesM7lPR HSaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=r/E4Q10X6d3F2yb6+10jfOgkghtIbmufqh343yKV4gI=; b=TCKoB4MEYI5VR041UAovWCg7AUhg09Wk6vUoGCXL5mu8W54L+6F7/wbG6sxmgXWMvQ m4YvcyYhh5ega50uKY6X9vBE38v1oEPaynMOQFyRWweVvb4CGflXk5kgplI02C0kBRG6 C6PNzvUDSPcl+Xs0HDscBoR4rzOefej1YoBEQC4aYZJZT4CzeOPfplaV5CV/qYM831MT U04ksU4Ck99t8dAdI+nVjALF3iSE5b0b/lV7xJdE7JFEW7A4A9l4v6d1GZMO9QThp7nW FzB3nf3XXNbetJHkOuN189Y2fjfZDpmPxm0kZncHj5hHhV7MyBnKrMdsLf7x6x6pjl6D wK5A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id k18si479375wmd.1.2017.09.11.01.41.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Sep 2017 01:41:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v8B8fpBv030673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 11 Sep 2017 10:41:53 +0200 Subject: Re: [PATCH 1/2] isar: Change build folders tree To: Claudius Heine , isar-users@googlegroups.com References: <20170908094834.26496-1-asmirnov@ilbers.de> <20170908094834.26496-2-asmirnov@ilbers.de> From: Alexander Smirnov Message-ID: Date: Mon, 11 Sep 2017 11:41:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: iJLr+N0kOOex On 09/11/2017 11:27 AM, Claudius Heine wrote: > Hi, > > On 09/08/2017 11:48 AM, Alexander Smirnov wrote: >> @@ -40,9 +39,9 @@ do_build() { >> sed -i 's|##DISTRO_APT_SOURCE##|${DISTRO_APT_SOURCE}|' >> ${WORKDIR}/multistrap.conf >> sed -i 's|##DISTRO_SUITE##|${DISTRO_SUITE}|' >> ${WORKDIR}/multistrap.conf >> sed -i 's|##DISTRO_COMPONENTS##|${DISTRO_COMPONENTS}|' >> ${WORKDIR}/multistrap.conf >> - sed -i >> 's|##CONFIG_SCRIPT##|./tmp/work/${PF}/${DISTRO}/configscript.sh|' >> ${WORKDIR}/multistrap.conf >> - sed -i 's|##SETUP_SCRIPT##|./tmp/work/${PF}/${DISTRO}/setup.sh|' >> ${WORKDIR}/multistrap.conf >> - sed -i >> 's|##DIR_HOOKS##|./tmp/work/${PF}/${DISTRO}/hooks_multistrap|' >> ${WORKDIR}/multistrap.conf >> + sed -i >> 's|##CONFIG_SCRIPT##|./tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/configscript.sh|' >> ${WORKDIR}/multistrap.conf >> + sed -i >> 's|##SETUP_SCRIPT##|./tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/setup.sh|' >> ${WORKDIR}/multistrap.conf >> + sed -i >> 's|##DIR_HOOKS##|./tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/hooks_multistrap|' >> ${WORKDIR}/multistrap.conf > > Since you are touching this part in this patch series. Can you clean > this up a bit in a seperate patch? > > Something like this just looks so much nicer, don't you agree? > > sed -e 's|##IMAGE_PREINSTALL##|${IMAGE_PREINSTALL}|g' \ > -e 's|##DISTRO##|${DISTRO}|g' \ > -e 's|##DISTRO_APT_SOURCE##|${DISTRO_APT_SOURCE}|g' \ > -e 's|##DISTRO_SUITE##|${DISTRO_SUITE}|g' \ > -e 's|##DISTRO_COMPONENTS##|${DISTRO_COMPONENTS}|g' \ > -e > 's|##CONFIG_SCRIPT##|./tmp/work/${PN}/${MACHINE}/configscript.sh|g' \ > -e 's|##SETUP_SCRIPT##|${WORKDIR}/setup.sh|g' \ > -e > 's|##DIR_HOOKS##|./tmp/work/${PN}/${MACHINE}/hooks_multistrap|g' \ > ${WORKDIR}/multistrap.conf.in > ${WORKDIR}/multistrap.conf > > Of course you have to fit that to your code here. This series is outdated. Please comment on v2. Alex