Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl

[Jan Kiszka <jan.kiszka@siemens.com>]

On 29.05.20 07:53, [ext] Jan Kiszka wrote:
> On 28.05.20 22:04, Baurzhan Ismagulov wrote:
>> On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote:
>>> .PHONY is not needed (and wasn't consistently used anyway). And that
>>> missing && before the last export was apparently not critical as well.
>>
>> Wow, export A=a export B=b is accepted at least by bash. The && fix is still
>> needed if there is an error in A=a, thanks for the catch.
>>
>> Regarding .PHONY, could you please comment why it is not needed? Usually it's a
>> safeguard against the case when a file with the name of a target exists (e.g.,
>> override_dh_auto_clean). In that case, the target is not built, and .PHONY
>> enforces building. If there are no other reasons, I'd rather go towards making
>> it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install).
> 
> I suspect the Debian's build framework sets them already because I
> haven't seen them in use in all examples and manuals I read.
> 

Ping.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux