From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6830344030104059904 X-Received: by 2002:a5d:4dd0:: with SMTP id f16mr18557148wru.117.1592811372405; Mon, 22 Jun 2020 00:36:12 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:f58d:: with SMTP id f13ls1435288wro.1.gmail; Mon, 22 Jun 2020 00:36:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFaNFyQYc5aelLeqIt8KDDpJPRHPBLpHgfI641Uyw9P6fN1uJxo/cbJvM+GkgH8OWLEQJE X-Received: by 2002:adf:e4ce:: with SMTP id v14mr18239233wrm.64.1592811371618; Mon, 22 Jun 2020 00:36:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592811371; cv=none; d=google.com; s=arc-20160816; b=pBGes8+zqPb0/Z4mDr/D/deikQJQb47clD9LMpl0SbD3f4IqW5Z3BQeIHNwTtUud45 /c9dP3r68ej7iER6TzKtk2TJFzDtIQLkJI8u2ek+YhOX64a7HFOKbfpE5Hzk1AMnu/jm mRV9W+7Hjun4lKWa7yTnMptzQ20vQEfUqgQSXPnZVW3ac22Pf5PDxOVeKtD+E6M6ytzK 230FguOJzrMXqH7jpSeUMXJwAl45l150Ajy9xpSPR5pAGf/A//58GUgDqHNK6x+qRf6W ruq7igOb2LSj9JdHdHVwCvej8lWg4aUlnuh3Ssxg0ESAqlJBRnsQJ2oSeedt5/nh9MbP WD4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=rVJQc8PXpSfJt+Q+bkpOSg0CfSpI91z87EhryOvvSJw=; b=ldo5D8V5yUOkSgcMHQv1Xyj5H8Bk81H4B1nGYJ+U//PinnfN+4JO8boxS7/YVAwJnM nGyofUGu2kfyRORXLovtnDS0M4Ns8OTZ9EOo08ddJwFaEUXA6WjTqTdkQN90JNlZzhiR s5ftTPtUwM52COWJIGLolp5jNxqMtLBxWgFi/gE42XOjo8JnjtybI15DX9Rb8nPl7bXs sYspa9zZ1bWvcX/8FALe3ALyZ1mF1ca4bgOHqVyvhCfmuFaokFpner1Be4cVRO+h86Wc YnANbejocmpNvhxQ7CtwvqY5F0OXDrATP9XF/1bud9wpXiL8LvH/Gkv6pVpv5UBoekKw H1JQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id u17si722070wrq.1.2020.06.22.00.36.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2020 00:36:11 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 05M7aBSJ023704 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 22 Jun 2020 09:36:11 +0200 Received: from [139.22.110.241] (wpdkn10-01941.ad009.windad.org [139.22.110.241] (may be forged)) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 05M7aAL2006970 for ; Mon, 22 Jun 2020 09:36:10 +0200 Subject: Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl From: Jan Kiszka To: isar-users References: <289568e6-46d2-e2e3-9771-7668cd10bc01@web.de> <20200528200446.3zlpkejasd2gex4r@yssyq.m.ilbers.de> <4ddde1de-c1bc-451a-e9a1-dd2bd17712bf@siemens.com> Message-ID: Date: Mon, 22 Jun 2020 09:36:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <4ddde1de-c1bc-451a-e9a1-dd2bd17712bf@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: CgPSnu+O5T+r On 29.05.20 07:53, [ext] Jan Kiszka wrote: > On 28.05.20 22:04, Baurzhan Ismagulov wrote: >> On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote: >>> .PHONY is not needed (and wasn't consistently used anyway). And that >>> missing && before the last export was apparently not critical as well. >> >> Wow, export A=a export B=b is accepted at least by bash. The && fix is still >> needed if there is an error in A=a, thanks for the catch. >> >> Regarding .PHONY, could you please comment why it is not needed? Usually it's a >> safeguard against the case when a file with the name of a target exists (e.g., >> override_dh_auto_clean). In that case, the target is not built, and .PHONY >> enforces building. If there are no other reasons, I'd rather go towards making >> it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install). > > I suspect the Debian's build framework sets them already because I > haven't seen them in use in all examples and manuals I read. > Ping. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux