[PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl

[PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

.PHONY is not needed (and wasn't consistently used anyway). And that
missing && before the last export was apparently not critical as well.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/recipes-kernel/linux/files/debian/rules.tmpl | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/meta/recipes-kernel/linux/files/debian/rules.tmpl b/meta/recipes-kernel/linux/files/debian/rules.tmpl
index 46b56ec5..05a26fe2 100755
--- a/meta/recipes-kernel/linux/files/debian/rules.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/rules.tmpl
@@ -12,28 +12,24 @@ isar_env=$(strip \
 	export DEB_BUILD_PROFILES='$(DEB_BUILD_PROFILES)' && \
 	export DEB_HOST_GNU_TYPE='$(DEB_HOST_GNU_TYPE)' && \
 	export MAKE='$(MAKE)' && \
-	export O='${O}' \
+	export O='${O}' && \
 	export S='${S}' \
 )

 %:
 	dh $(@)

-.PHONY: override_dh_auto_clean
 override_dh_auto_clean:
 	$(isar_env) && bash $(deb_top_dir)/isar/clean

-.PHONY: override_dh_auto_build
 override_dh_auto_build:
 	$(isar_env) && bash $(deb_top_dir)/isar/build

 override_dh_auto_install:
 	$(isar_env) && bash $(deb_top_dir)/isar/install

-.PHONY: override_dh_auto_test
 override_dh_auto_test:
 	true

-PHONY: override_dh_strip
 override_dh_strip:
 	unset DEB_HOST_GNU_TYPE && dh_strip -Xvmlinu --no-automatic-dbgsym
--
2.26.1

Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl

[Baurzhan Ismagulov]

On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote:
> .PHONY is not needed (and wasn't consistently used anyway). And that
> missing && before the last export was apparently not critical as well.

Wow, export A=a export B=b is accepted at least by bash. The && fix is still
needed if there is an error in A=a, thanks for the catch.

Regarding .PHONY, could you please comment why it is not needed? Usually it's a
safeguard against the case when a file with the name of a target exists (e.g.,
override_dh_auto_clean). In that case, the target is not built, and .PHONY
enforces building. If there are no other reasons, I'd rather go towards making
it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install).

With kind regards,
Baurzhan.

Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl

[Jan Kiszka]

On 28.05.20 22:04, Baurzhan Ismagulov wrote:
> On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote:
>> .PHONY is not needed (and wasn't consistently used anyway). And that
>> missing && before the last export was apparently not critical as well.
> 
> Wow, export A=a export B=b is accepted at least by bash. The && fix is still
> needed if there is an error in A=a, thanks for the catch.
> 
> Regarding .PHONY, could you please comment why it is not needed? Usually it's a
> safeguard against the case when a file with the name of a target exists (e.g.,
> override_dh_auto_clean). In that case, the target is not built, and .PHONY
> enforces building. If there are no other reasons, I'd rather go towards making
> it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install).

I suspect the Debian's build framework sets them already because I
haven't seen them in use in all examples and manuals I read.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl

[Jan Kiszka]

On 29.05.20 07:53, [ext] Jan Kiszka wrote:
> On 28.05.20 22:04, Baurzhan Ismagulov wrote:
>> On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote:
>>> .PHONY is not needed (and wasn't consistently used anyway). And that
>>> missing && before the last export was apparently not critical as well.
>>
>> Wow, export A=a export B=b is accepted at least by bash. The && fix is still
>> needed if there is an error in A=a, thanks for the catch.
>>
>> Regarding .PHONY, could you please comment why it is not needed? Usually it's a
>> safeguard against the case when a file with the name of a target exists (e.g.,
>> override_dh_auto_clean). In that case, the target is not built, and .PHONY
>> enforces building. If there are no other reasons, I'd rather go towards making
>> it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install).
> 
> I suspect the Debian's build framework sets them already because I
> haven't seen them in use in all examples and manuals I read.
> 

Ping.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl

[Jan Kiszka]

On 22.06.20 09:36, [ext] Jan Kiszka wrote:
> On 29.05.20 07:53, [ext] Jan Kiszka wrote:
>> On 28.05.20 22:04, Baurzhan Ismagulov wrote:
>>> On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote:
>>>> .PHONY is not needed (and wasn't consistently used anyway). And that
>>>> missing && before the last export was apparently not critical as well.
>>>
>>> Wow, export A=a export B=b is accepted at least by bash. The && fix is still
>>> needed if there is an error in A=a, thanks for the catch.
>>>
>>> Regarding .PHONY, could you please comment why it is not needed? Usually it's a
>>> safeguard against the case when a file with the name of a target exists (e.g.,
>>> override_dh_auto_clean). In that case, the target is not built, and .PHONY
>>> enforces building. If there are no other reasons, I'd rather go towards making
>>> it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install).
>>
>> I suspect the Debian's build framework sets them already because I
>> haven't seen them in use in all examples and manuals I read.
>>
> 
> Ping.
> 
> Jan
> 

Ping²

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux