From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7136477983660834816 X-Received: by 2002:adf:d1e3:0:b0:226:eb63:1d67 with SMTP id g3-20020adfd1e3000000b00226eb631d67mr5226994wrd.335.1662048490717; Thu, 01 Sep 2022 09:08:10 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:c4c5:0:b0:3a5:24fe:28ff with SMTP id g5-20020a7bc4c5000000b003a524fe28ffls900140wmk.0.-pod-control-gmail; Thu, 01 Sep 2022 09:08:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR7eJz67u8ZAqD4lgUIHuuP1NID+alOaYwqUpVgzgG6IpTpj8/J03QOhez0kGkIcny69Q9pM X-Received: by 2002:a05:600c:2058:b0:3a5:bd96:ba16 with SMTP id p24-20020a05600c205800b003a5bd96ba16mr5872338wmg.37.1662048489310; Thu, 01 Sep 2022 09:08:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1662048489; cv=pass; d=google.com; s=arc-20160816; b=P79IYK2ivOin60z/Qkr605ytBY5zO3AGk4X+ZxBAPRYD1Fd+o8UJtczVSJaF8neVHv jizp/s4/sk99UlBn9dX+Xzd+fKFEH5ugXOttS1bAN/MRW5GF7dMYLLaDno3YsaATuSOY WPgXl56giw6WJBoxSs8FVVKiLv3tKx8zRZ9nKNyiw6ReRTpc7alHoRmVCgz+IXIosSUA 46+tzdioXXwDSqo4EAa0I3PsEwAi10DE52JO5lmgMfjLxezvEv93tugQbHjuJnKDZx13 WsqW/0OcQcmHLrIVTFWAUnZHRqhPHbQU8kBmsaZ38WhFzZ3jr3Q89amP9JqMsHFZuATx UhEA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=+oKqj5dbkMLizLjXiRBFykIC3zdFRqi18xPHbGIvnMA=; b=oqZZEYIsLvBBS6xDFq2zXX6d3RRHTVysM2fmyVpTKfs7eQ2SQI8Ogn4Y1u8MaQX7UU mn5ceSiedthpn0SvCbjHb5f9Ntj0ZqiG6YhqTGRslP8HUk9HlvGkGtVYT/GViKy5/v7t LZvgnq5d22s8TQFvv/eQlPxyoAlSPSOFCKhCeVH2Lmhp0/W1TC7dlnI0WWDzbUg0ygl5 H0z1ZdTUenHsK5sLxCuGWHv9HPGES9zuZBVj+ySs6Z9qbE98Hk9zfKrIB/rsl/Gpvz85 3L0+yZAc1poCXeiUKG+yq/4tQtGQzh9NfynIUyrcag4Jkw33j+dFgAKk0nPNCtvvn9M+ wRAQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=IbCU8quS; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.0.48 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00048.outbound.protection.outlook.com. [40.107.0.48]) by gmr-mx.google.com with ESMTPS id bx5-20020a5d5b05000000b00226e3ba2090si395386wrb.1.2022.09.01.09.08.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Sep 2022 09:08:09 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.0.48 as permitted sender) client-ip=40.107.0.48; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=IbCU8quS; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.0.48 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jogdcGA5sX9Y1bVkYYVv6urvWVRLQPIS/IU3nTLOzA0IWwZjYOJTPCOSYcpyQVBfLs0qUsze0qq8sLfzrrez8l4srUVs0iTnZxCCfjw/KXnUBdvFmPD2u9hKsSkmhBuEnT1ztjJ1/22GLRygIg5M9Ad/QJkQUndrSxIPow4Bml0v7J429K/g2YDIvPoStaC+wBgFVc4XjMFiWaThK3oLI+rvcGnGRbstSKg7KzMh0WMBSUslC7JLZ0D52gxYM7L1/poDOSo1MTHZphQM6RqBpX9CZA4x4ZxmuID5lqQ14s1HDm/GbpyBpUxveGSjjk0o/TgImRcv0ljEScLiTEj8tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+oKqj5dbkMLizLjXiRBFykIC3zdFRqi18xPHbGIvnMA=; b=K5Y9NLZqecUSWHS/0F0xSBrLGK2KgH1Mru+RR1LS7qjUiE6geqN+rWvg9oOdcWldtt7IbjCPfs3MDaayWoE9Hqutle2o2m90Fnol4XJ1A9sw/d17ysp6F6raFvo4GvRiPuTf9E53ikFxWRFv5TQjGPZMvmO3YwcyvKJ7rTG/5QeiOFD/jAn2mAj6zX4DuJ7OrGScKXLNEMMOjUPDbohF3mQeNOUxfNgVWOr3pLHFff3rwzISaU0ZvYjv5X9aclMzwPAnml7Ym2R2xLhV6j3we2fxuNYRg6/yWV3sZHHAjUE+EgWQ9mUT37iWJveoXaqhkX6B05JN/rpjbP5mmwf5xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.76) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+oKqj5dbkMLizLjXiRBFykIC3zdFRqi18xPHbGIvnMA=; b=IbCU8quSWx+ORINTYoEmy/jNYBrmuVwoXtBYSVCR64cfC42fHlCW4U8oqDB1eOX6RDOb5U+BKozN+QF7k+koeQVvU39EF6Vm4NJL6HXpGaqulzBr/8pko+xl/ZYhPfyb2UEmlf9Me3Z2+jSlitCwKnIQRAs27RpL//ZuZkiG8x48g/g8gQ8100phQpCScnAEPwZbdEA3+sQmJE6nCsdpZv/BR+XYXTQpWjDCWNGHwse8PbhL7jxvSad5RgsRjORJoUYY2uNxkOBoB4nieuK4EtwhWZxXSyQlNe9YLZ5wGvUjQSlKNZq7GC1fH8cyJzOka0q+WUHVVseVdQ4oWNhrzQ== Received: from DB8PR06CA0056.eurprd06.prod.outlook.com (2603:10a6:10:120::30) by DU0PR10MB6874.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:47f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 1 Sep 2022 16:08:08 +0000 Received: from DB5EUR01FT055.eop-EUR01.prod.protection.outlook.com (2603:10a6:10:120:cafe::b9) by DB8PR06CA0056.outlook.office365.com (2603:10a6:10:120::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 16:08:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.76) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.76 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.76; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.76) by DB5EUR01FT055.mail.protection.outlook.com (10.152.5.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 16:08:08 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8VSA.ad011.siemens.net (194.138.21.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Thu, 1 Sep 2022 18:08:07 +0200 Received: from [139.25.68.37] (139.25.68.37) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.9; Thu, 1 Sep 2022 18:08:07 +0200 Message-ID: Date: Thu, 1 Sep 2022 18:08:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 1/3] example-module: improve Makefile to be more realistic Content-Language: en-US To: Henning Schild , CC: Pingfang Liao , Florian Bezdeka References: <20220827085905.6116-1-henning.schild@siemens.com> From: Jan Kiszka In-Reply-To: <20220827085905.6116-1-henning.schild@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [139.25.68.37] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--17.179700-8.000000 X-TMASE-MatchedRID: XYZjbEcsSe45QaOxwNGfvo9bHfxDWoibZNzy/VZxWpGnIRazgfZGp2PR QPg64rFKy5JfHvVu9Iu8L1BXWTx4CCFs256C7Tkb9oc+OKcp1B0Uh606rb6lUIlSWYvdSPSYTJD l9FKHbrkGmHr1eMxt2VMe5Blkpry7VHGUsCD3DhA4Puhfcg5/o3iXGrukUFRRtw+xHnsmQjNQ2v 2cnMDdZAoDY6gYCVOTqPBmIQgMvkjg+ni3hffPI9wqE4SQ2KydYZvdzZigPPmwWQIt56582y6My Pq4TWG5tsxVqq1TeAWSLvAQjXykCkGPbm3tak5+kZOl7WKIImrvXOvQVlExsHAruZnjhopu+gD2 vYtOFhgqtq5d3cxkNV8uqL0Kl8MByqbx+GG1MwXVXvSwvBOZStHAnVafxhD6/nAoE5fC0i0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--17.179700-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: BEF3207B2029EB3207EBFBA897D2698BF64E3FEADE6CE41021A8D2230CFBE77E2000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a283ce54-256e-4d7b-b9d4-08da8c34293e X-MS-TrafficTypeDiagnostic: DU0PR10MB6874:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4tz9UUDmVG6lllz/9+dd+kPLy7wlaambWA69aZTQNQ9G39xt9K3JI9yr4B0O9nttB6tNre2zW2Qpcf3I5RbaDbZWBTyZgaFI0rrOS3f+Uyuq1H6FmzyUwfIe//W66eL+PirTVt0sZ9+mzbHMCH2P6rIDLS3yKMHPWrK9IluM9Wkyw7AfN+6Rn6PN6x5eWRUWNF7a6jqlzhXM2EG/4P2N0Zh4ZQMf+Rd4rvQupFfeJW5TUSOSyhRTVwoZMsV8QWBI8IICRU7vqh2qkKwwPJ0YkEC3mjdVa/uBQaHJFz6CWBOID4xo6qT0sBVgocL1WfTl3uCkkXRfrtNTe085Dxhs3scAXyc5KNvykf2IfGtC0rK3GoIQv9aF6L3tCnwYBqizVGX9erWaVeNhae6nr5Bk8cBlCWrIvIvCABk6g7TQMqzNewnYBNIw6403W+nXxkXta1GeMEoUOw3IDROAwjYVxh3+Mp05ftQhx1FhU+eUY0fmIA+uB8z6OVKsOueFltxz1fOPTfNGMHhDKSq5Y6JOqgYpN8az3u1DAj2ys8bFfuv19HlANJK27HY7+ywrP4XU/Ulx4iOQkGHw6bIwK2taem3X6aWoBof4QBGLwHptVkCWCz64phjjsemFLWZD0yWNh3oE9VJGrXOZ3Juke3RJ8ZewE82hfqHx8c7NZZnMpVfhDZaJ9xSxD3AjSsmJd4vDFGMO9D83R9R7h83EkUtxH8msEpQJxJz5xDNfMDsgD11ogTAYZhaIpoEGmGbbrJ1sp974l0zWP3L41Pm1YgJ5f0Lkif/p9nwn1Gpbs5QK/Oql9g2DmyuBkcYIg1KbBaLg3UcPDBBSq/hTNmy8rEbRb2uemDQ3hBG03PROCmZqinw= X-Forefront-Antispam-Report: CIP:194.138.21.76;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(136003)(46966006)(40470700004)(36840700001)(5660300002)(83380400001)(8936002)(16526019)(956004)(70206006)(336012)(41300700001)(186003)(107886003)(8676002)(2616005)(26005)(44832011)(70586007)(4326008)(47076005)(478600001)(86362001)(82310400005)(16576012)(36860700001)(40460700003)(82740400003)(2906002)(31686004)(53546011)(82960400001)(31696002)(316002)(40480700001)(54906003)(356005)(6706004)(81166007)(110136005)(36756003)(3940600001)(43740500002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 16:08:08.3886 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a283ce54-256e-4d7b-b9d4-08da8c34293e X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.76];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT055.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB6874 X-TUID: rhQPUyurBOMe On 27.08.22 10:59, Henning Schild wrote: > A real out-of-tree module would be able to "make" on its own, finding > its own KDIR and not rely on some external entity to provide that. But > of cause allow KDIR to be provided from outside. > > Fixes: 8d9e4e3c0857 ("Add exemplary kernel module") > Signed-off-by: Henning Schild > --- > .../example-module/files/src/Makefile | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/meta-isar/recipes-kernel/example-module/files/src/Makefile b/meta-isar/recipes-kernel/example-module/files/src/Makefile > index 2561cfd410e5..df3241652cf1 100644 > --- a/meta-isar/recipes-kernel/example-module/files/src/Makefile > +++ b/meta-isar/recipes-kernel/example-module/files/src/Makefile > @@ -1,8 +1,20 @@ > # Example module > # > # This software is a part of ISAR. > -# Copyright (c) Siemens AG, 2018 > +# Copyright (c) Siemens AG, 2018-2022 > # > # SPDX-License-Identifier: GPL-2.0 > > obj-m := example-module.o > + > +INSTALL_MOD_PATH ?= $(DESTDIR) > +export INSTALL_MOD_PATH > + > +KDIR ?= /lib/modules/$(shell uname -r)/build > + > +modules modules_install clean: > + $(MAKE) -C $(KDIR) M=$(PWD) $@ > + > +install: modules_install > + > +.PHONY: modules modules_install install clean This is convenient of you call things on the command line but unneeded for the minimal case that we also support in Isar. Therefore, it was not added to this example. Jan -- Siemens AG, Technology Competence Center Embedded Linux