From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Cedric Hombourger <cedric.hombourger@siemens.com>,
Zhihang Wei <wzh@ilbers.de>
Subject: Re: [PATCH] rootfs: Fix disabling of initrd generation if there is a custom one
Date: Tue, 9 Dec 2025 00:12:58 +0100 [thread overview]
Message-ID: <f86e1861-468c-4be8-8010-394a9d338602@siemens.com> (raw)
In-Reply-To: <548d8ad4-cb74-46e6-87b8-47d79975176d@siemens.com>
On 29.11.25 16:13, 'Jan Kiszka' via isar-users wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> The variable is now called IMAGE_INITRD.
>
> Fixes: c3c4e72cbfc4 ("image: introduce IMAGE_INITRD, deprecate INITRD_IMAGE")
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/classes/rootfs.bbclc3c4e72cbfc4ass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index 70d4bfb8..eb5645af 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -23,7 +23,7 @@ ROOTFS_INITRAMFS_GENERATOR_CMD = "${@ d.getVar('ROOTFS_INITRAMFS_GENERATOR_CMDLI
> ROOTFS_INITRAMFS_GENERATOR_CMDLINE = "${@ initramfs_generator_cmdline(d)}"
> ROOTFS_BASE_DISTRO ?= "${BASE_DISTRO}"
> c3c4e72cbfc4c3c4e72cbfc4
> -INITRD_IMAGE ?= ""
> +IMAGE_INITRD ?= ""
>
> # Features of the rootfs creation:
> # available features are:
> @@ -33,7 +33,7 @@ INITRD_IMAGE ?= ""
> # 'clean-log-files' - delete log files that are not owned by packages
> # 'populate-systemd-preset' - enable systemd units according to systemd presets
> # 'generate-initrd' - generate debian default initrd
> -ROOTFS_FEATURES += "${@ 'generate-initrd' if d.getVar('INITRD_IMAGE') == '' else ''}"
> +ROOTFS_FEATURES += "${@ 'generate-initrd' if d.getVar('IMAGE_INITRD') == '' else ''}"
>
> ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes"
>
This was is still not on the fast path, although being a critical
regression fix. In fact, there are several more fixes related to
c3c4e72cbfc4 not yet in that track, are they?
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/f86e1861-468c-4be8-8010-394a9d338602%40siemens.com.
next prev parent reply other threads:[~2025-12-08 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 15:13 'Jan Kiszka' via isar-users
2025-12-08 23:12 ` 'Jan Kiszka' via isar-users [this message]
2025-12-11 9:12 ` Zhihang Wei
2025-12-11 9:12 ` Zhihang Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f86e1861-468c-4be8-8010-394a9d338602@siemens.com \
--to=isar-users@googlegroups.com \
--cc=cedric.hombourger@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=wzh@ilbers.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox