public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: Claudius Heine <ch@denx.de>, isar-users@googlegroups.com
Subject: Re: [PATCH] inc files: append local files path to FILESPATH
Date: Thu, 03 Aug 2023 00:34:59 +0300	[thread overview]
Message-ID: <f8789fc019037aa5e31508b28b34f470b22867a2.camel@ilbers.de> (raw)
In-Reply-To: <20230705081136.606969-1-ch@denx.de>

On Wed, 2023-07-05 at 10:11 +0200, Claudius Heine wrote:
> FILESEXTRAPATHS is meant to allow bbappend files to overwrite files
> from
> their recipe. For this reason the 'normal' pattern in bbappend files
> is
> to prepend the local file path to FILESEXTRAPATHS, which results in
> files from the local file path to be preferred over files from the
> original recipe, or other, lower prioritized bbappend files.
> 
> The `.inc` files are meant to be included by other recipes (`.bb`)
> files. So it should still allow the recipe (`.bb` file) to overwrite
> files its files that where added via the default recipes `FILESPATH`
> search path.
> 
> If a `.inc` file use `FILESEXTRAPATHS:prepend` to add its local file
> path to `FILESPATH`, then the recipe, that includes the `.inc` file
> would have to use `FILESEXTRAPATHS:prepend` as well, after including
> the
> `.inc` file in order to overwrite the local files from the `.inc`
> file.
> 
> However this is only a workaround of the issue that originates from
> the
> `.inc` file using the `FILESEXTRAPATHS` variable.
> 
> `.inc` should append its local file search path to `FILESPATH`, so
> that
> it allows other recipes to overwrite any file from it via its default
> `FILESPATH`, without requiring an additional workaround.
> 
> This patch replaces all occurences of
>         FILESEXTRAPATHS:prepend := "${FILE_DIRNAME}/files:"
> with
>         FILESPATH:append := ":${FILE_DIRNAME}/files"
> in the `.inc` files.
> 
> Signed-off-by: Claudius Heine <ch@denx.de>

Applied to next, thanks.

New .inc files from new optee* recipes were also considered.

      reply	other threads:[~2023-08-02 21:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05  8:11 Claudius Heine
2023-08-02 21:34 ` Uladzimir Bely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8789fc019037aa5e31508b28b34f470b22867a2.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=ch@denx.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox