Re: [PATCH 1/5] ccache: fix dirs creation

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

On Mon, 2022-12-19 at 17:29 +0300, Anton Mikanovich wrote:
> Create ccache debug directory only if CCACHE_DEBUG is enabled.
> Also restore CCACHE_DIR creation if not exist.
> 
> Fixes 7956c4c ("add flag to enable ccache debug mode")

The reason I implemented it like that was to avoid conditional
execution paths. All these paths need testing and the value of not
creating the ${CCACHE_DIR}/debug is very little (or is there a
technical reason why the debug folder should not be there?).

> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/buildchroot.bbclass | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/buildchroot.bbclass
> b/meta/classes/buildchroot.bbclass
> index b4ff2886..72eb80bc 100644
> --- a/meta/classes/buildchroot.bbclass
> +++ b/meta/classes/buildchroot.bbclass
> @@ -25,7 +25,10 @@ MOUNT_LOCKFILE = "${BUILDCHROOT_DIR}.lock"
>  
>  buildchroot_do_mounts() {
>      if [ "${USE_CCACHE}" = "1" ]; then
> -        mkdir -p ${CCACHE_DIR}/debug
> +        mkdir -p ${CCACHE_DIR}
> +        if [ "${CCACHE_DEBUG}" = "1" ]; then
> +            mkdir -p ${CCACHE_DIR}/debug

As we touch this code now, please also put the paths in quotes to make
sure directories with spaces are handled correctly.

Felix

> +        fi
>      fi
>  
>      sudo -s <<'EOSUDO'
> -- 
> 2.17.1
>