From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6652594697292218368 X-Received: by 2002:a1c:1a53:: with SMTP id a80mr10722188wma.15.1553500384297; Mon, 25 Mar 2019 00:53:04 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:c403:: with SMTP id k3ls1900453wmi.2.gmail; Mon, 25 Mar 2019 00:53:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxiHd2ErGFM6Vz5/dMAXCrqmRQ8R9t6D1B5Yvgqh9FCVOL9x4yILUjo1gDO6NKQQdDnURtB X-Received: by 2002:a1c:38b:: with SMTP id 133mr4558243wmd.26.1553500383877; Mon, 25 Mar 2019 00:53:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553500383; cv=none; d=google.com; s=arc-20160816; b=xFb2jZI7x1gwEO7IunLr4oLmrMb2z6pkx4WrlzaYg6OCxy9o+LwirX/1KJxDCuTl4x bYbGG2KwA/Nkrf9/g8th0X13b1SJG0zoIruGq9iZ22vksrBxQqzJgybuqEWSdX4sIN+E Q/vkmvMVJBxwmxouX0Sx82sfwCcDWQC1xeEC+A4p+blb0rouVD463yTwTqiaCZKeYGnE V6EH0+2MK1XdiGOkWe0kxf10791uTrocvX/mc09NWRIYkXQ02TtRaZrxHokmr3+gO8XE psd4b1kasGGBFmXHXrve880v6IJ06sc1gOALkkQIKwC87dNa3yt/lZskSJg6dMOUktL0 wDzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id; bh=v0BmMCwe+tNcSMU5OCo493km37oyaiaxvhDn1IJ5q/U=; b=Y3RJIbUTq6H32ZNfz/91T+g93BgS6PkEbqSXb6kILaqDcdvgXHxHPmh7nKZTeM2lG0 jvMBTODh5szlrHfXudsLlEzE0cPk0jhGhVuVA5sIXg6nHLK/pcVQINULxCwnPGU/3YiE 0lfygVh+yd5LwtcnQOhC/meGmvC5tyu4k9U72OA3fCEXuO6CdjBZYSrZbfAkhmQPEeSL 0IRnnuMzs/bs34pVb2gV/WJfTc6BkXltiln0DDsfNbSC+D2veXOXQTqqJNNLuz1Rl1AT feVzQYH4QoJnNhVKkXnl4DFLVtv348f0XH4WsjREpGmQZbzA3F0/jOvjQBe3fvwDFte4 +X6w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id u6si443845wrw.2.2019.03.25.00.53.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 00:53:03 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x2P7r3U9004137 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Mar 2019 08:53:03 +0100 Received: from linux-ses-ext02.ppmd.siemens.net (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x2P7r3Tq016785; Mon, 25 Mar 2019 08:53:03 +0100 Message-ID: Subject: Re: [PATCH v4 1/1] meta: added do_transform_template task as templating system and switch From: Claudius Heine To: Jan Kiszka , isar-users@googlegroups.com Cc: Claudius Heine Date: Mon, 25 Mar 2019 08:53:03 +0100 In-Reply-To: <56f05745-cd50-e946-e189-22402b7c4d63@web.de> References: <20190214112850.12469-1-claudius.heine.ext@siemens.com> <20190214112850.12469-2-claudius.heine.ext@siemens.com> <56f05745-cd50-e946-e189-22402b7c4d63@web.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUID: JraTD6ijtOeq Hi Jan, On Sun, 2019-03-24 at 19:28 +0100, Jan Kiszka wrote: > On 14.02.19 12:28, [ext] claudius.heine.ext@siemens.com wrote: > > From: Claudius Heine > > > > The new introduced variables are TEMPLATE_FILES and TEMPLATE_VARS. > > TEMPLATE_FILES is a list of files that should be processed in the > > `do_transform_template` task and TEMPLATE_VARS is a list of bitbake > > variable names that should be substituted in the template file. > > > > Bad news: This patch introduced a regression into the release (sorry, > didn't > manage to test earlier). It destroys the reuse of self-built > identical packages > for different targets. Namely, jailhouse-images now tries to build > the shared > (per arch) kernel multiple times, and that fails miserably because > there is a > common folder for all of them. The issue disappears when removing the > do_transform_template task from the chain. Hmm, have you looked at the resulting 'TEMPLATE_VARS' variable? All variables in there need to be the same in order for it to have the same stamp. If that is not the case then maybe overwriting it instead of appending it might work. These are the defaults set in 'template.bbclass': TEMPLATE_VARS ?= "PN PV DESCRIPTION HOMEPAGE MAINTAINER KERNEL_NAME MACHINE DISTRO_ARCH" If I understand you correctly then your recipe should not be dependant on the MACHINE? So either remove MACHINE 'TEMPLATE_VARS_remove = "MACHINE"' or just set a 'TEMPLATE_VARS' that you really need in your template files. Cheers, Claudius > > Digging deeper, the reason is that do_transform_template is not > shared but run > multiple times (even if nothing has to be done), forcing all > succeeding tasks > into private mode as well. I suspect that's because bitbake cannot > assess if the > output of the task python function is identical. I guess we need to > help bitbake > here. Any idea how? Own stamping logic? > > Jan