public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "vijaikumar....@gmail.com" <vijaikumar.kanagarajan@gmail.com>
To: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH v2 3/3] CI: test the exclude-path feature of wic
Date: Tue, 1 Sep 2020 22:30:30 -0700 (PDT)	[thread overview]
Message-ID: <f9b88e0e-c703-4804-8d3c-7c074db31630n@googlegroups.com> (raw)
In-Reply-To: <20200901195405.32162-1-ibr@radix50.net>


[-- Attachment #1.1: Type: text/plain, Size: 2101 bytes --]



On Wednesday, September 2, 2020 at 1:24:13 AM UTC+5:30 i...@radix50.net 
wrote:

> From: Henning Schild <henning...@siemens.com> 
>
> Signed-off-by: Henning Schild <henning...@siemens.com> 
> --- 
> scripts/ci_build.sh | 12 ++++++++++++ 
> 1 file changed, 12 insertions(+) 
>
> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh 
> index d2c707b..af996d1 100755 
> --- a/scripts/ci_build.sh 
> +++ b/scripts/ci_build.sh 
> @@ -212,3 +212,15 @@ echo -e "do_fetch_append() {\n\n}" >> 
> "${ISARROOT}/meta/classes/dpkg-base.bbclas 
> bitbake $BB_ARGS mc:qemuamd64-stretch:isar-image-base 
>
> mv "${ISARROOT}/meta/classes/dpkg-base.bbclass.ci-backup" 
> "${ISARROOT}/meta/classes/dpkg-base.bbclass" 
> + 
> +# Test wic --exclude-path 
> +cp -a "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" 
> "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks.ci-backup" 
>
> +mv 
> ${BUILDDIR}/tmp/deploy/images/qemuamd64/isar-image-base-debian-stretch-qemuamd64.wic.img 
> \ 
> + 
> ${BUILDDIR}/tmp/deploy/images/qemuamd64/isar-image-base-debian-stretch-qemuamd64.wic.img.ci-backup 
>
> +sed -i -e 's/part \/ /part \/ --exclude-path usr /g' 
> "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" 
> + 
> +bitbake $BB_ARGS mc:qemuamd64-stretch:isar-image-base 
> + 
> +mv 
> "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks.ci-backup" 
> "${ISARROOT}/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks" 
> +mv 
> ${BUILDDIR}/tmp/deploy/images/qemuamd64/isar-image-base-debian-stretch-qemuamd64.wic.img.ci-backup 
> \ 
> + 
> ${BUILDDIR}/tmp/deploy/images/qemuamd64/isar-image-base-debian-stretch-qemuamd64.wic.img 
>
>

The only problem I see is the CI actually doesnot validate the image to see 
if /usr is excluded. It validates the code-path for errors but
doesnot validate the feature itself. We could mount and check though.
Once the new wic is integrated this should be easy with the "wic ls" 
feature. We could list the contents of the partition using
"wic ls" and validate if /usr is excluded.

Thanks,
Vijai Kumar K

-- 
> 2.20.1 
>
>

[-- Attachment #1.2: Type: text/html, Size: 2679 bytes --]

  reply	other threads:[~2020-09-02  5:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 20:16 [PATCH 0/3] fix and test wic exclude-path Henning Schild
2020-04-06 20:16 ` [PATCH 1/3] oe.path: Add copyhardlink() helper function Henning Schild
2020-04-06 20:16 ` [PATCH 2/3] lib/oe/path: try hardlinking instead of guessing when it might fail Henning Schild
2020-04-06 20:16 ` [PATCH 3/3] CI: test the exclude-path feature of wic Henning Schild
2020-05-07 19:25   ` Baurzhan Ismagulov
2020-05-07 20:13     ` Henning Schild
2020-09-01 19:54   ` [PATCH v2 " Baurzhan Ismagulov
2020-09-02  5:30     ` vijaikumar....@gmail.com [this message]
2020-09-02 10:10       ` Henning Schild
2020-04-06 20:18 ` [PATCH 0/3] fix and test wic exclude-path Henning Schild
2020-06-10 15:26 ` Henning Schild
2020-06-12  6:55   ` Baurzhan Ismagulov
2020-06-12 15:17     ` Jan Kiszka
2020-06-12 18:11       ` Henning Schild
2020-06-12 18:17         ` Henning Schild
2020-06-12 18:44           ` Jan Kiszka
2020-06-12 18:22       ` Henning Schild
2020-06-12 18:46         ` Jan Kiszka
2020-06-12 18:03     ` Henning Schild
2020-09-01 19:53       ` Baurzhan Ismagulov
2020-09-02  5:24         ` vijaikumar....@gmail.com
2020-09-02 10:04         ` Henning Schild
2020-09-14 13:36 ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9b88e0e-c703-4804-8d3c-7c074db31630n@googlegroups.com \
    --to=vijaikumar.kanagarajan@gmail.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox