[PATCH] isar-image: umount base-apt when doing offline build

[PATCH] isar-image: umount base-apt when doing offline build

[Jan Kiszka]

Leaving it mounted "slightly" increases the target image size.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/isar-image.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
index 7aaaecb..23b3a99 100644
--- a/meta/classes/isar-image.bbclass
+++ b/meta/classes/isar-image.bbclass
@@ -63,6 +63,10 @@ isar_image_cleanup() {
     sudo umount -l ${IMAGE_ROOTFS}/proc
     sudo umount -R -l ${IMAGE_ROOTFS}/sys
     sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf"
+    if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
+        sudo umount -l ${IMAGE_ROOTFS}/base-apt
+        sudo rmdir ${IMAGE_ROOTFS}/base-apt
+    fi
 }
 
 python do_rootfs() {
-- 
2.16.4

Re: [PATCH] isar-image: umount base-apt when doing offline build

[Andreas Reichel]

Thanks Jan :)

-------------------------------------------------------------------
Andreas J. Reichel 
Dipl.-Phys. (Univ.)  
Software Consultant

Andreas.Reichel@tngtech.com
+49-174-3180074

TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterföhring
Geschäftsführer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Müller
Sitz: Unterföhring * Amtsgericht München * HRB 135082

----- Original Message -----
From: "jan kiszka" <jan.kiszka@siemens.com>
To: "isar-users" <isar-users@googlegroups.com>
Cc: "Andreas Reichel" <Andreas.Reichel@tngtech.com>
Sent: Thursday, November 29, 2018 3:19:01 PM
Subject: [PATCH] isar-image: umount base-apt when doing offline build

Leaving it mounted "slightly" increases the target image size.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/isar-image.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
index 7aaaecb..23b3a99 100644
--- a/meta/classes/isar-image.bbclass
+++ b/meta/classes/isar-image.bbclass
@@ -63,6 +63,10 @@ isar_image_cleanup() {
     sudo umount -l ${IMAGE_ROOTFS}/proc
     sudo umount -R -l ${IMAGE_ROOTFS}/sys
     sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf"
+    if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
+        sudo umount -l ${IMAGE_ROOTFS}/base-apt
+        sudo rmdir ${IMAGE_ROOTFS}/base-apt
+    fi
 }
 
 python do_rootfs() {
-- 
2.16.4

Re: [PATCH] isar-image: umount base-apt when doing offline build

[Jan Kiszka]

Something is still not working as expected. Patch on hold, I'm examining...

Jan

On 29.11.18 15:28, Andreas Reichel wrote:
> Thanks Jan :)
> 
> -------------------------------------------------------------------
> Andreas J. Reichel
> Dipl.-Phys. (Univ.)
> Software Consultant
> 
> Andreas.Reichel@tngtech.com
> +49-174-3180074
> 
> TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterföhring
> Geschäftsführer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Müller
> Sitz: Unterföhring * Amtsgericht München * HRB 135082
> 
> ----- Original Message -----
> From: "jan kiszka" <jan.kiszka@siemens.com>
> To: "isar-users" <isar-users@googlegroups.com>
> Cc: "Andreas Reichel" <Andreas.Reichel@tngtech.com>
> Sent: Thursday, November 29, 2018 3:19:01 PM
> Subject: [PATCH] isar-image: umount base-apt when doing offline build
> 
> Leaving it mounted "slightly" increases the target image size.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   meta/classes/isar-image.bbclass | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
> index 7aaaecb..23b3a99 100644
> --- a/meta/classes/isar-image.bbclass
> +++ b/meta/classes/isar-image.bbclass
> @@ -63,6 +63,10 @@ isar_image_cleanup() {
>       sudo umount -l ${IMAGE_ROOTFS}/proc
>       sudo umount -R -l ${IMAGE_ROOTFS}/sys
>       sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf"
> +    if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
> +        sudo umount -l ${IMAGE_ROOTFS}/base-apt
> +        sudo rmdir ${IMAGE_ROOTFS}/base-apt
> +    fi
>   }
>   
>   python do_rootfs() {
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] isar-image: umount base-apt when doing offline build

[Maxim Yu. Osipov]

On 11/29/18 5:19 PM, Jan Kiszka wrote:
> Leaving it mounted "slightly" increases the target image size.

Applied to the 'next'.

Thanks,
Maxim.

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   meta/classes/isar-image.bbclass | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
> index 7aaaecb..23b3a99 100644
> --- a/meta/classes/isar-image.bbclass
> +++ b/meta/classes/isar-image.bbclass
> @@ -63,6 +63,10 @@ isar_image_cleanup() {
>       sudo umount -l ${IMAGE_ROOTFS}/proc
>       sudo umount -R -l ${IMAGE_ROOTFS}/sys
>       sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf"
> +    if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
> +        sudo umount -l ${IMAGE_ROOTFS}/base-apt
> +        sudo rmdir ${IMAGE_ROOTFS}/base-apt
> +    fi
>   }
>   
>   python do_rootfs() {
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov