From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7101979564966936576 X-Received: by 2002:a05:6000:10a:b0:210:1aca:5c8d with SMTP id o10-20020a056000010a00b002101aca5c8dmr1058088wrx.407.1653638009377; Fri, 27 May 2022 00:53:29 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:1563:b0:210:11d0:6765 with SMTP id 3-20020a056000156300b0021011d06765ls4239285wrz.3.gmail; Fri, 27 May 2022 00:53:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwR5dn+3sOdE0NeVVT2uyZhmhvWq+VBBxhMTcpOS3aVgGJPZuQ4u0Km5qRfiJxT7G0lxGYp X-Received: by 2002:adf:da4e:0:b0:20f:ca28:27f4 with SMTP id r14-20020adfda4e000000b0020fca2827f4mr24802413wrl.75.1653638008340; Fri, 27 May 2022 00:53:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1653638008; cv=pass; d=google.com; s=arc-20160816; b=lnJ4GdnwY/bSZhEgHkLQmDEm4r9UYqHk4UXOaUDTsaglgvE+UtUlHBD2AWEcx4qICm tStPPq/FF3N37eOSoxrU6e4MmA9QAD4dvAx2OPgpHxPZA8QkAj24bR6/ZM2AEQfpYt5q 3p1p7EcqEu9xbvBS2ogfhO2tNaYKwDJPBLFFrEQWDAYJYivXzPfpBy8qYeJrwqdoG+kb h7pYvLAIliX83xVpU+x8ROIMMwnfhw4DtNsfQxWik+WdJK6CdmR/Bm4Q8HafKdG8hhzb sqKH738tvvToH9c1dLtJCeZNwkwaH//IsGDhS/G0WYCa2AAlAkiqEBtlMUxR+99PT/ha HddA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=v+aN9DA6w/qBSQQWTd7N/yYDPg4zerLSHwnedj0jBkE=; b=mnXXiYq/j7R2lAzFrUb6G6cHmXiDK/a/swQTC343S2W1MuQNbOSeQwpPX4dp+szlFg a0XfHtCllYxGUEk0okmJC7XnMbcIqCHnYiLboDu1J6uR9iDRLZlmSZ1qxTwQRjaBjtLP 5LeOaPB1WqnVUFZdogJJHiMkT6I/DyJ86VOxIj64jPbDIhEbmzjeUqUbJ2GfizeeZFvQ MM2t6GKYMynLSyQOFuUjUj/WR+ZwPLQ/3mehUVXmzOVA2K7uU2tkthpar/5B4LZWRYjD tF0Wt08u9ZRLqO9aK1U7i8pqFEqrI41cm63ZWRILunbkkNReSa8NtXQIX3lEmhzx3gCF kGsQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=S5o7vd8W; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of florian.bezdeka@siemens.com designates 2a01:111:f400:fe06::62d as permitted sender) smtp.mailfrom=florian.bezdeka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on062d.outbound.protection.outlook.com. [2a01:111:f400:fe06::62d]) by gmr-mx.google.com with ESMTPS id i7-20020a1c5407000000b0039469a105f3si50357wmb.2.2022.05.27.00.53.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 May 2022 00:53:28 -0700 (PDT) Received-SPF: pass (google.com: domain of florian.bezdeka@siemens.com designates 2a01:111:f400:fe06::62d as permitted sender) client-ip=2a01:111:f400:fe06::62d; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=S5o7vd8W; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of florian.bezdeka@siemens.com designates 2a01:111:f400:fe06::62d as permitted sender) smtp.mailfrom=florian.bezdeka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b1+w4g4BDZZ+yIMA+dFaqyZOAGoiJuEi9tMLxU+5UkTEpx32dZZwGR6+lZj56AECyE/EeuXHWclgs2x6/+kn1zEJcbqwTr4XW0FLHJA7nUSEDfm2FJ2ySBA/TguMVZ6kTILMynZr+2FA9p6Wzbdws1a4LJpfEbiyzmWAhcBcmwCnB3SvDMkugtzAOxPWKnleXKmxJPiyyVdOWPLLz2862RTpTawgxb8WPnuCL1LTHIztXcyMg1mFLADSfYkAReTajomm1AHJ2ROTviVI7vGi2yt3XCM1LLAkN5JXlUriKqHE474AXzZRKc19V+ZlqIKx+QRjWZYQuieCQ12JdwNQXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v+aN9DA6w/qBSQQWTd7N/yYDPg4zerLSHwnedj0jBkE=; b=Uqo7cKE5YM7+TyRqy6+Ulg8QSWLgXShAGCCuC55HDIHWKk+3NzXoUMCm4Gg8oYhD68MsjD+XlS6Ly7KNzmDuQP+nvDHjIabQvQK+l3MFjshQR+yIC/EfA7cCIleXzpsfKnZHjaUIMFUYf0fZLWSy5n/Fva4hz9quDnPQPIISmkYcc5zvy1StaAA9oLQnXEfi/lux2arKw3Er+ephjoxNlX/x3XdUeN6IdHrVHXWv1fKdCeifIqp4zK1+jWYKa3UqG0idEMnY+G87edrw9i7duJJkzvKlzoI2ZkWy8g1SrVUmgDwY++v6QMP5mskolzU/9wGyVGUMkn5aB3CIEbLREQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v+aN9DA6w/qBSQQWTd7N/yYDPg4zerLSHwnedj0jBkE=; b=S5o7vd8Wq87/R/0/dGLPGY3vQYMrPbndKRGt5ZUtE6db3ofN0QdxLQAFJA0c1XPRcX8XPpNsnmGvC2oBVpDO7+Gi7XuHIdMaEoeIlHYy60Rw6pBi8jhClZ1c9RcGe7w/raTIW+zyO/8aX9HQMDCbMdqXpnXf8XxnsM08lNA6WanM68Z5oP/ux2VtY9S/kvwZjoqKMnyYPqxWbotyhgQJYRMOWjjR9b67Bz15dJI5qvLvTdBBqor3sRwEZ7MoiQMrzPvRd1CFjV17z8uOiGq8xFif7O3Z7GYIOyYCo/d1n4qi2QrkXt/SIzZrfHg5V2Us4GHsmKZu05boPPN6+xNELA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:248::14) by AM9PR10MB5100.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:439::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 07:53:27 +0000 Received: from PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM ([fe80::6d73:ef73:6807:c6dd]) by PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM ([fe80::6d73:ef73:6807:c6dd%3]) with mapi id 15.20.5293.013; Fri, 27 May 2022 07:53:26 +0000 Message-ID: Date: Fri, 27 May 2022 09:53:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] utils: Ensure shell function failure in python logging is correct Content-Language: en-US To: Anton Mikanovich , isar-users@googlegroups.com References: <20220526094739.6340-1-amikan@ilbers.de> From: Florian Bezdeka In-Reply-To: <20220526094739.6340-1-amikan@ilbers.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1P194CA0011.EURP194.PROD.OUTLOOK.COM (2603:10a6:800:be::21) To PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:248::14) Return-Path: florian.bezdeka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a5c652b-e47a-4be9-4947-08da3fb5fb6d X-MS-TrafficTypeDiagnostic: AM9PR10MB5100:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YLliaGHpNert/X2OipvQ3Ki4/6wNhZg60eZGIyklLv3qMRDdbFDnYx5bj0hbes6BJAe4sS+IqX6P7yd088Z6YQWbIDke5q0vGjhA/eSyFZo9nV+HkE2kBeHxBSmmEGgiacJs4C2qabSSh3wBV444HByMX/s8DscaEuUYe3+TwnA5Hrwu6QTUjXFs+O/KCXbWjQN13vGGT7N+ypqD60h/24nNYgj4HqxaAl0v3Nvw4H6N9exM8JcIHdvKVkJX4wVJ70LM2YOiLfAcHa1swJsxxqNVjL4XDiCi7cMNzeRq6q0uEusHk5UP+eu01xsInoQD628EDFuccgtjWMXdCC8T8SxjZObWchlHvzz1S/jmcvEQBdzTejt6K6PnGxjPOhs08y3pr7jfx3+qoVP/h71gjbEdvYInfRacOjrO+kmV1OlCS6gA6ORCZawzfbdGeJkG/uNW2bPaZz5FIRyYCP4ZLFlz3u1ImgCbai7EnxqfzKe36GeJb1NCarMRJJdwqIolss1SLdcoYsTuH0FwTE8IB/ULImwvsvjjtlcmdW/hw7CnNNGUgDm6BfQhcqZ9/vXS0BZhro58cpw900GjXYG3q+qrDAmwkPjHKgOW1/POY4AjsJvX2E2NeIc8rnfOCisIp9F0LZTJ/JeudHofbSoPMynVoFAz7DyzalsWSsuY0szfIz1WoDBjCF7sEnOQUrDFixDY7RNaU0oJ2oApzbR9yfjwbYAsYNBqzNFuVm0LXFMzN2CoTjWWFrgiWtQdUbxvB5x3pzyXAZY9WL6yR8EtE7CVT97qNCUhliBtAWTN1mFmqpDbNcJSKiDe1GVMhLCi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(38100700002)(5660300002)(66476007)(66556008)(66946007)(86362001)(31696002)(508600001)(6512007)(6506007)(6486002)(8676002)(966005)(8936002)(44832011)(82960400001)(2906002)(53546011)(83380400001)(2616005)(316002)(36756003)(186003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3Z2dWhORFVFd2RQT2sxa3kwUHZGNTZCbkJ1anZ3TVJFRGo3YTdXbmh1b0RM?= =?utf-8?B?K2NLZE9tdmw3UEFaTmRPRkhlamY4R0ZtWWlKSlplTjNDSHA0SjdmTGR6RStk?= =?utf-8?B?VTVwMmIzM3JkenFaWDRMMEk1MkZQdHB1YmkwK2hLWnVlNndFZlpJYm9aYzJM?= =?utf-8?B?dk1RekQvM0g0R2x0OEUyWEJXQVNiNk94Q0ZYUHNVU3B5eHlJbmYrSk9nTWk0?= =?utf-8?B?YUFYdkV0Z3Ava1B5akVSa2Vib2FMcDJtQ01sWHcvUCtNcWZ5UCtuWlk2dzh1?= =?utf-8?B?eGxyaUNMVDA2Uno3eG1qTktWb0dOTEpxT0FsOExCbW1VcGdjbFBUVmhYcjMv?= =?utf-8?B?cEZWempDRk1YdXNnYjdMUFdpcW52SGx6bStvQm04U1hoQTYyendWS0RGM08z?= =?utf-8?B?UHpyV0pIUmcwSno4S1U4NDNTWkM0UER0MzlFWm02elR1Vmp0OVFjOGxWM1g2?= =?utf-8?B?OUtmNkUvbEp3cDhBTVlITko3Ky9JMUQxK3NXaG1sSVY5clFxSWhVTUsyWGl5?= =?utf-8?B?RnNiU3VRZlVONUxseVN1RGp0bVBUZEsvUTZSaml5dHNTVlQ3UmNhMnpQUkJO?= =?utf-8?B?SUJWTjN5dzNSRmZrOTA2cWhoVWJpa3NEZ2w4TnFUazYrcHZyVVdZTWEyVUUw?= =?utf-8?B?cklmTEFlRkpuVjJJNXlDUlpNQUVsTHlMRkVYMllBNUFUK29jZFdVQmY1R3Fq?= =?utf-8?B?RjR5UFlsQXdXdTB4ODdGbWxnRUNhRFd6b2hnUjBmMnBzbVdmd1VXMHJVcVNo?= =?utf-8?B?ZVl2bXM3M1NQQVo4Rm56N0hJc2g2YUZIR29BeU04dmZIcmJ2S0FIVnBiZk53?= =?utf-8?B?UUx2cm1KYjJ0bExFMzgxdFZscEI1ZjJNZHpMQ1JSWmlWdXhBQ2o0NXpPYy9D?= =?utf-8?B?U3VzS21ldkdGUHNQcmpFcStkSVF6cXlzZVBuUGswRU1VNXJ6MDJlNFlySXJM?= =?utf-8?B?c1lnZ1VHWUNFOXJERGxGQWR6VS9pcDNIa3pOTUhzVCs4RXp1VUFZNjVaQTFD?= =?utf-8?B?YVNxcklyMHJWSVQ0RVo4Y21aSnhuNjQxYytvMHdqOGxsbG9wNzdKVTlsZUEy?= =?utf-8?B?Z2ZuRXh1Ry80dkdGbGtSc2wycnljQlhpelZMYnhxOU8rZUVUT3FHM3Zha0xX?= =?utf-8?B?SG45Sk9PSjRnckJJS0RVd0pORTZBZU43NXpxZ1BTMk1sRGM5QXVFZ2NLRkY4?= =?utf-8?B?cSs0OFpqTW1jL2xSa0oxbVJlU2RIdlcvSm5JcGRTbk5hN0NFd0YxQURUeENJ?= =?utf-8?B?VS82LzJ0NHhaVmlrVUhWVS9xaCtUVU5DNFNobUlrREJzK1lteURLUkhoUXdH?= =?utf-8?B?RlYxYzJYRlBQT3ZYMzJiUC83b2JYQmFOT3Y1eFNrOHVsSUNwUHk2cm55SUJY?= =?utf-8?B?M2Q3UnNkT1FiTWJ5NzB0cmhxajJOeFRYcWFDME5KcFB4U2hQeXdUVHJ1MXp0?= =?utf-8?B?WDFLN21yblpDR014bEdJazVlQUExbGd3b3dGZ0VoaFVaSk0vWG1XUC9MN1dL?= =?utf-8?B?bFNOOGVRbSsvM1d2a29kWTZpZXQvbU91TmQxeC94Q3A1eVg3R0RnYnVRbjJz?= =?utf-8?B?dFpkTnZIUHdPZE9QaHNLME1IVndzWTR2ZXJrQm1FSDhweEZvYVgzVzNIOHNs?= =?utf-8?B?YXFaemxKZnp4TTA5T3F2bitKcGtTaGNlYkNLVE9tZ05PZDBtblJXZ25EMGF2?= =?utf-8?B?S1NUZHRBQ2xta3BJc3dVT2NIUDFYTStnS0ltaW5MdE9Bb0FJTkk3eTVaMld0?= =?utf-8?B?cEVtRnZUam9GaHVkNVNtK3N3MGsrcmRxdzBnUEh2aXhJajRFa0Z2b2R0SFBX?= =?utf-8?B?V1hHUUZCejh6dUQrTk8vb3kwUmZPd3EvTWd4VktId0pzVnpHQnNuTkVuNzA4?= =?utf-8?B?ejJuOWJ4NWNndk11b0g1cG96TzdxRnVNMlE1T2R5aS9RLzBXQ3BOSE03YjlH?= =?utf-8?B?UHhtV1BJSlplSWNyZDQxQmU4MXlITnhGNlFSTWtqQWVjTXhZZXJsYm53bGdu?= =?utf-8?B?ZXZndTkxTTJ5aUxKOXJDRzRhRTlZbUZ4TzRtQ3ZrTEEyS09hUGt5K0dmWW1v?= =?utf-8?B?dStiRHJCMmRSbGhQWE9YUWZWUmdZNjNiVVlXTEg2c0pDaXJpVkpIai9PUnB2?= =?utf-8?B?QmFtdnlBdDlFRnpjelBRdGlET3dDRnFlOERKM21pNXlFUGI3T3h6WGV5aUp1?= =?utf-8?B?LzBoK0xmOW9XWFRTcCtCVHZwcWZwdnpCK2w0QTkzZ0xmcVRBc2hsczVrK1Bk?= =?utf-8?B?Q3BuWkovT2FnTlBPNU9ZRGN1STZVT2EvbXNncWtBYTQvTnFuSjhzVkZ0R2ZB?= =?utf-8?B?dTl5dGNtTHhLYTVFSit1TnVSRkY2UjExWGN4c3JObDYySDJJYUZQUit2Z1Na?= =?utf-8?Q?jWYZonZpf16SWhNQOgi8ktdvfKs3kRIqU52h4cAYH0odt?= X-MS-Exchange-AntiSpam-MessageData-1: OTHOibcndhG5IZPiFKw/TdozNch3dOgaVh0= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a5c652b-e47a-4be9-4947-08da3fb5fb6d X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB5712.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 07:53:26.7626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mRTXNDnMQOZjcVdWmya3PUB4yiydgtrrocw2fr4NoPao5aUkFLWD/eLPW81iDdYdO7kmzWEJsRzqpldVh9MSWEbBjjdeSpNLq8xbs03tl24= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR10MB5100 X-TUID: PehAZ3Wnc5hZ On 26.05.22 11:47, Anton Mikanovich wrote: > If a python function exec_func() calls a shell task, the logging wasn't working > correctly in all cases since the exception was turned into a BBHandledException() > and the logfile piece was lost which is handled at the top task level. > > The easiest way to avoid this is to allow the ExecutionError exceptions to > be raised to a higher level, we don't need the traceback for them. Upstream first? Why can't we ask bitbake guys to do the backport and lift our bitbake version afterwards? Is that already ongoing? > > Backported from Bitbake 2.0 upstream branch: > https://git.openembedded.org/bitbake/commit/?id=7cae11f558f9ff5fd05ef23b789aaef92fb5a327 > > Signed-off-by: Anton Mikanovich > --- > bitbake/lib/bb/utils.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py > index 2a150fe..74cbc69 100644 > --- a/bitbake/lib/bb/utils.py > +++ b/bitbake/lib/bb/utils.py > @@ -401,7 +401,7 @@ def better_exec(code, context, text = None, realfile = "", pythonexception > code = better_compile(code, realfile, realfile) > try: > exec(code, get_context(), context) > - except (bb.BBHandledException, bb.parse.SkipRecipe, bb.data_smart.ExpansionError): > + except (bb.BBHandledException, bb.parse.SkipRecipe, bb.data_smart.ExpansionError, bb.process.ExecutionError): > # Error already shown so passthrough, no need for traceback > raise > except Exception as e: