isar-bootstrap fails to rebuild after config changes

[Jan Kiszka <jan.kiszka@siemens.com>]

Hi,

I noticed today that I'm not getting a new bootstrap rootfs after adding a repo 
to DISTRO_APT_SOURCES. Digging deeper, this revealed missing STAMPCLEAN setting, 
but also more:

Why are we probing for the existence of the DEPLOY_ISAR_BOOTSTRAP link in 
do_apt_config_prepare(), Claudius? This obviously exists after a first run, and 
that blocks refreshing all the apt settings if they have changed.

There is CLEANFUNCS set with clean_deploy(), but that is only run on true 
do_clean(), not on rebuilds.

And finally, when I look at isar_bootstrap(), run by do_bootstrap(), it protects 
checking and creating DEPLOY_ISAR_BOOTSTRAP with a lock. But 
do_apt_config_prepare() runs lockless. This cannot work reliably.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux