From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6605860083084558336 X-Received: by 2002:a2e:b018:: with SMTP id y24-v6mr285561ljk.15.1538046963783; Thu, 27 Sep 2018 04:16:03 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:d050:: with SMTP id h77-v6ls379190lfg.26.gmail; Thu, 27 Sep 2018 04:16:03 -0700 (PDT) X-Google-Smtp-Source: ACcGV61HCM58GdoohJ6qPc19xjThxpkiHObx9BC4cu89OyKF04eD23CV1bdDTNjtjEpZMIS8Z+M5 X-Received: by 2002:a19:d2d1:: with SMTP id j200-v6mr326340lfg.5.1538046963168; Thu, 27 Sep 2018 04:16:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538046963; cv=none; d=google.com; s=arc-20160816; b=ty1PJBmWE6SXqQN1PZOGM4pAJXG6C1zDxT9U7WHBdfGoh/+u8YBR0AmzaXanuRcAWg itl8u16ami4/OJr2cAlqzbFqrw982ACCmC4ZyrQ77sjk9j/gBDth/MoV1fexb9j1nPH2 zsGO1e6hogj824yRy9R0zNn/17wMokX574JINC3YfjW4tepVbWxtYeJcjWvr+SwinzeX Hj22cYnrET/NP+euJKDe0FVHDBWbn0waJ/wWKjSnCZZRlzKOGfNDzJ3Q0LAqTgU1ZcN8 s1gt7wG2acJ7TD67TSAGe9iqeDnbgmvKM1ogtjOrWAgCVd6PCOTfeTEfnv3N6c0AvSkK QISg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=de33Mu8htfVi1GHT9HcKtX5RaoLiFEgzq6upO43I1Zw=; b=iuyGHMzKqqnBT3YHXnXXD/jjMUoycbvI99VEEGk/jNkpeC8Or/nJ2BnlpkhEQjKELD XvUt0xpfAZYhvV2uOfctzUprHPnetfsuFEVrkigWVieyTcjS35FjUXa9wlFogEjESqTB kxrja6oQOWstao6zsuVRHeTzrIJZ/5GiPjyzhlETHrqUaDM8Qi+JgTezqiXF/kxuGH6Y 3l8/lNlTfNKRziyeR/uKWPAwcOGCV1M2AncqjIzKDhzGwvdmjU7QIh8c4KqhOdMMVs0l KlZ15d3VtusUrD6Ljcndz4kMf9QZHEL9GmljCRCkcTI0lwfADjtxT9i0BSFNgUwGdhZ3 az2w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id f20-v6si100658lja.1.2018.09.27.04.16.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Sep 2018 04:16:03 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id w8RBG23Q013632 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Sep 2018 13:16:02 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w8RBG2l4017808; Thu, 27 Sep 2018 13:16:02 +0200 Subject: Re: [PATCH 2/2] sdk: Check if directories are mounted before unmounting To: "Maxim Yu. Osipov" , isar-users@googlegroups.com References: <20180927111039.16872-1-mosipov@ilbers.de> <20180927111039.16872-3-mosipov@ilbers.de> From: Jan Kiszka Message-ID: Date: Thu, 27 Sep 2018 13:16:01 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180927111039.16872-3-mosipov@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 9C1r2IH8T4j8 ...because it generates an error otherwise? On 27.09.18 13:10, Maxim Yu. Osipov wrote: > Signed-off-by: Maxim Yu. Osipov > --- > meta/classes/image.bbclass | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 1db2394..3206877 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -98,6 +98,16 @@ addtask copy_boot_files before do_build after do_rootfs > do_copy_boot_files[dirs] = "${DEPLOY_DIR_IMAGE}" > do_copy_boot_files[stamp-extra-info] = "${DISTRO}-${MACHINE}" > > +is_mounted() { > + dir_dev=`stat -c '%D' "$1"` > + parent_dev=`stat -c '%D' "$1/.."` > + if [ $dir_dev != $parent_dev ]; then > + return 0 > + else > + return 1 > + fi > +} > + > SDKCHROOT_DIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/sdkchroot-${HOST_DISTRO}-${HOST_ARCH}" > > do_populate_sdk() { > @@ -107,8 +117,10 @@ do_populate_sdk() { > # Purge apt cache to make image slimmer > sudo rm -rf ${SDKCHROOT_DIR}/rootfs/var/cache/apt/* > > + is_mounted ${SDKCHROOT_DIR}/rootfs/dev && sudo umount ${SDKCHROOT_DIR}/rootfs/dev > + is_mounted ${SDKCHROOT_DIR}/rootfs/proc && sudo umount ${SDKCHROOT_DIR}/rootfs/proc > + > # Create SDK archive > - sudo umount ${SDKCHROOT_DIR}/rootfs/dev ${SDKCHROOT_DIR}/rootfs/proc Wouldn't it suffice to append "|| true" then? Jan > sudo tar -C ${SDKCHROOT_DIR} --transform="s|^rootfs|sdk-${DISTRO}-${DISTRO_ARCH}|" \ > -c rootfs | xz -T0 > ${DEPLOY_DIR_IMAGE}/sdk-${DISTRO}-${DISTRO_ARCH}.tar.xz > > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux