public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH 3/4] sdk: Control isar-apt list removing
Date: Thu, 7 Dec 2023 09:55:44 +0900	[thread overview]
Message-ID: <fae5c518-5d93-409b-be7c-0d95be02cd49@siemens.com> (raw)
In-Reply-To: <20231206121233.35963-4-amikan@ilbers.de>

On 06.12.23 20:12, Anton Mikanovich wrote:
> Do not remove isar-apt.list in case SDK_INCLUDE_ISAR_APT enabled.
> 

This says what it does, not why.

Does that isar-apt list really make any sense outside of the build
environment?

Jan

> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/sdk.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> index e76f7930..52c3bec5 100644
> --- a/meta/classes/sdk.bbclass
> +++ b/meta/classes/sdk.bbclass
> @@ -68,6 +68,8 @@ SDKROOTFSVARDEPS = ""
>  SDKROOTFSVARDEPS:class-sdk = "SDK_INCLUDE_ISAR_APT"
>  do_rootfs_install[vardeps] += "${SDKROOTFSVARDEPS}"
>  
> +ROOTFS_POSTPROCESS_COMMAND:remove = "${@'rootfs_cleanup_isar_apt' if d.getVar('SDK_INCLUDE_ISAR_APT') == '1' else ''}"
> +
>  # additional SDK steps
>  ROOTFS_CONFIGURE_COMMAND:append:class-sdk = " ${@'rootfs_configure_isar_apt_dir' if d.getVar('SDK_INCLUDE_ISAR_APT') == '1' else ''}"
>  rootfs_configure_isar_apt_dir() {

-- 
Siemens AG, Technology
Linux Expert Center


  reply	other threads:[~2023-12-07  0:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 12:12 [PATCH 0/4] Fixing isar-apt usage inside SDK Anton Mikanovich
2023-12-06 12:12 ` [PATCH 1/4] rootfs: Split isar-apt and base-apt cleanup Anton Mikanovich
2023-12-06 12:12 ` [PATCH 2/4] sdk: Remove duplicated isar-apt cleanup Anton Mikanovich
2023-12-06 12:12 ` [PATCH 3/4] sdk: Control isar-apt list removing Anton Mikanovich
2023-12-07  0:55   ` Jan Kiszka [this message]
2023-12-07 15:46     ` Baurzhan Ismagulov
2023-12-06 12:12 ` [PATCH 4/4] doc/user_manual.md: Improve SDK usage howto Anton Mikanovich
     [not found] <56da6ebc-d264-4cb8-86f9-8b53cbe1212c@ilbers.de>
2023-12-07 15:30 ` [PATCH 3/4] sdk: Control isar-apt list removing Anton Mikanovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fae5c518-5d93-409b-be7c-0d95be02cd49@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox