From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6514902455461871616 X-Received: by 10.157.37.35 with SMTP id k32mr131088otb.73.1518087647437; Thu, 08 Feb 2018 03:00:47 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.202.169.75 with SMTP id s72ls469838oie.2.gmail; Thu, 08 Feb 2018 03:00:47 -0800 (PST) X-Google-Smtp-Source: AH8x225qTekTgKwLGOVm4nqSF4P3IkffNPzFXpMgyOb3grofeFKkdbSOFjnB4g+MuwaZqed3dqk2 X-Received: by 10.202.216.133 with SMTP id p127mr114414oig.19.1518087647026; Thu, 08 Feb 2018 03:00:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518087646; cv=none; d=google.com; s=arc-20160816; b=QXjVCw3z3yaW9a3BlZU7N/rvkZXEcJXNMJ+zwBObcEgg9yp2EoHaY9w9OwwkiiPFOr zQDC59ni0SHZxkjoQ1kFaDasIC+MSPi+GxI0P5IrWmcBhbPlT1c4hky6xMxz9ECqOU1d 5TcsaWPCPa3TwmgQe6nA6hypxTClA7iTWIHucCRytnyuR7kJAh12ZPvBfuDvn9xa/+bv MyIJSN3tS1zZwALwcIf8OioemA5tecRgm7qoV1oCiOm4RmkDMtjrshEtxPUJ62tH/Poa O6oJsmyj3MgK7oHy89vcxZMrwO/yIISHkCVkcykokGoN08qwBMwilSjYXECqy/Mcak06 uH7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=7jLRy2/yqoN8pCnILS3QnyVAskvDHnNlJv67Cy03R/4=; b=uNMXmu46gk4Hcy4cfCASqtQsPIneqoBqoVrnD3D/hIMYi18gb5ToGr0FGVV3JfBl9C HWARSEs0NKhgMFczTbp0ASR3GGSfMnseJ9csVQL+m+ApdiIryoyUwXIihK/2QoqtvkB5 x6swHDP6flB9kisw10FBYBMOIDejBVuHvhIfmEFEIErsDNMWispIBb4fr+n4fD0MLtx6 Dx5U/BG9RWGunXkLN62fSetiH2Ge5RSJtTxJA+Ohw/sxHrjVnhcKzIrk7Q1gXTaiKjto Odfvs+0fwSpXt8VA7rX+TBOlzFaXKzQNUoeE2eAApOEsZAVN0+MxUGpjbhGc9ZefhGGv raWA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id 16si223236oiq.3.2018.02.08.03.00.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 03:00:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w18B0g0Z030718 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Thu, 8 Feb 2018 12:00:44 +0100 Subject: Re: [PATCH v2][libhello] libhello: First implementation To: isar-users@googlegroups.com References: <20180208100341.32297-1-asmirnov@ilbers.de> <20180208104226.GB6137@yssyq.radix50.net> From: Alexander Smirnov Message-ID: Date: Thu, 8 Feb 2018 14:00:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180208104226.GB6137@yssyq.radix50.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: nyIJVaeulvM7 On 02/08/2018 01:42 PM, Baurzhan Ismagulov wrote: > On Thu, Feb 08, 2018 at 01:03:41PM +0300, Alexander Smirnov wrote: >> diff --git a/Makefile.am b/Makefile.am > ... >> +man1_MANS = libhello.3 > ... >> +clean-local: >> + $(RM) -f $(man1_MANS) > > I'd suggest man3_MANS. > Ok. > >> diff --git a/debian/control b/debian/control > ... >> +Build-Depends: debhelper (>= 9), autotools-dev, docbook-to-man > > You've removed autotools-dev from hello, so I assume it works with Isar. Any > reason to keep it here? > > I'd suggest dropping it from here and providing a patch removing the autotools > timestamp hack below. Could you please report whether that works? The last > time, ten attempts were enough to trigger the re-generation problem. > > https://github.com/ilbers/isar/blob/2d56fc1242ef3e3041eb248942324eb67e9b1319/meta/recipes-devtools/buildchroot/files/build.sh#L17 > Aghr, forgot to 'git add' this file. > >> diff --git a/debian/libhello-dev.install b/debian/libhello-dev.install > ... >> +usr/lib/*/libhello.a >> +usr/lib/*/libhello.la > ... >> diff --git a/debian/libhello.install b/debian/libhello.install > ... >> +usr/lib/*/libhello.so* > > In which directory are those installed? > /usr/lib/${TOOLCHAIN}/libhello* > >> diff --git a/libhello.sgml b/libhello.sgml > ... >> + EXIT STATUS > > Suggest "RETURN VALUE". Ok. > > > Otherwise, Acked-by: Baurzhan Ismagulov . > Thanks! Alex