public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Stefan Koch <stefan-koch@siemens.com>,
	Cedric Hombourger <cedric.hombourger@siemens.com>,
	Florian Bezdeka <florian.bezdeka@siemens.com>,
	Clara Kowalsky <clara.kowalsky@siemens.com>
Subject: [PATCH 1/2] linux-custom: Drop redundant setting of CROSS_COMPILE
Date: Mon, 28 Oct 2024 12:13:23 +0100	[thread overview]
Message-ID: <fb54ef19d4c385a226f583866856eb021cc70bd9.1730114004.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1730114004.git.jan.kiszka@siemens.com>

From: Jan Kiszka <jan.kiszka@siemens.com>

Since ac2bbd7ca249, we set CROSS_COMPILE in isar/common[.tmpl] if
needed. As this is run before every target, we can drop initialization
in the rules file.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/recipes-kernel/linux/files/debian/isar/common.tmpl | 2 +-
 meta/recipes-kernel/linux/files/debian/rules.tmpl       | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/meta/recipes-kernel/linux/files/debian/isar/common.tmpl b/meta/recipes-kernel/linux/files/debian/isar/common.tmpl
index def8480e..5ba11289 100644
--- a/meta/recipes-kernel/linux/files/debian/isar/common.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/isar/common.tmpl
@@ -51,7 +51,7 @@ main() {
     done
 
     # variables to be exported
-    export ARCH
+    export ARCH CROSS_COMPILE
 
     # are we cross-compiling?
     BUILD_ARCH=$(dpkg-architecture -qDEB_BUILD_ARCH)
diff --git a/meta/recipes-kernel/linux/files/debian/rules.tmpl b/meta/recipes-kernel/linux/files/debian/rules.tmpl
index e8ae3daa..598ae93f 100755
--- a/meta/recipes-kernel/linux/files/debian/rules.tmpl
+++ b/meta/recipes-kernel/linux/files/debian/rules.tmpl
@@ -1,7 +1,5 @@
 #!/usr/bin/make -f
 
-CROSS_COMPILE:=$(DEB_HOST_GNU_TYPE)-
-
 MAINTAINER := $(shell sed -ne 's,^Maintainer: .[^<]*<\([^>]*\)>,\1,p' debian/control)
 DISTRIBUTOR := ${DISTRIBUTOR}
 SOURCE_DATE := $(shell dpkg-parsechangelog -SDate)
@@ -13,7 +11,6 @@ deb_top_dir:=$(S)/debian
 
 # Dynamic variables to be passed to Isar build scripts
 isar_env=$(strip \
-	export CROSS_COMPILE='$(CROSS_COMPILE)' && \
 	export DEB_BUILD_PROFILES='$(DEB_BUILD_PROFILES)' && \
 	export DEB_HOST_GNU_TYPE='$(DEB_HOST_GNU_TYPE)' && \
 	export MAKE='$(MAKE)' && \
-- 
2.43.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/fb54ef19d4c385a226f583866856eb021cc70bd9.1730114004.git.jan.kiszka%40siemens.com.

  reply	other threads:[~2024-10-28 11:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 11:13 [PATCH 0/2] linux-custom: Enable compat vDSO support for arm64, clean up rules 'Jan Kiszka' via isar-users
2024-10-28 11:13 ` 'Jan Kiszka' via isar-users [this message]
2024-10-28 11:13 ` [PATCH 2/2] linux-custom: Add support for arm64 compat vDSO 'Jan Kiszka' via isar-users
2024-11-04 13:54 ` [PATCH 0/2] linux-custom: Enable compat vDSO support for arm64, clean up rules Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb54ef19d4c385a226f583866856eb021cc70bd9.1730114004.git.jan.kiszka@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=clara.kowalsky@siemens.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=stefan-koch@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox