Re: [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe

[Claudius Heine <claudius.heine.ext@siemens.com>]

ping

On 28/03/2019 08.50, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> In machines that have not set those variables, it is still possible that
> those classes are parsed. The parsing itself should not fail in that
> case, instead those recipes should just be skipped.
> 
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>   meta/classes/ubi-img.bbclass   | 2 +-
>   meta/classes/ubifs-img.bbclass | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass
> index f61a940..777b8c4 100644
> --- a/meta/classes/ubi-img.bbclass
> +++ b/meta/classes/ubi-img.bbclass
> @@ -5,7 +5,7 @@
>   
>   python() {
>       if not d.getVar("UBINIZE_ARGS"):
> -        bb.fatal("UBINIZE_ARGS must be set")
> +        raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set")
>   }
>   
>   UBINIZE_CFG ??= "ubinize.cfg"
> diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass
> index ed37357..881d2bb 100644
> --- a/meta/classes/ubifs-img.bbclass
> +++ b/meta/classes/ubifs-img.bbclass
> @@ -5,7 +5,7 @@
>   
>   python() {
>       if not d.getVar("MKUBIFS_ARGS"):
> -        bb.fatal("MKUBIFS_ARGS must be set")
> +        raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set")
>   }
>   
>   inherit image
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de