From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6673096226406137856 X-Received: by 2002:ac2:4214:: with SMTP id y20mr16080868lfh.75.1556095703794; Wed, 24 Apr 2019 01:48:23 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:f249:: with SMTP id d9ls1486499lfk.13.gmail; Wed, 24 Apr 2019 01:48:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqyR41rj2nY+88uZueillsoTQOqii7ETr0MQvOS1ymD8n2b8zdJKu07XIUm0foglU32RHbE0 X-Received: by 2002:ac2:4192:: with SMTP id z18mr15084247lfh.96.1556095703259; Wed, 24 Apr 2019 01:48:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556095703; cv=none; d=google.com; s=arc-20160816; b=J3PHC3XVyry+VgWw/Jp70DCkeVn6eWKe3wvxixnZLxtyg0O0nkDauN5574NBqxJ9k0 9tQegNwo4jF7YjF47D+q4r2tySwJ/gGwZqEj36r2sYq2wZszf9YqD+Ndf872iFyq0UN1 F4+jopqpWrHHZRph6dxk8oyMUI0N3UKS8oib3KBvywJTDcMoivLtu6G8/Xh+C8CBh3iN l82Mpam2yGZEyXVAvRJyJO5Ms60Ye6rmMVlohu2FwDll5POZZDGYM7Uq/2DwL2gHmD/1 qx6S6xUt52/Bht3LyHHPMU0UagCR4Fi88BrLtaMCFyHdn+7KQ70a+3LfbntF/giUiQtP A3og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:cc:to:from:subject; bh=kvARll1Q7HJSj1GfLGg6MXSU9WXyRKgoLZSWe1nwf18=; b=bQn5j/IYuC9yeSa5ecgUoWplI0fuKGl4olNX2dIK2jP5Ea74XIJju14SsoqdiU/hQx 6HGseN7YrejI4+nvH0qm0TBScnRIt/JMpFaSA4witLlJOrY4UOBJCAnCykS0uLQMJG/2 uPukvf0eBlJK/BgbTbiSe4Z412W3ua84+5ZJAHijg4JXPSjvHv7HJQmpbYoks60u96T/ R9RkXYmXoWbV4yJyAPfBfVUVkYFeT8zsq37XoXH+vZcTihBbOeszt1NpOs2Ib+Vx9KKP uBY06M1B8pmJKBkmZE+d1mkGjMdBnO9fGdeQAtIIfJQeD28mp+3G8xyT1K0SVTu/G8HU S6Mw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id v89si823202lje.4.2019.04.24.01.48.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 01:48:23 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x3O8mM29004832 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2019 10:48:22 +0200 Received: from [139.25.69.232] (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x3O8mLOt020709; Wed, 24 Apr 2019 10:48:22 +0200 Subject: Re: [PATCH v2] ubi-img/ubifs-img: change fatal error to skip recipe From: Claudius Heine To: isar-users@googlegroups.com Cc: Claudius Heine References: <20190327154124.14663-1-claudius.heine.ext@siemens.com> <20190328075022.29511-1-claudius.heine.ext@siemens.com> Message-ID: Date: Wed, 24 Apr 2019 10:48:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190328075022.29511-1-claudius.heine.ext@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: OX+S7OL187V8 ping On 28/03/2019 08.50, [ext] claudius.heine.ext@siemens.com wrote: > From: Claudius Heine > > In machines that have not set those variables, it is still possible that > those classes are parsed. The parsing itself should not fail in that > case, instead those recipes should just be skipped. > > Signed-off-by: Claudius Heine > --- > meta/classes/ubi-img.bbclass | 2 +- > meta/classes/ubifs-img.bbclass | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/ubi-img.bbclass b/meta/classes/ubi-img.bbclass > index f61a940..777b8c4 100644 > --- a/meta/classes/ubi-img.bbclass > +++ b/meta/classes/ubi-img.bbclass > @@ -5,7 +5,7 @@ > > python() { > if not d.getVar("UBINIZE_ARGS"): > - bb.fatal("UBINIZE_ARGS must be set") > + raise bb.parse.SkipRecipe("UBINIZE_ARGS must be set") > } > > UBINIZE_CFG ??= "ubinize.cfg" > diff --git a/meta/classes/ubifs-img.bbclass b/meta/classes/ubifs-img.bbclass > index ed37357..881d2bb 100644 > --- a/meta/classes/ubifs-img.bbclass > +++ b/meta/classes/ubifs-img.bbclass > @@ -5,7 +5,7 @@ > > python() { > if not d.getVar("MKUBIFS_ARGS"): > - bb.fatal("MKUBIFS_ARGS must be set") > + raise bb.parse.SkipRecipe("MKUBIFS_ARGS must be set") > } > > inherit image > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de