From: Uladzimir Bely <ubely@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCH 03/13] kas: Add dependencies between machine and distro configuration
Date: Tue, 19 Sep 2023 09:30:11 +0300 [thread overview]
Message-ID: <fc345b9af432ac2c859e0e7b547ea2e469423687.camel@ilbers.de> (raw)
In-Reply-To: <807157e6-fa63-4bcf-aa68-a34bb43fa799@siemens.com>
On Sat, 2023-09-16 at 15:04 +0530, Jan Kiszka wrote:
> On 15.09.23 12:14, Uladzimir Bely wrote:
> > Isar can't build any combination of supported machines and distros.
> > For the specific machine, only a limited set of distros can be
> > built.
> >
> > This patch adds required dependencies between these configruations
> > so that user could not select unsupported (untested) on from menu.
> >
>
> Why not let the machine depend on those distros they support? Would
> save
> your from adding those DEP_* configs.
>
> Jan
>
My initial idea was just to allow user to select a target machine first
(for example, Raspberry) and only after that choose a supported distro.
Tried your proposal. It looks much cleaner and also works, but may
confuse the user a bit since they may not find required target until
"proper" distro selected.
> > Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> > ---
> > kas/distro/Kconfig | 28 ++++++++++++++++++++++++++
> > kas/machine/Kconfig | 49
> > +++++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 77 insertions(+)
> >
> > diff --git a/kas/distro/Kconfig b/kas/distro/Kconfig
> > index 0bb58c87..4453a3df 100644
> > --- a/kas/distro/Kconfig
> > +++ b/kas/distro/Kconfig
> > @@ -6,27 +6,55 @@ choice
> >
> > config DEBIAN_BUSTER
> > bool "Debian Buster (10)"
> > + depends on DEP_DEBIAN_BUSTER
> >
> > config DEBIAN_BULLSEYE
> > bool "Debian Bullseye (11)"
> > + depends on DEP_DEBIAN_BULLSEYE
> >
> > config DEBIAN_BOOKWORM
> > bool "Debian Bookworm (12)"
> > + depends on DEP_DEBIAN_BOOKWORM
> >
> > config DEBIAN_SID_PORTS
> > bool "Debian Sid (unstable) with unofficial ports"
> > + depends on DEP_DEBIAN_SID_PORTS
> >
> > config RASPIOS_BULLSEYE
> > bool "Raspi OS Bullseye (11)"
> > + depends on DEP_RASPIOS_BULLSEYE
> >
> > config UBUNTU_FOCAL
> > bool "Ubuntu Focal (20.04)"
> > + depends on DEP_UBUNTU_FOCAL
> >
> > config UBUNTU_JAMMY
> > bool "Ubuntu Jammy (22.04)"
> > + depends on DEP_UBUNTU_JAMMY
> >
> > endchoice
> >
> > +config DEP_DEBIAN_BUSTER
> > + bool
> > +
> > +config DEP_DEBIAN_BULLSEYE
> > + bool
> > +
> > +config DEP_DEBIAN_BOOKWORM
> > + bool
> > +
> > +config DEP_DEBIAN_SID_PORTS
> > + bool
> > +
> > +config DEP_RASPIOS_BULLSEYE
> > + bool
> > +
> > +config DEP_UBUNTU_FOCAL
> > + bool
> > +
> > +config DEP_UBUNTU_JAMMY
> > + bool
> > +
> > config KAS_INCLUDE_DISTRO
> > string
> > default "kas/distro/debian-buster.yml" if DEBIAN_BUSTER
> > diff --git a/kas/machine/Kconfig b/kas/machine/Kconfig
> > index 7989a362..4a713c29 100644
> > --- a/kas/machine/Kconfig
> > +++ b/kas/machine/Kconfig
> > @@ -6,69 +6,118 @@ choice
> >
> > config MACHINE_BANANAPI
> > bool "bananapi"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_CONTAINER_AMD64
> > bool "container-amd64"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_DE0_NANO_SOC
> > bool "de0-nano-soc"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_HIKEY
> > bool "hikey"
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_IMX6_SABRELITE
> > bool "imx6-sabrelite"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_IMX6_NANOPI_NEO
> > bool "nanopi-neo"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_PHIBOARD_MIRA
> > bool "phyboard-mira"
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_QEMU_AMD64_SB
> > bool "qemuamd64-sb"
> > + select DEP_DEBIAN_BULLSEYE
> >
> > config MACHINE_QEMU_AMD64
> > bool "qemuamd64"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> > + select DEP_UBUNTU_FOCAL
> > + select DEP_UBUNTU_JAMMY
> >
> > config MACHINE_QEMU_ARM
> > bool "qemuarm"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_QEMU_ARM64
> > bool "qemuarm64"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> > + select DEP_UBUNTU_FOCAL
> > + select DEP_UBUNTU_JAMMY
> >
> > config MACHINE_QEMU_I386
> > bool "qemui386"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_QEMU_MIPSEL
> > bool "qemumipsel"
> > + select DEP_DEBIAN_BUSTER
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_QEMU_RISCV64
> > bool "qemuriscv64"
> > + select DEP_DEBIAN_SID_PORTS
> >
> > config MACHINE_RPI_ARM_V7
> > bool "rpi-arm-v7"
> > + select DEP_RASPIOS_BULLSEYE
> >
> > config MACHINE_RPI_ARM_V7L
> > bool "rpi-arm-v7l"
> > + select DEP_RASPIOS_BULLSEYE
> >
> > config MACHINE_RPI_ARM
> > bool "rpi-arm"
> > + select DEP_RASPIOS_BULLSEYE
> >
> > config MACHINE_RPI_ARM64_V8
> > bool "rpi-arm64-v8"
> > + select DEP_RASPIOS_BULLSEYE
> >
> > config MACHINE_SIFIVE_FU540
> > bool "sifive-fu540"
> > + select DEP_DEBIAN_SID_PORTS
> >
> > config MACHINE_STARFIVE_VISIONFIVE2
> > bool "starfive-visionfive2"
> > + select DEP_DEBIAN_SID_PORTS
> >
> > config MACHINE_STM32MP15X
> > bool "stm32mp15x"
> > + select DEP_DEBIAN_BULLSEYE
> > + select DEP_DEBIAN_BOOKWORM
> >
> > config MACHINE_VIRTUALBOX
> > bool "virtualbox"
> > + select DEP_DEBIAN_BULLSEYE
> >
> > config MACHINE_VMWARE
> > bool "vmware"
>
next prev parent reply other threads:[~2023-09-19 6:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 6:44 [PATCH 00/13] Support building Isar using kas Uladzimir Bely
2023-09-15 6:44 ` [PATCH 01/13] kas: Add initial Kconfig support Uladzimir Bely
2023-09-15 6:44 ` [PATCH 02/13] kas: Add a local copy of kas-container script Uladzimir Bely
2023-09-15 6:44 ` [PATCH 03/13] kas: Add dependencies between machine and distro configuration Uladzimir Bely
2023-09-16 9:34 ` Jan Kiszka
2023-09-19 6:30 ` Uladzimir Bely [this message]
2023-09-19 6:43 ` Jan Kiszka
2023-09-15 6:44 ` [PATCH 04/13] kas: Add mirror selection Uladzimir Bely
2023-09-16 9:34 ` Jan Kiszka
2023-09-19 6:31 ` Uladzimir Bely
2023-09-15 6:44 ` [PATCH 05/13] kas: Add packages selection Uladzimir Bely
2023-09-16 9:37 ` Jan Kiszka
2023-09-16 16:10 ` Jan Kiszka
2023-09-15 6:44 ` [PATCH 06/13] kas: Add COMPAT_ARCH support Uladzimir Bely
2023-09-15 6:44 ` [PATCH 07/13] kas: Add cross compilation mode selection support Uladzimir Bely
2023-09-15 6:44 ` [PATCH 08/13] kas: Add ccache option Uladzimir Bely
2023-09-15 6:44 ` [PATCH 09/13] kas: Add image type selection Uladzimir Bely
2023-09-16 9:57 ` Jan Kiszka
2023-09-19 6:32 ` Uladzimir Bely
2023-09-15 6:44 ` [PATCH 10/13] kas: Add IMAGE_FSTYPES selection Uladzimir Bely
2023-09-15 6:44 ` [PATCH 11/13] kas: Support CACHE_DEB_SRC option in menu Uladzimir Bely
2023-09-15 6:44 ` [PATCH 12/13] kas: Add options to activate predefined users Uladzimir Bely
2023-09-16 9:39 ` Jan Kiszka
2023-09-15 6:44 ` [PATCH 13/13] kas: Add Readme.md Uladzimir Bely
2023-09-16 9:40 ` [PATCH 00/13] Support building Isar using kas Jan Kiszka
2023-09-16 10:02 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc345b9af432ac2c859e0e7b547ea2e469423687.camel@ilbers.de \
--to=ubely@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox