Re: [PATCH 1/2] Use hardlinks in deb-dl-dir functions

["Moessbauer, Felix" <felix.moessbauer@siemens.com>]

On Fri, 2022-12-30 at 05:38 +0100, Uladzimir Bely wrote:
> This saves disk space and reduces IO
> 
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
>  meta/classes/deb-dl-dir.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/deb-dl-dir.bbclass b/meta/classes/deb-dl-
> dir.bbclass
> index 3b1517dc..d846937a 100644
> --- a/meta/classes/deb-dl-dir.bbclass
> +++ b/meta/classes/deb-dl-dir.bbclass
> @@ -86,7 +86,7 @@ deb_dl_dir_import() {
>          printenv | grep -q BB_VERBOSE_LOGS && set -x
>  
>          sudo find "${pc}" -type f -iname "*\.deb" -exec \
> -            cp -n --no-preserve=owner -t
> "${rootfs}"/var/cache/apt/archives/ {} +
> +            cp -l -n --no-preserve=owner -t
> "${rootfs}"/var/cache/apt/archives/ {} +
>      '

I just observed the following race condition on the cache:

| DEBUG: Python function sstate_hardcode_path finished
| DEBUG: Executing shell function rootfs_install_sstate_prepare
| tar: rootfs/var/cache/apt/archives/network-manager_1.30.6-
1+deb11u1_arm64.deb: file changed as we read it
| WARNING: exit code 1 from a shell command.
| DEBUG: Python function sstate_task_postfunc finished
| ERROR: ExecutionError('/build/tmp/work/debian-bullseye-amd64/sbuild-
chroot-target/1.0-r0/temp/run.rootfs_install_sstate_prepare.7023', 1,
None, None)
ERROR: Task (/build/../work/isar/meta/recipes-devtools/sbuild-
chroot/sbuild-chroot-target.bb:do_rootfs_install) failed with exit code
'1'

Could it be that we copied a file that had not been fully downloaded
yet?

Felix

>  }
>  
> @@ -109,7 +109,7 @@ deb_dl_dir_export() {
>              if [ -n "$package" ]; then
>                  cmp --silent "$package" "$p" && continue
>              fi
> -            sudo cp -n "${p}" "${pc}"
> +            sudo cp -l -n "${p}" "${pc}"
>          done
>          sudo chown -R $(id -u):$(id -g) "${pc}"
>      '
> -- 
> 2.20.1
>