[PATCH] rootfs: Add missing dependency for rootfs_postprocess

[PATCH] rootfs: Add missing dependency for rootfs_postprocess

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

This task needs the unpacked files from SRC_URI, specifically
DISTRO_CONFIG_SCRIPT.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index c7e0435..7d22452 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -227,7 +227,7 @@ python do_rootfs_postprocess() {
     for cmd in cmds:
         bb.build.exec_func(cmd, d)
 }
-addtask rootfs_postprocess before do_rootfs
+addtask rootfs_postprocess before do_rootfs after do_unpack
 
 python do_rootfs() {
     """Virtual task"""
-- 

2.16.4


-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] rootfs: Add missing dependency for rootfs_postprocess

[Claudius Heine]

Hi Jan,

On 20/08/2019 16.48, [ext] Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This task needs the unpacked files from SRC_URI, specifically
> DISTRO_CONFIG_SCRIPT.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   meta/classes/rootfs.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index c7e0435..7d22452 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -227,7 +227,7 @@ python do_rootfs_postprocess() {
>       for cmd in cmds:
>           bb.build.exec_func(cmd, d)
>   }
> -addtask rootfs_postprocess before do_rootfs
> +addtask rootfs_postprocess before do_rootfs after do_unpack

No, I think the dependency between do_unpack and do_fetch is missing.

rootfs_postprocess depends on rootfs_install which depends on do_unpack 
already:

classes/rootfs.bbclass
159:addtask rootfs_install before do_rootfs_postprocess after do_unpack

regards,
Claudius

>   
>   python do_rootfs() {
>       """Virtual task"""
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

Re: [PATCH] rootfs: Add missing dependency for rootfs_postprocess

[Claudius Heine]

On 20/08/2019 16.55, Claudius Heine wrote:
> Hi Jan,
> 
> On 20/08/2019 16.48, [ext] Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This task needs the unpacked files from SRC_URI, specifically
>> DISTRO_CONFIG_SCRIPT.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>   meta/classes/rootfs.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
>> index c7e0435..7d22452 100644
>> --- a/meta/classes/rootfs.bbclass
>> +++ b/meta/classes/rootfs.bbclass
>> @@ -227,7 +227,7 @@ python do_rootfs_postprocess() {
>>       for cmd in cmds:
>>           bb.build.exec_func(cmd, d)
>>   }
>> -addtask rootfs_postprocess before do_rootfs
>> +addtask rootfs_postprocess before do_rootfs after do_unpack
> 
> No, I think the dependency between do_unpack and do_fetch is missing.

Sorry I take that back. I just found it:

classes/base.bbclass
183:addtask unpack after do_fetch before do_build


> 
> rootfs_postprocess depends on rootfs_install which depends on do_unpack 
> already:
> 
> classes/rootfs.bbclass
> 159:addtask rootfs_install before do_rootfs_postprocess after do_unpack
> 
> regards,
> Claudius
> 
>>   python do_rootfs() {
>>       """Virtual task"""
>>
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

Re: [PATCH] rootfs: Add missing dependency for rootfs_postprocess

[Jan Kiszka]

On 20.08.19 16:55, Claudius Heine wrote:
> Hi Jan,
> 
> On 20/08/2019 16.48, [ext] Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This task needs the unpacked files from SRC_URI, specifically
>> DISTRO_CONFIG_SCRIPT.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>   meta/classes/rootfs.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
>> index c7e0435..7d22452 100644
>> --- a/meta/classes/rootfs.bbclass
>> +++ b/meta/classes/rootfs.bbclass
>> @@ -227,7 +227,7 @@ python do_rootfs_postprocess() {
>>       for cmd in cmds:
>>           bb.build.exec_func(cmd, d)
>>   }
>> -addtask rootfs_postprocess before do_rootfs
>> +addtask rootfs_postprocess before do_rootfs after do_unpack
> 
> No, I think the dependency between do_unpack and do_fetch is missing.

That would be another bug, a rather generic one.

The good news is that this change resolved my "debian-configscript.sh: No such 
file or directory".

> 
> rootfs_postprocess depends on rootfs_install which depends on do_unpack already:
> 
> classes/rootfs.bbclass
> 159:addtask rootfs_install before do_rootfs_postprocess after do_unpack

Let me visualize the dep-graph to find out where your assumption was wrong. I 
don't see that ATM either.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] rootfs: Add missing dependency for rootfs_postprocess

[Jan Kiszka]

On 20.08.19 16:58, [ext] Jan Kiszka wrote:
> On 20.08.19 16:55, Claudius Heine wrote:
>> Hi Jan,
>>
>> On 20/08/2019 16.48, [ext] Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> This task needs the unpacked files from SRC_URI, specifically
>>> DISTRO_CONFIG_SCRIPT.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>>   meta/classes/rootfs.bbclass | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
>>> index c7e0435..7d22452 100644
>>> --- a/meta/classes/rootfs.bbclass
>>> +++ b/meta/classes/rootfs.bbclass
>>> @@ -227,7 +227,7 @@ python do_rootfs_postprocess() {
>>>       for cmd in cmds:
>>>           bb.build.exec_func(cmd, d)
>>>   }
>>> -addtask rootfs_postprocess before do_rootfs
>>> +addtask rootfs_postprocess before do_rootfs after do_unpack
>>
>> No, I think the dependency between do_unpack and do_fetch is missing.
> 
> That would be another bug, a rather generic one.
> 
> The good news is that this change resolved my "debian-configscript.sh: No such 
> file or directory".
> 
>>
>> rootfs_postprocess depends on rootfs_install which depends on do_unpack already:
>>
>> classes/rootfs.bbclass
>> 159:addtask rootfs_install before do_rootfs_postprocess after do_unpack
> 
> Let me visualize the dep-graph to find out where your assumption was wrong. I 
> don't see that ATM either.
> 

There was no mistake. Something must have caused do_rootfs_install to finish 
without do_unpack and do_fetch having run before. I still don't see how this 
could possibly happen, but it did here.

Resuming the Gremlin hunt...

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux