public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
	isar-users@googlegroups.com
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/1] fix: clean apt-cache dirs in dpkg_runbuild as root
Date: Thu, 08 Feb 2024 09:48:01 +0300	[thread overview]
Message-ID: <fcd866c784b4d786e78330c4299222da57c9b19d.camel@ilbers.de> (raw)
In-Reply-To: <20240205114837.96599-1-felix.moessbauer@siemens.com>

On Mon, 2024-02-05 at 12:48 +0100, 'Felix Moessbauer' via isar-users
wrote:
> This patch fixes a regression introduced in a0b293c5: The cleaning
> of the rootfs dir before dpkg_runbuild needs to be performed as root,
> as
> this dir might contain data which cannot be deleted by the default
> user.
> 
> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/classes/dpkg.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index 3fc29806..0578977d 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -34,7 +34,7 @@ CP_FLAGS ?= "-Ln --no-preserve=owner"
>  CP_FLAGS:sid ?= "-L --update=none --no-preserve=owner"
>  
>  # Build package from sources using build script
> -dpkg_runbuild[cleandirs] += "${WORKDIR}/rootfs"
> +dpkg_runbuild[root_cleandirs] += "${WORKDIR}/rootfs"
>  dpkg_runbuild[vardepsexclude] += "${SBUILD_PASSTHROUGH_ADDITIONS}"
>  dpkg_runbuild() {
>      E="${@ isar_export_proxies(d)}"
> -- 
> 2.39.2
> 

Applied to next, thanks.

      parent reply	other threads:[~2024-02-08  6:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05 11:48 Felix Moessbauer
2024-02-07  8:19 ` Uladzimir Bely
2024-02-07 17:45   ` Jan Kiszka
2024-02-08  6:48 ` Uladzimir Bely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcd866c784b4d786e78330c4299222da57c9b19d.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox