From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 X-Received: by 2002:a17:906:443:: with SMTP id e3-v6mr162584eja.1.1543479786607; Thu, 29 Nov 2018 00:23:06 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:4acd:: with SMTP id u13-v6ls245805ejt.6.gmail; Thu, 29 Nov 2018 00:23:06 -0800 (PST) X-Google-Smtp-Source: AFSGD/XoT02tX2HeESQoJ2A2Rmaq0zUWNJbE4foN0KhEzjFJHiveN+7ubFrd3/se8NNqT7G2mv/j X-Received: by 2002:a17:906:3582:: with SMTP id o2-v6mr162041ejb.13.1543479786180; Thu, 29 Nov 2018 00:23:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543479786; cv=none; d=google.com; s=arc-20160816; b=ykymsjmPZW9GGYDngWcqwSdanxJAdDMFAEO3Qs+0EGAy9Hrko/n+L/GC4PS+OwNJ25 jV1rMyjvP1hIOeHhqDw1aKqv3PQmTIFBeq7I+jQu4N0ZkIb3E1ah/3H6zKikUfmgMqqG 4Qkk61Fyj9tRkb6doVf+Ua2jGusb5e+6wBOpI5Apf/pAnKbodTUW2d8xkOKxdOfYnn/i /N0tiJplgZvVYy6eSbn1LyNj3QXXcchmqn63pumLPm2J1TU0xpvkjIuxuE5AxOQp4e2I oKsog5JrTkLe9i+MBLF2xSTQ9EwS2RflIs4zxWhAGbChsUjXTcYzS5uIy0wcdGm+N6vO 5CTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:cc:to :subject; bh=iCPdCZKzEiluc8+kaf3Y/Jr+9W40W1LEjrKLCqQh8CY=; b=sQJto0NjYCmP731RvOg+qp5UR/TTeDuWfCYc4s5TPaYqGBYDVRyl8IroFFy9tM2Yl9 3zFJvRBpDBqWN5THU3f5Ihd6ax8lpR/ttj7Tby0IGC1aOlDSeX8dT4Bpxmcr5kv6lScJ LLzUFD1uuJj61xz12EWzidTYwc24JjPUw14l9A54c4WizVj6qkGfoTV6mdQhXbzvZKzo AxLa4OqkSRp8tdLxAlcPc5Y86EZt+9G0iVxGY0G44DoAeknp4ZNuHSRJxQFDsMC2lEsk E0lOhc1v7kPqOhc6ujO1TrsOOvCy2HkxoWrD+ne4QcawKF7St6G9VVxQEnbSZdEbqO41 qlaQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id l31si36014edb.5.2018.11.29.00.23.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 00:23:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.180] (nat-ppp-217.71.235.199-satnet-spb.ru [217.71.235.199] (may be forged)) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id wAT8N3KQ016505 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Thu, 29 Nov 2018 09:23:04 +0100 Subject: Re: [PATCH v6 0/2] rbind mounts for /dev and /sys To: "Hombourger, Cedric" Cc: "isar-users@googlegroups.com" References: <20181119102407.0903d847@md1za8fc.ad001.siemens.net> <1542717658-157-1-git-send-email-Cedric_Hombourger@mentor.com> <59566b71-f70a-ba1a-fd63-d6ea6d24c84d@ilbers.de> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: Date: Thu, 29 Nov 2018 11:22:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: aITWsU5I6gws Hi Cedric, On 11/27/18 5:48 PM, Hombourger, Cedric wrote: > Hi Maxim, > > We may need to revert Henning's suggestion to rbind /sys and mount /sys as a regular mount (the chroot may not need all of the sub-mounts from /sys) > What do people think? My apologies for late reply (was busy with other urgent topics). Have you tested the version with regular mounts? Kind regards, Maxim. > Cedric > > -----Original Message----- > From: Maxim Yu. Osipov [mailto:mosipov@ilbers.de] > Sent: Tuesday, November 27, 2018 5:45 PM > To: Hombourger, Cedric ; isar-users@googlegroups.com > Subject: Re: [PATCH v6 0/2] rbind mounts for /dev and /sys > > Hi Cedric, > > After applying these patches I've recognized that after running ci_build.sh script, the number of mounts significantly increases. > > On my PC it looks like that > > $ mount | wc -l > 34 > isar$ ./scripts/ci_build.sh -q -f > ... > $ mount | wc -l > 100 > > If I revert these patches the number of mount points stays the same after running ci_build.sh script. > > This behavior significantly affects CI - builds start to fail. This is a blocking point for CI and if we don't find a quick solution I will have to revert these patches in 'next'. > > Thanks, > Maxim. > > On 11/20/18 3:40 PM, Cedric Hombourger wrote: >> Some of the packages I have been rebuilding within Isar require /sys mounted. >> For instance, golang-google-grpc runs some package tests after it >> builds itself and reads properties from /sys/class/dmi. >> >> The initial version of this patch series only added a mount of /sys. >> Henning then suggested that we follow Gentoo's guidelines for chroots. >> As such, this patch series is now mounting /dev and /sys as rbind >> mounts but leaves /proc as a regular procfs mount (like Gentoo does). >> >> ChangeLog: >> >> v6: remove unnecessary mkdir for /sys >> v5: cover letter added as suggested by Jan (private e-mail) >> v4: limit rbind mounts to /dev and /sys, leave /proc as a regular >> mount >> v3: rbind mounts for /dev, /proc and /sys, add explicit umount calls >> v2: create /sys directory >> v1: initial submission, simply mount /sys >> >> Cedric Hombourger (2): >> buildchroot+bootstrap: rbind mount for /dev >> buildchroot: add sysfs mount since expected by some packages >> >> meta/classes/buildchroot.bbclass | 5 ++++- >> meta/classes/image.bbclass | 3 ++- >> meta/classes/isar-bootstrap-helper.bbclass | 6 +++++- >> meta/classes/isar-image.bbclass | 3 ++- >> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 8 ++++++-- >> 5 files changed, 19 insertions(+), 6 deletions(-) >> > > > -- > Maxim Osipov > ilbers GmbH > Maria-Merian-Str. 8 > 85521 Ottobrunn > Germany > +49 (151) 6517 6917 > mosipov@ilbers.de > http://ilbers.de/ > Commercial register Munich, HRB 214197 > General Manager: Baurzhan Ismagulov > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov