Re: [PATCH v2 0/7] re-fork wic pcbios and efi plugins

["Bezdeka, Florian" <florian.bezdeka@siemens.com>]

On Fri, 2021-09-03 at 14:53 +0200, Henning Schild wrote:
> changes since v1:
>   - efi plugin forked as well
>   - systemd-boot support in efi plugin enabled
>   - common functionality in utility library
>   - test case for system-boot
>   - "cp -a" moved to "find exec cp" because of ubuntu
>   - changed wks files to exclude boot from root and mount it
> 
> The forked plugins have gotten out of sync with the last wic version
> bumps. And the original fork was not exactly minimal or made for easy
> maintenance.
> 
> This series does a re-fork of the two plugins with the aim to come up
> with something readable, minimal and maintainable.
> 
> There used to be a special case for grub-efi where the actual kernel and
> initrd would remain in the root partition, which kind of allowed kernel
> updates with apt-get. Now all three bootloaders (systemd-boot now works
> as well) place bootloader, config and boot artifacts in a
> boot-partition.
> 
> Kernel updates with apt-get are now consistantly "broken". That
> consistency very likely is not too bad. A generic solution for this
> feature (if wanted) will need to be found. Covering not just these three
> bootloaders but possibly also u-boot and efibootguard.

I had a quick look and asked myself if it would be possible to
implement the ISAR specific parts in sub-classes of such plugins. I
assume that would require some upstream work first, followed by a re-
sync and adding the ISAR stuff in plugins that inherit from the
upstream ones.

As far as I can see all affected plugins are python classes. I'm not a
python expert but I guess that should be doable and would completely
isolate the ISAR parts from the upstream stuff.
 
> 
> Henning Schild (7):
>   wic: reset our plugin forks to OE upstream for re-forking
>   wic: add utility library for common bits of isar plugins
>   wic: apply the actual fork changes to our pcbios plugin fork
>   wic: clean up wic class in terms of isar variables
>   wic: apply the actual fork changes to our efi plugin fork
>   wic: mount /boot and exlude it from root for efi
>   meta-isar: use "systemd-boot" for one test target
> 
>  RECIPE-API-CHANGELOG.md                       |   9 +
>  meta-isar/conf/machine/qemuamd64.conf         |   3 +
>  .../scripts/lib/wic/canned-wks/hikey.wks      |   4 +-
>  .../lib/wic/canned-wks/sdimage-efi-sd.wks     |   9 +
>  .../lib/wic/canned-wks/sdimage-efi.wks        |   4 +-
>  meta/classes/wic-img.bbclass                  |   6 +-
>  .../scripts/lib/wic/plugins/isarpluginbase.py |  39 ++++
>  .../wic/plugins/source/bootimg-efi-isar.py    | 200 ++++++++++++++----
>  .../wic/plugins/source/bootimg-pcbios-isar.py | 139 ++++++------
>  9 files changed, 290 insertions(+), 123 deletions(-)
>  create mode 100644 meta-isar/scripts/lib/wic/canned-wks/sdimage-efi-sd.wks
>  create mode 100644 meta/scripts/lib/wic/plugins/isarpluginbase.py
>