Re: [PATCH 1/4] kernel/module: Add AUTOLOAD option

[Alexander Smirnov <asmirnov@ilbers.de>]

On 03/07/2018 10:19 AM, Jan Kiszka wrote:
> On 2018-03-06 13:40, Alexander Smirnov wrote:
>> Add possibility to set kernel module to be autoloaded.
>> Also add run dependency from 'systemd' because this package owns the
>> content of '/etc/modules-load.d'.
>>
>> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
>> ---
>>   meta/recipes-kernel/linux-module/files/debian/control | 2 +-
>>   meta/recipes-kernel/linux-module/module.inc           | 7 +++++++
>>   2 files changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-kernel/linux-module/files/debian/control b/meta/recipes-kernel/linux-module/files/debian/control
>> index 707f857..0eae9a4 100644
>> --- a/meta/recipes-kernel/linux-module/files/debian/control
>> +++ b/meta/recipes-kernel/linux-module/files/debian/control
>> @@ -7,5 +7,5 @@ Maintainer: ISAR project <isar-users@googlegroups.com>
>>   
>>   Package: @PN@
>>   Architecture: any
>> -Depends: linux-image-@KERNEL_NAME@
>> +Depends: linux-image-@KERNEL_NAME@, systemd
> 
> Why this, BTW?

See comment to the patch:

8<--
Also add run dependency from 'systemd' because this package owns the
content of '/etc/modules-load.d'.
8<--

So if this dependency is not set, the module.postinst script could be 
run *before* '/etc/modules*' infrastructure is created.

Alex

> 
> Jan
> 
>>   Description: @DESCRIPTION@
>> diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc
>> index aa232f7..0684659 100644
>> --- a/meta/recipes-kernel/linux-module/module.inc
>> +++ b/meta/recipes-kernel/linux-module/module.inc
>> @@ -13,6 +13,8 @@ DEPENDS += "linux-headers-${KERNEL_NAME}"
>>   
>>   SRC_URI += "file://debian/"
>>   
>> +AUTOLOAD ?= "0"
>> +
>>   inherit dpkg
>>   
>>   dpkg_runbuild_prepend() {
>> @@ -21,4 +23,9 @@ dpkg_runbuild_prepend() {
>>              -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \
>>              -e 's/@DESCRIPTION@/${DESCRIPTION}/g' \
>>           ${WORKDIR}/${S}/debian/changelog ${WORKDIR}/${S}/debian/control
>> +
>> +    if [ ${AUTOLOAD} = "1" ]; then
>> +        echo "echo ${PN} > /etc/modules-load.d/${PN}.conf" >> ${WORKDIR}/${S}/debian/postinst
>> +        chmod +x ${WORKDIR}/${S}/debian/postinst
>> +    fi
>>   }
>>
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov