From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6463342265335021568 X-Received: by 10.28.212.73 with SMTP id l70mr779369wmg.14.1505118468675; Mon, 11 Sep 2017 01:27:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.16.197 with SMTP id 66ls90634ljq.1.gmail; Mon, 11 Sep 2017 01:27:48 -0700 (PDT) X-Google-Smtp-Source: ADKCNb5uLOqput3qbUf/FFZsAaJX/55q14OYgaP3ziVK1RFgcN79SoSNE/XHN6rB5ttblqeSXp+v X-Received: by 10.46.93.19 with SMTP id r19mr356812ljb.43.1505118468021; Mon, 11 Sep 2017 01:27:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505118467; cv=none; d=google.com; s=arc-20160816; b=kKF/uWIm19ddMdEP68SI00KMH5Ap4WVGDbbAnMevyhkdBEEJS2Vd9EUqsUN9aAHWXo z+sBOINQYDAitQXsyHbDxyS3TZ0AyNQlWLqaMUy0Sv4V83EtEnMcVncNzTEqJFIHVkp6 Z3gtSTQ6FISEYr/qQJx/M2obkNfC2ZXIE3eYjNn5aWj6+ITaNLBKb9YIhJpnA+SkxThg gcYVGHk94H6w4EqrMhBBIdIy9cX8LOAohOj/eU952vN+m8LXFuyQ2NGAYdoH6/bAB/3M QzSJNWAySPTuntA1okK+VyxqEz5wbFAYZDaQ6oZUdqNw6u3joQFUhMcDV+Va8EZagtz8 9tyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=IeAioWxaZOcvHh6pXhvSDs+S4bUkY/xxN2wEbyM/7UA=; b=s9TDQ00hfvbiazfCY+Qowr2XBbxXATtkdWupI19M+bf8j6sZm8s+4VmQg8rVudMXe/ D/atbgl+9K2r5LGkiFRsNHxnR9tEmAJB4kJnclvRhb9AdvJKaQ8N2F+I6INJSKbuwux5 N4Pqso0vDJKWl8EyJ0BTn8HW1m5tKIWjxMp+HM5oDUhZrkTzbgfjvnGe/3TR0MMzKmlX MFcgLhYxGKUDsfbwSneJ+zc4O60zr7M8+bnVi1jKXLUihQLEdEHdB6K1KoVy4ZfxfS9z VvUe3AKuD0YVoddNGlF3xf2EFTvjMw0j1jaGDdeoVwDKqkrjpAwOFkDo0k8sDfJz0104 XU2g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 194.138.37.40 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id e84si311029wmi.7.2017.09.11.01.27.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Sep 2017 01:27:47 -0700 (PDT) Received-SPF: neutral (google.com: 194.138.37.40 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 194.138.37.40 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id v8B8RlcC019868 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Sep 2017 10:27:47 +0200 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id v8B8RlAn025691; Mon, 11 Sep 2017 10:27:47 +0200 Subject: Re: [PATCH 1/2] isar: Change build folders tree To: Alexander Smirnov , isar-users@googlegroups.com References: <20170908094834.26496-1-asmirnov@ilbers.de> <20170908094834.26496-2-asmirnov@ilbers.de> From: Claudius Heine Message-ID: Date: Mon, 11 Sep 2017 10:27:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170908094834.26496-2-asmirnov@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: q+FQ3pIhyXj4 Hi, On 09/08/2017 11:48 AM, Alexander Smirnov wrote: > @@ -40,9 +39,9 @@ do_build() { > sed -i 's|##DISTRO_APT_SOURCE##|${DISTRO_APT_SOURCE}|' ${WORKDIR}/multistrap.conf > sed -i 's|##DISTRO_SUITE##|${DISTRO_SUITE}|' ${WORKDIR}/multistrap.conf > sed -i 's|##DISTRO_COMPONENTS##|${DISTRO_COMPONENTS}|' ${WORKDIR}/multistrap.conf > - sed -i 's|##CONFIG_SCRIPT##|./tmp/work/${PF}/${DISTRO}/configscript.sh|' ${WORKDIR}/multistrap.conf > - sed -i 's|##SETUP_SCRIPT##|./tmp/work/${PF}/${DISTRO}/setup.sh|' ${WORKDIR}/multistrap.conf > - sed -i 's|##DIR_HOOKS##|./tmp/work/${PF}/${DISTRO}/hooks_multistrap|' ${WORKDIR}/multistrap.conf > + sed -i 's|##CONFIG_SCRIPT##|./tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/configscript.sh|' ${WORKDIR}/multistrap.conf > + sed -i 's|##SETUP_SCRIPT##|./tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/setup.sh|' ${WORKDIR}/multistrap.conf > + sed -i 's|##DIR_HOOKS##|./tmp/work/${DISTRO}-${DISTRO_ARCH}/${PF}/hooks_multistrap|' ${WORKDIR}/multistrap.conf Since you are touching this part in this patch series. Can you clean this up a bit in a seperate patch? Something like this just looks so much nicer, don't you agree? sed -e 's|##IMAGE_PREINSTALL##|${IMAGE_PREINSTALL}|g' \ -e 's|##DISTRO##|${DISTRO}|g' \ -e 's|##DISTRO_APT_SOURCE##|${DISTRO_APT_SOURCE}|g' \ -e 's|##DISTRO_SUITE##|${DISTRO_SUITE}|g' \ -e 's|##DISTRO_COMPONENTS##|${DISTRO_COMPONENTS}|g' \ -e 's|##CONFIG_SCRIPT##|./tmp/work/${PN}/${MACHINE}/configscript.sh|g' \ -e 's|##SETUP_SCRIPT##|${WORKDIR}/setup.sh|g' \ -e 's|##DIR_HOOKS##|./tmp/work/${PN}/${MACHINE}/hooks_multistrap|g' \ ${WORKDIR}/multistrap.conf.in > ${WORKDIR}/multistrap.conf Of course you have to fit that to your code here. Thanks. Cheers, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de