Re: [PATCH v4 2/8] split up isar-bootstrap helper and implement pre-process pipeline

[Jan Kiszka <jan.kiszka@siemens.com>]

On 19.08.19 08:59, Claudius Heine wrote:
> Hi Jan,
> 
> On 14/08/2019 18.00, Jan Kiszka wrote:
>> On 23.05.19 16:55, [ext] claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> This removes the isar-bootstrap-helper.bbclass and integrates its
>>> functionality into the rootfs.bbclass.
>>>
>>> It introduces the rootfs_install task that runs through multiple
>>> functions from command lists in order to allow easy integration of
>>> custom functions.
>>>
>>> The introduced functions are, in general order of execution:
>>>
>>>    rootfs_prepare: copy the isar-bootstrap rootfs base to workdir
>>>    rootfs_configure_*: basic configuration of the root file system,
>>>      before any custom packages where installed. (`/dev`, `/proc`, etc.
>>>      are not mounted). Functions are added to `ROOTFS_CONFIGURE_COMMAND`.
>>>    rootfs_do_mount: mount standard directories and repositories into the
>>>      rootfs
>>>    do_rootfs_install_*: downloading and installing packages. Functions
>>>    are added to `ROOTFS_INSTALL_COMMAND`.
>>>
>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>> ---
>>>   meta/classes/image.bbclass                    |  24 +--
>>>   meta/classes/isar-bootstrap-helper.bbclass    | 132 --------------
>>>   meta/classes/rootfs.bbclass                   | 172 +++++++++++++++++-
>>>   .../isar-bootstrap/isar-bootstrap.inc         |   5 +
>>>   .../buildchroot/buildchroot-host.bb           |  16 +-
>>>   .../buildchroot/buildchroot-target.bb         |   2 -
>>>   .../buildchroot/buildchroot.inc               |  26 ++-
>>>   meta/recipes-devtools/sdkchroot/sdkchroot.bb  |  48 ++---
>>>   8 files changed, 228 insertions(+), 197 deletions(-)
>>>   delete mode 100644 meta/classes/isar-bootstrap-helper.bbclass
>>>
>>
>> [...]
>>
>>> diff --git a/meta/recipes-devtools/buildchroot/buildchroot-host.bb 
>>> b/meta/recipes-devtools/buildchroot/buildchroot-host.bb
>>> index 73cd548..121992c 100644
>>> --- a/meta/recipes-devtools/buildchroot/buildchroot-host.bb
>>> +++ b/meta/recipes-devtools/buildchroot/buildchroot-host.bb
>>> @@ -7,6 +7,8 @@ DESCRIPTION = "Isar development filesystem for host"
>>>   PF = "${PN}-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}"
>>>   require buildchroot.inc
>>> +ROOTFS_ARCH = "${HOST_ARCH}"
>>> +ROOTFS_DISTRO = "${HOST_DISTRO}"
>>>   BUILDCHROOT_PREINSTALL ?= "make \
>>>                              debhelper \
>>> @@ -18,15 +20,5 @@ BUILDCHROOT_PREINSTALL ?= "make \
>>>                              automake \
>>>                              devscripts \
>>>                              equivs \
>>> -                           libc6:${DISTRO_ARCH}"
>>> -
>>> -# According to the wiki page:
>>> -#     https://wiki.debian.org/CrossToolchains
>>> -BUILDCHROOT_PREINSTALL_append_armhf += "binutils-arm-linux-gnueabihf \
>>> -                                        crossbuild-essential-armhf"
>>> -BUILDCHROOT_PREINSTALL_append_arm64 += "binutils-aarch64-linux-gnu \
>>> -                                        crossbuild-essential-arm64"
>>
>> Where did binutils go after this patch? Don't we need them? Wondering because 
>> there is no remark in the commit why they were removed.
> 
> Well crossbuild-essential-* is added and just like 'build-essential' binutils is 
> a dependency from it:
> 
> crossbuild-essential-* > gcc-*-linux-gnueabi > gcc-8-*-linux-gnueabi > 
> binutils-*-linux-gnueabi
> 
> So that was just a removal of unneeded package names, that get installed anyway.

That is what was missing in the commit...

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux