From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6691586504498610176 X-Received: by 2002:a17:906:3e8e:: with SMTP id a14mr16677417ejj.142.1566198165204; Mon, 19 Aug 2019 00:02:45 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:90d5:: with SMTP id d21ls3871236eda.11.gmail; Mon, 19 Aug 2019 00:02:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqwssHf3Nydoi69jU1jRWcG4mE9ZQ4k36nlMkYHVrT5vg/Tn/rAuGotFCfWkQdEZJpBXZ1gA X-Received: by 2002:a50:fc12:: with SMTP id i18mr21067450edr.23.1566198164715; Mon, 19 Aug 2019 00:02:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566198164; cv=none; d=google.com; s=arc-20160816; b=DFOD9ZL8h4UWW2YU7Xtb6rZen+GY5SC2uLC5IxJUWsWCMwX30RPLUQaEnLSRdF6t3v 5GmIqRZljcNZYoIoB0IyDlSNs+zurWhyR3rJ2DWkYTYkBGYBEK02akoQN3Fj+0vvu6k1 /mbyJwgJ8Euk7SnSMhnHmwVw7yE9tLcdpeKLoliZxASjDdrRHeAlPA59QVrmjwIDLZuM wByRj6D2OTGDGvR/pChfMntRICWcFrr52H1KCZOG/SDEVBY3XTeqFdJvZsAOWJ3EBoL5 D1KVDjnJl+mDuJ9wTFxuXbHozmHsj9ErsaT9kaRd6mZf/qdiOybM5JjE6/3yOKNk4omk TpRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=/fB6B5xlg2mrESOpCsGkTfVTE7hQdXFmK9vavfyY/og=; b=LhEu5G2uHsIuOLOubS5rcf59ME+22ZexTBoEXBoIbbDcDE7+YCGBjZxvoSzRujDdlu s+ZfsjcNdQJBY5/Q/cRNggBFjADUy9P4kF+yI6YWmLpJpjOnKfGMovJzAVaivnX+ftyz gEetjQ0ueNvV9tqz1QnruET1PfFRsYfMfdyOSfcSvRaYRpFyBqHPBXtvDG/OROJ+wNfT 0QHAOYB/Q80Y5kUcEWMnWbQmJH02eAr/DrLpLSzcns7QSy/G2Q1jlB/h+IjNCgj/57m3 iwMYpZDHRwxYt9Og4c61vfFAq6DnZPoqbOj/kSfS6CwzJpxwzsjKLF8tCJ/OpwOyvCOZ 6apw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id m29si601339edb.3.2019.08.19.00.02.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 00:02:44 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x7J72h5v017548 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Aug 2019 09:02:43 +0200 Received: from [139.22.46.100] ([139.22.46.100]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7J72gwk017970; Mon, 19 Aug 2019 09:02:43 +0200 Subject: Re: [PATCH v4 2/8] split up isar-bootstrap helper and implement pre-process pipeline To: Claudius Heine , isar-users@googlegroups.com Cc: Claudius Heine References: <20190523145521.23050-1-claudius.heine.ext@siemens.com> <20190523145521.23050-3-claudius.heine.ext@siemens.com> <9854b2df-897d-393a-e968-e23fccbb67a1@siemens.com> <4cccc136-83f6-a7ea-ce94-686fdab09b1d@siemens.com> From: Jan Kiszka Message-ID: Date: Mon, 19 Aug 2019 09:02:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <4cccc136-83f6-a7ea-ce94-686fdab09b1d@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: pR74jsHnu2lX On 19.08.19 08:59, Claudius Heine wrote: > Hi Jan, > > On 14/08/2019 18.00, Jan Kiszka wrote: >> On 23.05.19 16:55, [ext] claudius.heine.ext@siemens.com wrote: >>> From: Claudius Heine >>> >>> This removes the isar-bootstrap-helper.bbclass and integrates its >>> functionality into the rootfs.bbclass. >>> >>> It introduces the rootfs_install task that runs through multiple >>> functions from command lists in order to allow easy integration of >>> custom functions. >>> >>> The introduced functions are, in general order of execution: >>> >>>    rootfs_prepare: copy the isar-bootstrap rootfs base to workdir >>>    rootfs_configure_*: basic configuration of the root file system, >>>      before any custom packages where installed. (`/dev`, `/proc`, etc. >>>      are not mounted). Functions are added to `ROOTFS_CONFIGURE_COMMAND`. >>>    rootfs_do_mount: mount standard directories and repositories into the >>>      rootfs >>>    do_rootfs_install_*: downloading and installing packages. Functions >>>    are added to `ROOTFS_INSTALL_COMMAND`. >>> >>> Signed-off-by: Claudius Heine >>> --- >>>   meta/classes/image.bbclass                    |  24 +-- >>>   meta/classes/isar-bootstrap-helper.bbclass    | 132 -------------- >>>   meta/classes/rootfs.bbclass                   | 172 +++++++++++++++++- >>>   .../isar-bootstrap/isar-bootstrap.inc         |   5 + >>>   .../buildchroot/buildchroot-host.bb           |  16 +- >>>   .../buildchroot/buildchroot-target.bb         |   2 - >>>   .../buildchroot/buildchroot.inc               |  26 ++- >>>   meta/recipes-devtools/sdkchroot/sdkchroot.bb  |  48 ++--- >>>   8 files changed, 228 insertions(+), 197 deletions(-) >>>   delete mode 100644 meta/classes/isar-bootstrap-helper.bbclass >>> >> >> [...] >> >>> diff --git a/meta/recipes-devtools/buildchroot/buildchroot-host.bb >>> b/meta/recipes-devtools/buildchroot/buildchroot-host.bb >>> index 73cd548..121992c 100644 >>> --- a/meta/recipes-devtools/buildchroot/buildchroot-host.bb >>> +++ b/meta/recipes-devtools/buildchroot/buildchroot-host.bb >>> @@ -7,6 +7,8 @@ DESCRIPTION = "Isar development filesystem for host" >>>   PF = "${PN}-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}" >>>   require buildchroot.inc >>> +ROOTFS_ARCH = "${HOST_ARCH}" >>> +ROOTFS_DISTRO = "${HOST_DISTRO}" >>>   BUILDCHROOT_PREINSTALL ?= "make \ >>>                              debhelper \ >>> @@ -18,15 +20,5 @@ BUILDCHROOT_PREINSTALL ?= "make \ >>>                              automake \ >>>                              devscripts \ >>>                              equivs \ >>> -                           libc6:${DISTRO_ARCH}" >>> - >>> -# According to the wiki page: >>> -#     https://wiki.debian.org/CrossToolchains >>> -BUILDCHROOT_PREINSTALL_append_armhf += "binutils-arm-linux-gnueabihf \ >>> -                                        crossbuild-essential-armhf" >>> -BUILDCHROOT_PREINSTALL_append_arm64 += "binutils-aarch64-linux-gnu \ >>> -                                        crossbuild-essential-arm64" >> >> Where did binutils go after this patch? Don't we need them? Wondering because >> there is no remark in the commit why they were removed. > > Well crossbuild-essential-* is added and just like 'build-essential' binutils is > a dependency from it: > > crossbuild-essential-* > gcc-*-linux-gnueabi > gcc-8-*-linux-gnueabi > > binutils-*-linux-gnueabi > > So that was just a removal of unneeded package names, that get installed anyway. That is what was missing in the commit... Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux