public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Claudius Heine <ch@denx.de>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH] doc/RECIPE-API-CHANGELOG: fix FILESEXTRAPATHS line
Date: Thu, 6 Jul 2023 08:52:31 +0200	[thread overview]
Message-ID: <ffb7062c-996b-7775-9b21-69d25cb828f4@denx.de> (raw)
In-Reply-To: <568e0473-e70c-5120-bae7-23ae523260c4@ilbers.de>

Hi Anton,

On 2023-07-05 16:03, Anton Mikanovich wrote:
> 05/07/2023 16:31, Claudius Heine wrote:
>> Use new override syntax: "_" -> ":"
>>
>> And fix `THISDIR` expansion: "$THISDIR" -> "${THISDIR}"
>>
>> Signed-off-by: Claudius Heine <ch@denx.de>
>> ---
>>   RECIPE-API-CHANGELOG.md | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
>> index 7a16b5c..8517eb2 100644
>> --- a/RECIPE-API-CHANGELOG.md
>> +++ b/RECIPE-API-CHANGELOG.md
>> @@ -192,7 +192,7 @@ files and patches using bbappend a lot easier.
>>   For example:
>>   ```
>> -FILESEXTRAPATHS_prepend := "$THISDIR/files:"
>> +FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
>>   ```
>>   ### multiconfig build targets were renamed
> 
> Hello Claudius,
> 
> You've changed changelog of v0.8 which was using old override syntax.
> This patch is incorrect, so rejected.

Both kind of changes here? I sort of understand not changing the 
override syntax, but "$THISDIR" -> "${THISDIR}" is more or less a typo 
fix. Would a patch that just fixes that be acceptable?

regards,
Claudius

  reply	other threads:[~2023-07-06  6:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05 13:31 Claudius Heine
2023-07-05 14:03 ` Anton Mikanovich
2023-07-06  6:52   ` Claudius Heine [this message]
2023-07-12 13:47     ` Anton Mikanovich
2023-08-02 21:37 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffb7062c-996b-7775-9b21-69d25cb828f4@denx.de \
    --to=ch@denx.de \
    --cc=amikan@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox