[PATCH] sdk: always depend on crossbuild-essential for riscv64

[PATCH] sdk: always depend on crossbuild-essential for riscv64

[Anton Mikanovich]

If we add crossbuild-essential-riscv64 package to ROOTFS_PACKAGES
unconditionally we should also depend on it even if ISAR_CROSS_COMPILE
is set to "0". SDK creation will fail otherwise.

Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 meta/classes/sdk.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
index 38671bb..1fc7b14 100644
--- a/meta/classes/sdk.bbclass
+++ b/meta/classes/sdk.bbclass
@@ -58,7 +58,7 @@ IMAGE_FSTYPES_class-sdk = "${SDK_FORMATS}"
 
 # bitbake dependencies
 SDKDEPENDS += "sdk-files ${SDK_INSTALL}"
-SDKDEPENDS_append_riscv64 = "${@' crossbuild-essential-riscv64' if d.getVar('ISAR_CROSS_COMPILE', True) == '1' and d.getVar('PN') != 'crossbuild-essential-riscv64' else ''}"
+SDKDEPENDS_append_riscv64 = "crossbuild-essential-riscv64"
 DEPENDS_class-sdk = "${SDKDEPENDS}"
 
 SDKROOTFSDEPENDS = ""
-- 
2.30.2

Re: [PATCH] sdk: always depend on crossbuild-essential for riscv64

[Jan Kiszka]

On 17.06.22 11:28, Anton Mikanovich wrote:
> If we add crossbuild-essential-riscv64 package to ROOTFS_PACKAGES
> unconditionally we should also depend on it even if ISAR_CROSS_COMPILE
> is set to "0". SDK creation will fail otherwise.
> 
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/sdk.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> index 38671bb..1fc7b14 100644
> --- a/meta/classes/sdk.bbclass
> +++ b/meta/classes/sdk.bbclass
> @@ -58,7 +58,7 @@ IMAGE_FSTYPES_class-sdk = "${SDK_FORMATS}"
>  
>  # bitbake dependencies
>  SDKDEPENDS += "sdk-files ${SDK_INSTALL}"
> -SDKDEPENDS_append_riscv64 = "${@' crossbuild-essential-riscv64' if d.getVar('ISAR_CROSS_COMPILE', True) == '1' and d.getVar('PN') != 'crossbuild-essential-riscv64' else ''}"
> +SDKDEPENDS_append_riscv64 = "crossbuild-essential-riscv64"
>  DEPENDS_class-sdk = "${SDKDEPENDS}"

I don't think this is correct. What if we compile a native SDK for
RISC-V? Then we surely don't install crossbuild packages.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux

Re: [PATCH] sdk: always depend on crossbuild-essential for riscv64

[Anton Mikanovich]

17.06.2022 16:43, Jan Kiszka wrote:
> On 17.06.22 11:28, Anton Mikanovich wrote:
>> If we add crossbuild-essential-riscv64 package to ROOTFS_PACKAGES
>> unconditionally we should also depend on it even if ISAR_CROSS_COMPILE
>> is set to "0". SDK creation will fail otherwise.
>>
>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>> ---
>>   meta/classes/sdk.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
>> index 38671bb..1fc7b14 100644
>> --- a/meta/classes/sdk.bbclass
>> +++ b/meta/classes/sdk.bbclass
>> @@ -58,7 +58,7 @@ IMAGE_FSTYPES_class-sdk = "${SDK_FORMATS}"
>>   
>>   # bitbake dependencies
>>   SDKDEPENDS += "sdk-files ${SDK_INSTALL}"
>> -SDKDEPENDS_append_riscv64 = "${@' crossbuild-essential-riscv64' if d.getVar('ISAR_CROSS_COMPILE', True) == '1' and d.getVar('PN') != 'crossbuild-essential-riscv64' else ''}"
>> +SDKDEPENDS_append_riscv64 = "crossbuild-essential-riscv64"
>>   DEPENDS_class-sdk = "${SDKDEPENDS}"
> I don't think this is correct. What if we compile a native SDK for
> RISC-V? Then we surely don't install crossbuild packages.
>
> Jan
>
We actually install crossbuild-essential in both native and cross builds 
of SDK currently.
But this is probably more correct place for the fix. I will prepare v2.

Re: [PATCH] sdk: always depend on crossbuild-essential for riscv64

[Anton Mikanovich]

17.06.2022 16:43, Jan Kiszka wrote:
> I don't think this is correct. What if we compile a native SDK for
> RISC-V? Then we surely don't install crossbuild packages.
>
> Jan
>
I've just noticed that SDK is always building with ISAR_CROSS_COMPILE set to
"0" currently, because it is a part of imager (which always run natively).
It means there is no usage for ISAR_CROSS_COMPILE checking, it will 
always be
overwritten to "0" by imager.
Will provide v2 anyway, cross SDK should be fixed separately later.