From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7110138448557637632 X-Received: by 2002:a05:6512:6ca:b0:479:32:6011 with SMTP id u10-20020a05651206ca00b0047900326011mr6004931lff.4.1655482909587; Fri, 17 Jun 2022 09:21:49 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:b95:b0:479:6748:7081 with SMTP id b21-20020a0565120b9500b0047967487081ls329618lfv.3.gmail; Fri, 17 Jun 2022 09:21:48 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vV+Ty2ICr6jBqj8AqUnujM19w8slQZqAe4ElSivUkBaGG/uHPCAd/Zkw5s+k1Qh2nSiGYP X-Received: by 2002:ac2:4a70:0:b0:47f:5738:aec2 with SMTP id q16-20020ac24a70000000b0047f5738aec2mr1270036lfp.499.1655482908434; Fri, 17 Jun 2022 09:21:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655482908; cv=none; d=google.com; s=arc-20160816; b=GidfbGpQacmFEGpX6kJE/pcnBO53VtnmYU1c9w13m3XAlKLUHOaldjXUPygACQUaCg pmRe/Ig9JyUSuCziCF51S6amJGSmbNjMEqxeyu3Hps6SJ22ti3bVDs9CqbUxwKpV6YmT ZV8F3i2ofzSOOeS9t9UIqm0Lz2EDwes69Ohw0A6SWacqQTruQJJs5Qt7aG/mTFvHRUHO PkgRZ8Fb57UsFQTq8kOYk2yE79DHgmrx9O7KEk/V+zPhhWcSZeUEZNRhk9TE6SKMAzZ8 UF7/SIEafKJ9MSn4H+Ada1ylOOg7Umx/JRG+4ltRbgXsbIXqzOA3srXshvjo5f0JvPmf th5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id; bh=IaVhFJy57Y6U0ytCXoqSPB5VxIxHP3qOcZeFaIAt6Ec=; b=O+yxZ2v54KRy4lIFOXpoPoZUulCF9StmRJxiBgZXw6ihClnJLZKHTnBfJg2nxvbt16 a5VTj3mNLghtyZvM+avuG1ijKhqkQ9AR++RW5hme8Mp7g8pv8vRdcvU8YPVSTlQLECtp KHetd178QYFAif+wCmgAg8AndeOLhn3WBrvwVzFThDH4HZWxw6d3utCYzp6n3EbJTvom C5QMyNVoM1VcszJKtUFQqzE4wHVWnoxaBtauvJHGzWfZvoHvidOJLhV9+O8nR2U9li89 EE4UpRWH1aZZNGCDF0hA1i3ZNVIqarsoLS/1kjdaKaKq5gs1KOU7cR9jBt71/7t1wc/v mr9g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id o9-20020a05651205c900b0047866dddb47si78130lfo.2.2022.06.17.09.21.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Jun 2022 09:21:48 -0700 (PDT) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 25HGLj0L014534 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Jun 2022 18:21:47 +0200 Message-ID: Date: Fri, 17 Jun 2022 19:21:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] sdk: always depend on crossbuild-essential for riscv64 Content-Language: en-US To: Jan Kiszka , isar-users@googlegroups.com, Baurzhan Ismagulov References: <20220617092818.14063-1-amikan@ilbers.de> <68c56647-aeee-cf67-8a9e-c74443957cde@siemens.com> From: Anton Mikanovich In-Reply-To: <68c56647-aeee-cf67-8a9e-c74443957cde@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: zLuysCBlqgGo 17.06.2022 16:43, Jan Kiszka wrote: > On 17.06.22 11:28, Anton Mikanovich wrote: >> If we add crossbuild-essential-riscv64 package to ROOTFS_PACKAGES >> unconditionally we should also depend on it even if ISAR_CROSS_COMPILE >> is set to "0". SDK creation will fail otherwise. >> >> Signed-off-by: Anton Mikanovich >> --- >> meta/classes/sdk.bbclass | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass >> index 38671bb..1fc7b14 100644 >> --- a/meta/classes/sdk.bbclass >> +++ b/meta/classes/sdk.bbclass >> @@ -58,7 +58,7 @@ IMAGE_FSTYPES_class-sdk = "${SDK_FORMATS}" >> >> # bitbake dependencies >> SDKDEPENDS += "sdk-files ${SDK_INSTALL}" >> -SDKDEPENDS_append_riscv64 = "${@' crossbuild-essential-riscv64' if d.getVar('ISAR_CROSS_COMPILE', True) == '1' and d.getVar('PN') != 'crossbuild-essential-riscv64' else ''}" >> +SDKDEPENDS_append_riscv64 = "crossbuild-essential-riscv64" >> DEPENDS_class-sdk = "${SDKDEPENDS}" > I don't think this is correct. What if we compile a native SDK for > RISC-V? Then we surely don't install crossbuild packages. > > Jan > We actually install crossbuild-essential in both native and cross builds of SDK currently. But this is probably more correct place for the fix. I will prepare v2.