Re: [PATCH 2/2] sbuild: do not build arch all packages on cross

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 29.04.26 12:47, 'Felix Moessbauer' via isar-users wrote:
> Architecture all packages often cannot be built in cross mode, as the
> dependencies cannot be resolved in the host architecture. This
> especially applies to all packages which split their build dependencies
> into Build-Depends-Arch and Build-Depends-Indep. We already have logic
> in isar to built DPKG_ARCH=all packages non-cross, but this does not
> work for packages that generate both arch specific and arch all binary
> packages.
> 
> While sbuild automatically disables builds of arch-all packages on
> cross, we previously explicitly overrode this setting. We now change
> this by explicitly setting --no-arch-all flag on cross and --arch-all on
> non-cross.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  RECIPE-API-CHANGELOG.md          | 15 +++++++++++++++
>  meta/classes-recipe/dpkg.bbclass |  3 ++-
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md
> index 856da5de..c83c1599 100644
> --- a/RECIPE-API-CHANGELOG.md
> +++ b/RECIPE-API-CHANGELOG.md
> @@ -1001,3 +1001,18 @@ do_copy_boot_files: The recipe isar-image-base is trying to install
>  files into a shared area when those files already exists. It happens
>  when some files have the same names (e.g., dtb files) for different
>  distros.
> +
> +### No building of arch=all packages when cross building
> +
> +Architecture all packages often cannot be built in cross mode, as the
> +dependencies cannot be resolved in the foreign architecture. This especially
> +applies to all packages which split their build dependencies into
> +`Build-Depends-Arch` and `Build-Depends-Indep`. We already have logic
> +in isar to built `DPKG_ARCH = "all"` packages non-cross, but this does not
> +work for packages that generate both arch specific and arch all binary packages.
> +
> +We now explicitly disable building arch=all binary packages on cross (this
> +technically only affects packages that generate arch specific and arch=all
> +binary packages). To build the arch=all binary packages of such source packages,
> +add an explicit dependency to `${BPN}-native`. Source packages that only

That will be fun to find, though likely a rare one. Can't we detect such
cases in Isar and add a bitbake dependency from $BPN to -native?

Jan

> +generate `arch=all` packages, must now be marked `DPKG_ARCH = "all"`.
> diff --git a/meta/classes-recipe/dpkg.bbclass b/meta/classes-recipe/dpkg.bbclass
> index c1c38184..500aaefe 100644
> --- a/meta/classes-recipe/dpkg.bbclass
> +++ b/meta/classes-recipe/dpkg.bbclass
> @@ -109,8 +109,9 @@ dpkg_runbuild() {
>  
>      DSC_FILE=$(find ${WORKDIR} -maxdepth 1 -name "${DEBIAN_SOURCE}_*.dsc" -print)
>  
> -    sbuild -A -n -c ${SBUILD_CHROOT} --chroot-mode=schroot \
> +    sbuild -n -c ${SBUILD_CHROOT} --chroot-mode=schroot \
>          --host=${PACKAGE_ARCH} --build=${BUILD_ARCH} ${profiles} \
> +        ${@'--no-arch-all' if 'cross' in isar_deb_build_profiles(d).split() else '--arch-all'} \
>          --no-run-lintian --no-run-piuparts --no-run-autopkgtest --resolve-alternatives \
>          --bd-uninstallable-explainer=apt \
>          --no-apt-update --apt-distupgrade \

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/177b4f4c-069d-41b0-b510-07912b9ff912%40siemens.com.