From: Anton Mikanovich <amikan@ilbers.de>
To: isar-users@googlegroups.com
Cc: Anton Mikanovich <amikan@ilbers.de>
Subject: [PATCH 1/3] rootfs: Allow locking on single install command
Date: Wed, 10 Jun 2026 09:48:10 +0300 [thread overview]
Message-ID: <20260610064812.4010511-2-amikan@ilbers.de> (raw)
In-Reply-To: <20260610064812.4010511-1-amikan@ilbers.de>
In some cases only one command from all the ROOTFS_INSTALL_COMMAND list
can require isar-apt locking. To allow this logic improve flag checking
to accept the list of codenames. Existing API and codenames
("acquire-before" and "release-after") were not changed.
So the usage of single task declaration now looks like:
rootfs_install_cmd[isar-apt-lock] = "acquire-before release-after"
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
meta/classes-recipe/rootfs.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
index 8b502a50..dc4e702c 100644
--- a/meta/classes-recipe/rootfs.bbclass
+++ b/meta/classes-recipe/rootfs.bbclass
@@ -427,13 +427,13 @@ python do_rootfs_install() {
for cmd in cmds:
progress_reporter.next_stage()
- if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "acquire-before":
+ if "acquire-before" in (d.getVarFlag(cmd, 'isar-apt-lock') or ""):
lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") + "/isar.lock",
shared=True)
bb.build.exec_func(cmd, d)
- if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "release-after":
+ if "release-after" in (d.getVarFlag(cmd, 'isar-apt-lock') or ""):
bb.utils.unlockfile(lock)
progress_reporter.finish()
finally:
--
2.34.1
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260610064812.4010511-2-amikan%40ilbers.de.
next prev parent reply other threads:[~2026-06-10 6:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 6:48 [PATCH 0/3] Rootfs install race fix for isar-apt packages Anton Mikanovich
2026-06-10 6:48 ` Anton Mikanovich [this message]
2026-06-10 8:23 ` [PATCH 1/3] rootfs: Allow locking on single install command 'MOESSBAUER, Felix' via isar-users
2026-06-11 7:01 ` Anton Mikanovich
2026-06-11 10:08 ` 'MOESSBAUER, Felix' via isar-users
2026-06-10 6:48 ` [PATCH 2/3] rootfs: Download isar-apt packages under isar-apt lock Anton Mikanovich
2026-06-10 6:48 ` [PATCH 3/3] rootfs: Deny packages download during install Anton Mikanovich
2026-06-12 10:53 ` [PATCH 0/3] Rootfs install race fix for isar-apt packages Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610064812.4010511-2-amikan@ilbers.de \
--to=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox