From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: "amikan@ilbers.de" <amikan@ilbers.de>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH 1/3] rootfs: Allow locking on single install command
Date: Thu, 11 Jun 2026 10:08:23 +0000 [thread overview]
Message-ID: <e4057d6795a7c56c61b54ff605fb27e72a3f3f4e.camel@siemens.com> (raw)
In-Reply-To: <0d561b30-d3d1-4a26-ae45-16e61775ca68@ilbers.de>
On Thu, 2026-06-11 at 10:01 +0300, Anton Mikanovich wrote:
> 10.06.2026 11:23, MOESSBAUER, Felix wrote:
> > On Wed, 2026-06-10 at 09:48 +0300, Anton Mikanovich wrote:
> > > In some cases only one command from all the ROOTFS_INSTALL_COMMAND list
> > > can require isar-apt locking. To allow this logic improve flag checking
> > > to accept the list of codenames. Existing API and codenames
> > > ("acquire-before" and "release-after") were not changed.
> > >
> > > So the usage of single task declaration now looks like:
> > >
> > > rootfs_install_cmd[isar-apt-lock] = "acquire-before release-after"
> > Hi, does it even make sense to do an acquire release in two different
> > commands? To me this looks like a source for deadlocks.
> >
> > Felix
> Current implementation have 4 tasks combined in one lock section.
> This is done to be sure isar-apt will not changed between "apt-get update"
> and "apt-get install" commands. This probably can be reordered and
> optimized,
> but it will be out of scope for the current patchset.
Makes sense. Then the patchset is fine.
Reviewed-by: Felix Moessbauer <felix.moessbauer@siemens.com>
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e4057d6795a7c56c61b54ff605fb27e72a3f3f4e.camel%40siemens.com.
next prev parent reply other threads:[~2026-06-11 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 6:48 [PATCH 0/3] Rootfs install race fix for isar-apt packages Anton Mikanovich
2026-06-10 6:48 ` [PATCH 1/3] rootfs: Allow locking on single install command Anton Mikanovich
2026-06-10 8:23 ` 'MOESSBAUER, Felix' via isar-users
2026-06-11 7:01 ` Anton Mikanovich
2026-06-11 10:08 ` 'MOESSBAUER, Felix' via isar-users [this message]
2026-06-10 6:48 ` [PATCH 2/3] rootfs: Download isar-apt packages under isar-apt lock Anton Mikanovich
2026-06-10 6:48 ` [PATCH 3/3] rootfs: Deny packages download during install Anton Mikanovich
2026-06-12 10:53 ` [PATCH 0/3] Rootfs install race fix for isar-apt packages Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4057d6795a7c56c61b54ff605fb27e72a3f3f4e.camel@siemens.com \
--to=isar-users@googlegroups.com \
--cc=amikan@ilbers.de \
--cc=felix.moessbauer@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox