public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Felix Moessbauer' via isar-users" <isar-users@googlegroups.com>
To: isar-users@googlegroups.com
Cc: Felix Moessbauer <felix.moessbauer@siemens.com>,
	florian.bezdeka@siemens.com
Subject: [PATCH 1/1] fix(rootfs): close progress reporter after last step finished
Date: Mon, 29 Jun 2026 17:04:37 +0200	[thread overview]
Message-ID: <20260629150437.2980426-1-felix.moessbauer@siemens.com> (raw)

We currently stop the progress reporter after each step. This is
incorrect, as finish must only be called after the last step. However,
the impact is quite limited. Currently the only observable effect is
that - when running in debug mode - a summary of all previous execution
times is printed per step (instead of once).

We further want to call finish also if a step raises, hence we move it
to the finally block.

Fixes: eae54341 ("rootfs: Add missing umounts in rootfs ...")
Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/classes-recipe/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
index a58ad031..8e45c10d 100644
--- a/meta/classes-recipe/rootfs.bbclass
+++ b/meta/classes-recipe/rootfs.bbclass
@@ -458,8 +458,8 @@ python do_rootfs_install() {
 
             if "release-after" in (d.getVarFlag(cmd, 'isar-apt-lock') or ""):
                 bb.utils.unlockfile(lock)
-            progress_reporter.finish()
     finally:
+        progress_reporter.finish()
         bb.build.exec_func('rootfs_do_umounts', d)
 }
 addtask rootfs_install before do_rootfs_postprocess after do_unpack
-- 
2.53.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260629150437.2980426-1-felix.moessbauer%40siemens.com.

             reply	other threads:[~2026-06-29 15:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 15:04 'Felix Moessbauer' via isar-users [this message]
2026-06-30  9:55 ` 'Florian Bezdeka' via isar-users
2026-06-30 10:06   ` 'MOESSBAUER, Felix' via isar-users
2026-07-01  9:07 ` Zhihang Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260629150437.2980426-1-felix.moessbauer@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=florian.bezdeka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox